Update webrender to 7d9444a24fb98bcc41afdca2a5bf145d514500f1

RESOLVED FIXED in mozilla57

Status

()

Core
Graphics: WebRender
P1
normal
RESOLVED FIXED
10 months ago
8 months ago

People

(Reporter: rhunt, Assigned: kats)

Tracking

(Blocks: 2 bugs)

57 Branch
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 unaffected, firefox57 unaffected)

Details

(Whiteboard: [wr-mvp] [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

10 months ago
+++ This bug was initially created as a clone of Bug #1397831 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
status-firefox56: --- → unaffected
status-firefox57: --- → unaffected
(Assignee)

Updated

10 months ago
No longer depends on: 1390138
(Assignee)

Updated

10 months ago
No longer depends on: 1395637
(Assignee)

Updated

10 months ago
No longer depends on: 1396972
(Assignee)

Updated

10 months ago
No longer depends on: 1397770
(Assignee)

Updated

10 months ago
No longer depends on: 1397831
(Reporter)

Comment 1

10 months ago
WR @ 3d58efaecdc5897de057beab57adc031bc2e187e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfe328eb23a958a4f1c1f51d7563a25c36783832

Green.
(Reporter)

Updated

10 months ago
Assignee: rhunt → nobody
WR @ cd1855550857b910f752359b48c5cc053419c358

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfbe09ce6e8a6120ab258dc220b33f14c437c536
https://treeherder.mozilla.org/#/jobs?repo=try&revision=76bc8012322f38acdf9b0e9a3463edb6dc7a6b17

Ditto. Although it looks like we have a pretty consistent R4 failure which has been filed as bug 1382486.
WR @ b1fea4fce1005c35ef5566d7ba1733d65d6dc840

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d918df47e0a0889f6c0505947a5ea8221082b786

Busted, by servo/webrender#1606. Morris, can you please provide a patch for the gecko side?
Flags: needinfo?(mtseng)
Yes. I'll submit a patch asap.
Flags: needinfo?(mtseng)
Created attachment 8907387 [details] [diff] [review]
Update bindings.rs for interfaces changed.

MozReview-Commit-ID: Aq6jP4tcuoU
Attachment #8907387 - Flags: review?(bugmail)
(Assignee)

Updated

9 months ago
Blocks: 1392200
Comment on attachment 8907387 [details] [diff] [review]
Update bindings.rs for interfaces changed.

Review of attachment 8907387 [details] [diff] [review]:
-----------------------------------------------------------------

In general I like to mention the WR cset in the commit message so that it's easier to correlate the upstream WR changes to the gecko bindings changes. I can do that here when I land this.
Attachment #8907387 - Flags: review?(bugmail) → review+
So the push in comment 7 seems to have a talos g1 failure. Regression range:

*   c3252ec0 Auto merge of #1698 - glennw:gate-nightly, r=nical
|\
| * f94c2497 Gate builds on travis + rust nightly again.
* |   046cdf68 Auto merge of #1696 - MortimerGoro:texel_fetch_android, r=glennw
|\ \
| * | 207eedde Fix driver bugs in  texelFetchOffset calls on Android.
* | |   08e5d6f3 Auto merge of #1691 - glennw:tidy-types, r=nical
|\ \ \
| |_|/
|/| |
| * | 537744a0 Tidy up clip, simple, and composite instance types.
| * | c68309b1 Tidy up the blur instance struct, and fix render task id/address bug.
|  /
* |   47d40d9f Auto merge of #1687 - glennw:frame-output, r=kvark
|\ \
| * | f9b5e6cf Introduce frame output support.
| |/
* |   a51069c1 Auto merge of #1697 - glennw:ssl-fix, r=metajack
|\ \
| |/
|/|
| * 3670d233 Fix SSL errors on travis CI.
|/
*   b1fea4fc Auto merge of #1606 - mephisto41:backface-support, r=kvark
|\
| * afbc931d Update euclid version and Cargo.lock.
| * f8d76e0c Add test cases for backface visible.
| * dec5a432 Check backface visibility.
| * 02e21a58 Add is_backface_visible information to display item and primitive.
* a9bfde76 Auto merge of #1692 - nical:alpha-rect-dbg, r=kvark
* d3812e35 Add a debug flag to see alpha primitive rects.

I'm bisecting to see what caused it.
At b1fea4fce1005c35ef5566d7ba1733d65d6dc840 we still have the talos failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4bb3354a2908658b118c3e4dc16d040d3be29420

This narrows the regression range to this:

*   b1fea4fc Auto merge of #1606 - mephisto41:backface-support, r=kvark
|\
| * afbc931d Update euclid version and Cargo.lock.
| * f8d76e0c Add test cases for backface visible.
| * dec5a432 Check backface visibility.
| * 02e21a58 Add is_backface_visible information to display item and primitive.
* a9bfde76 Auto merge of #1692 - nical:alpha-rect-dbg, r=kvark
* d3812e35 Add a debug flag to see alpha primitive rects.
At a9bfde761329db8d63653b68c7833fbe85d34d61 we still have the talos failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbda2494034e983bdadcb900054508ad8e389639

Narrows the regression range to:

* a9bfde76 Auto merge of #1692 - nical:alpha-rect-dbg, r=kvark
* d3812e35 Add a debug flag to see alpha primitive rects.

... which seems pretty unlikely. It's possible this regressed on the gecko side, or something. I guess I should disable the test for now and get the WR update landed.
I verified that at cd1855550857b910f752359b48c5cc053419c358 we still get the talos failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af3f4d18c91172f17605978165507b404d2f3a47

So this is either due to a gecko-side change interacting with something in the WR range 6cf9cd4075efdf7467bad71b372170f626a8fce4..cd1855550857b910f752359b48c5cc053419c358. Or actually it might be due to the euclid bump which I neglected to take out from the last few try pushes. I'm doing another try push without the euclid bump to see if that's a factor.
(The gecko-side range is hg b0e945eed81d..987326974635)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to 7d9444a24fb98bcc41afdca2a5bf145d514500f1
Version: unspecified → 57 Branch
Comment on attachment 8907387 [details] [diff] [review]
Update bindings.rs for interfaces changed.

Obsoleting this as I moved it into my MozReview queue
Attachment #8907387 - Attachment is obsolete: true
(Assignee)

Comment 19

9 months ago
mozreview-review
Comment on attachment 8907815 [details]
Bug 1398241 - Update bindings.rs for interfaces changed in WR cset 02e21a58.

https://reviewboard.mozilla.org/r/179510/#review184672
Attachment #8907815 - Flags: review?(bugmail) → review+
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #12)
> I'm
> doing another try push without the euclid bump to see if that's a factor.

It's not a factor, the failure happens even without the euclid bump.
Comment on attachment 8907813 [details]
Bug 1398241 - Update webrender to commit 7d9444a24fb98bcc41afdca2a5bf145d514500f1.

https://reviewboard.mozilla.org/r/179506/#review184766
Attachment #8907813 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8907814 [details]
Bug 1398241 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/179508/#review184768
Attachment #8907814 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8907816 [details]
Bug 1398241 - Disable talos-g1 on webrender since it's failing again.

https://reviewboard.mozilla.org/r/179512/#review184770
Attachment #8907816 - Flags: review?(jmuizelaar) → review+

Comment 24

9 months ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s ba93b162ccda -d d68bccc30f7e: rebasing 420019:ba93b162ccda "Bug 1398241 - Update webrender to commit 7d9444a24fb98bcc41afdca2a5bf145d514500f1. r=jrmuizel"
rebasing 420020:f6ef6efa6a07 "Bug 1398241 - Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel"
merging toolkit/library/gtest/rust/Cargo.lock
merging toolkit/library/rust/Cargo.lock
warning: conflicts while merging toolkit/library/gtest/rust/Cargo.lock! (edit, then use 'hg resolve --mark')
warning: conflicts while merging toolkit/library/rust/Cargo.lock! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 29

9 months ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f7072c64b51
Update webrender to commit 7d9444a24fb98bcc41afdca2a5bf145d514500f1. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/091818dd3424
Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/cad3fc3f82ca
Update bindings.rs for interfaces changed in WR cset 02e21a58. r=kats
https://hg.mozilla.org/integration/autoland/rev/e78a745bb310
Disable talos-g1 on webrender since it's failing again. r=jrmuizel

Updated

9 months ago
Priority: P3 → P1
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
You need to log in before you can comment on or make changes to this bug.