Closed
Bug 1398376
Opened 7 years ago
Closed 7 years ago
Remove MOZILLA_INTERNAL_API checks from layout/base
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(3 files)
We have some MOZILLA_INTERNAL_API conditional code in layout/base/nsIPresShell.h and layout/base/nsPresContext.h. (These checks come from bug 659722, btw, before which point they were conditional on _IMPL_NS_LAYOUT) I'm pretty sure we can remove them, since these headers aren't included anywhere outside of libxul these days (and we don't support non-mozilla code that includes them at this point). Other recent similar bugs, for reference: bug 1340712, bug 1332622
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bac1fddfea00
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8906165 [details] Bug 1398376 part 1: Remove MOZILLA_INTERNAL_API guards from nsIPresShell.h and nsPresContext.h, since these headers are only used in libxul. https://reviewboard.mozilla.org/r/177896/#review182932
Attachment #8906165 -
Flags: review?(mats) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8906166 [details] Bug 1398376 part 2: Remove formerly-MOZILLA_INTERNAL_API-guarded FooExternal() functions from nsIPresShell and nsPresContext. https://reviewboard.mozilla.org/r/177898/#review182934
Attachment #8906166 -
Flags: review?(mats) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8906167 [details] Bug 1398376 part 3: Collapse formerly-MOZILLA_INTERNAL_API-guarded Foo()/FooInternal() functions together in nsIPresShell and nsPresContext. https://reviewboard.mozilla.org/r/177900/#review182936
Attachment #8906167 -
Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/207590617db7 part 1: Remove MOZILLA_INTERNAL_API guards from nsIPresShell.h and nsPresContext.h, since these headers are only used in libxul. r=mats https://hg.mozilla.org/integration/autoland/rev/ccc6362557e9 part 2: Remove formerly-MOZILLA_INTERNAL_API-guarded FooExternal() functions from nsIPresShell and nsPresContext. r=mats https://hg.mozilla.org/integration/autoland/rev/d7af87f6458e part 3: Collapse formerly-MOZILLA_INTERNAL_API-guarded Foo()/FooInternal() functions together in nsIPresShell and nsPresContext. r=mats
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/207590617db7 https://hg.mozilla.org/mozilla-central/rev/ccc6362557e9 https://hg.mozilla.org/mozilla-central/rev/d7af87f6458e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•