1398376 - Remove MOZILLA_INTERNAL_API checks from layout/base

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Daniel Holbert [:dholbert]]

We have some MOZILLA_INTERNAL_API conditional code in layout/base/nsIPresShell.h and layout/base/nsPresContext.h.

(These checks come from bug 659722, btw, before which point they were conditional on _IMPL_NS_LAYOUT)

I'm pretty sure we can remove them, since these headers aren't included anywhere outside of libxul these days (and we don't support non-mozilla code that includes them at this point).

Other recent similar bugs, for reference: bug 1340712, bug 1332622

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1398376 part 1: Remove MOZILLA_INTERNAL_API guards from nsIPresShell.h and nsPresContext.h, since these headers are only used in libxul.

This patch drops all MOZILLA_INTERNAL_API checks (and the bodies of any
associated "#else" clauses) from these files.  The basic assumption here is
that MOZILLA_INTERNAL_API is #defined in all (supported) compilation units that
#include these files, so the checks are superfluous and the #else clauses are
dead code.

(If this assumption is mistaken and there is some .cpp file in our codebase
that #includes this header and yet does not have MOZILLA_INTERNAL_API, we will
find out via bustage on treeherder.)

Review commit: https://reviewboard.mozilla.org/r/177896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177896/

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1398376 part 2: Remove formerly-MOZILLA_INTERNAL_API-guarded FooExternal() functions from nsIPresShell and nsPresContext.

These functions are now dead code.  And really, they were already dead code
even before this patch-stack -- they were only called in never-evaluated
(and now-deleted) #else clauses.

Review commit: https://reviewboard.mozilla.org/r/177898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177898/

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1398376 part 3: Collapse formerly-MOZILLA_INTERNAL_API-guarded Foo()/FooInternal() functions together in nsIPresShell and nsPresContext.

This is just simplifying things by eliminating a layer of now-unnecessary
abstraction.

Review commit: https://reviewboard.mozilla.org/r/177900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177900/

Comment 4

[Daniel Holbert [:dholbert]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bac1fddfea00

Comment 5

[Mats Palmgren (inactive)]

Comment on attachment 8906165 [details]
Bug 1398376 part 1: Remove MOZILLA_INTERNAL_API guards from nsIPresShell.h and nsPresContext.h, since these headers are only used in libxul.

https://reviewboard.mozilla.org/r/177896/#review182932

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 8906166 [details]
Bug 1398376 part 2: Remove formerly-MOZILLA_INTERNAL_API-guarded FooExternal() functions from nsIPresShell and nsPresContext.

https://reviewboard.mozilla.org/r/177898/#review182934

Comment 7

[Mats Palmgren (inactive)]

Comment on attachment 8906167 [details]
Bug 1398376 part 3: Collapse formerly-MOZILLA_INTERNAL_API-guarded Foo()/FooInternal() functions together in nsIPresShell and nsPresContext.

https://reviewboard.mozilla.org/r/177900/#review182936

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/207590617db7
part 1: Remove MOZILLA_INTERNAL_API guards from nsIPresShell.h and nsPresContext.h, since these headers are only used in libxul. r=mats
https://hg.mozilla.org/integration/autoland/rev/ccc6362557e9
part 2: Remove formerly-MOZILLA_INTERNAL_API-guarded FooExternal() functions from nsIPresShell and nsPresContext. r=mats
https://hg.mozilla.org/integration/autoland/rev/d7af87f6458e
part 3: Collapse formerly-MOZILLA_INTERNAL_API-guarded Foo()/FooInternal() functions together in nsIPresShell and nsPresContext. r=mats

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/207590617db7
https://hg.mozilla.org/mozilla-central/rev/ccc6362557e9
https://hg.mozilla.org/mozilla-central/rev/d7af87f6458e