1398552 - LLVM detection inserts quotes into PATH, preventing Windows utilities from being found

Status: RESOLVED DUPLICATE of bug 1383578

(Firefox Build System :: MozillaBuild, task)

Description

[Paul Goins]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170824053622

Steps to reproduce:

Prerequisite: LLVM was installed.
* Installed MozillaBuild per the Windows build guide (https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites).
* Ran start-shell.bat.
* Ran "which makecab".


Actual results:

Which displays:
which: makecab: unknown command


Expected results:

Which should display:
/c/WINDOWS/System32/makecab.exe

Comment 1

[Paul Goins]

This is quite easy to fix: line 42 of start-shell.bat has this line:

  SET PATH="%PATH%;!LLVMDIR!\bin"

The quote mark should be before PATH to prevent inserting literal quotes into the variable:

  SET "PATH=%PATH%;!LLVMDIR!\bin"

With this tweak, I clearly see the fix.

I'd submit a patch but I haven't got explicit approval from my employer yet...  I'll see if I can get that straightened away come Monday.

Comment 2

[Paul Goins]

Erm, bad English, sorry...  With the above tweak, I can find makecab as expected.