1383578 - Build failed from "ERROR: Cannot find makecab"

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Xidorn Quan [:xidorn] UTC+11]

After upgrading to MozillaBuild 3.0, I hit "ERROR: Cannot find makecab" during configuration.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

This is because at start-shell.bat line 42
>   SET PATH="%PATH%;!LLVMDIR!\bin"
the quotes are harmful, which changes the PATH to something like
> ...:/usr/local/bin:/mingw/bin:/bin:"C:/WINDOWS/System32:/c/WINDOWS:/c/WINDOWS/System32/Wbem:/c/Program Files/LLVM/bin"
and thus executables of Windows itself cannot be found.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I'm seeing this error as well.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This is a regression from bug 1260823. I wouldn't object to ripping that LLVM path setting code out entirely, but I got some pushback to doing so during the MozillaBuild 3.0 development cycle.

Anyway, ownership of MozillaBuild is now on coop's team, so I'm going to defer to them on further investigation. Sorry for the hassle :(. As a short-term fix, you can probably just revert that one-line change or remove the entire LLVM block in start-shell.bat.

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> As a
> short-term fix, you can probably just revert that one-line change or remove
> the entire LLVM block in start-shell.bat.

Confirmed that so far commenting-out SET PATH="%PATH%;!LLVMDIR!\bin" seems to work for me.

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

(In reply to Brian Birtles (:birtles) from comment #5)
> (In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> > As a
> > short-term fix, you can probably just revert that one-line change or remove
> > the entire LLVM block in start-shell.bat.
> 
> Confirmed that so far commenting-out SET PATH="%PATH%;!LLVMDIR!\bin" seems
> to work for me.

You don't necessarily need to commenting out... you can just remove the pair of quotes.

Comment 7

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #6)
> (In reply to Brian Birtles (:birtles) from comment #5)
> > (In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> > > As a
> > > short-term fix, you can probably just revert that one-line change or remove
> > > the entire LLVM block in start-shell.bat.
> > 
> > Confirmed that so far commenting-out SET PATH="%PATH%;!LLVMDIR!\bin" seems
> > to work for me.
> 
> You don't necessarily need to commenting out... you can just remove the pair
> of quotes.

I have spaces in my path. Without the quotes it breaks (or it did, hence why I filed bug 1260823).

Comment 8

[Chris Cooper [:coop] (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> This is a regression from bug 1260823. I wouldn't object to ripping that
> LLVM path setting code out entirely, but I got some pushback to doing so
> during the MozillaBuild 3.0 development cycle.
> 
> Anyway, ownership of MozillaBuild is now on coop's team, so I'm going to
> defer to them on further investigation. Sorry for the hassle :(. As a
> short-term fix, you can probably just revert that one-line change or remove
> the entire LLVM block in start-shell.bat.

Ryan: as a procedural question, with what frequency did you update MozillaBuild in the past? Did you roll new versions often, or wait for some threshold of required changes?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

No set schedule, typically was more of a push model of something in particular needing updating which then led to a new release. For an issue like this, spinning an updated release probably isn't a bad idea.

Comment 11

[Paul Goins]

As mentioned on bug 1398552, this is a slight error in the SET command.

As others have mentioned, not having quotes will cause problems if there are any paths with spaces.  However, having the quotes where they are (SET PATH="...") will place literal quotes in the PATH.

The correct way to do this is SET "PATH=...".  That will preserve any spaces, but won't tack on the quotes.  I've tested with this tweak on Windows 10 and it does resolve the issue.

I'll likely submit a patch tomorrow; I just need to make sure things are okay with my employer first regarding OSS code contributions.  Or if someone else wants to go ahead, feel free.

Comment 12

[Paul Goins]

Attachment: Fixed quoting of PATH variable modification

Comment 13

[Paul Goins]

Comment on attachment 8907425 [details] [diff] [review]
Fixed quoting of PATH variable modification

Patch submitted.  Ryan, could you take a look at this when you get a chance?

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8907425 [details] [diff] [review]
Fixed quoting of PATH variable modification

Thanks for the patch, Paul! Offhand, this looks fine to me, but I've handed off ownership of MozillaBuild at this point, so redirecting the review request to Ted.

Comment 15

[(not currently active) Ted Mielczarek]

Comment on attachment 8907425 [details] [diff] [review]
Fixed quoting of PATH variable modification

Review of attachment 8907425 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! Unfortunately I don't have a timeframe for when we'll get a new release out with this.

Comment 16

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/mozilla-build/rev/115a88792b1a482710a847453a2e9edcb119fb3f
bug 1383578 - Fixed quoting of PATH variable modification.  r=ryanvm,ted

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-build/rev/115a88792b1a
Fixed quoting of PATH variable modification.  r=ryanvm,ted

Comment 18

[Brian Birtles (:birtles, Feb 26~ parental leave)]

It seems like MozillaBuild 3.1 didn't pick up this change. After deleting mozilla-build and installing MozillaBuild 3.1 I still see:

  SET PATH="%PATH%;!LLVMDIR!\bin"

in start-shell.bat.

Filed as bug 1415364.