[Windows 7] The title bar color doesn't match the tab bar color in Light/Dark theme on Aero Basic

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
5 months ago
3 months ago

People

(Reporter: Ovidiu, Assigned: johannh)

Tracking

(Blocks: 1 bug)

57 Branch
Firefox 58
Unspecified
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

(Whiteboard: [reserve-photon-visual])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments)

(Reporter)

Description

5 months ago
Maybe there is a duplicate after this issue. 

[Affected versions]:

- Nightly 57.0a1(2017-09-10)
 
[Affected platforms]:

- Windows 7, Windows 10, Mac OS with "Light" theme.
 
[Steps to reproduce]:

1. Enabled the Title Bar
2. Change the browser theme (select"Light" or "Dark" ) 


Actual result:

The title bar color doesn't match the tab bar color. 

Expected result:

The title bar should match the tab bar color(see the behavior from the "Default" theme)

Note: We also saw this on Mac with the "Light" theme. For "Dark" theme there is bug 1392219.
(Reporter)

Comment 1

5 months ago
Created attachment 8906514 [details]
Light theme on Windows 7.png
(Reporter)

Comment 2

5 months ago
Created attachment 8906515 [details]
Default theme on Windows 7.png
(Reporter)

Updated

5 months ago
Whiteboard: [photon-visual][triage]

Updated

4 months ago
Flags: qe-verify+
Priority: -- → P4
QA Contact: ovidiu.boca
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
(Assignee)

Comment 3

4 months ago
This will be fixed in bug 1399498.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Depends on: 1399498
OS: Unspecified → Windows 7
Priority: P4 → P1
Summary: The title bar color doesn't match the tab bar color. → [Windows 7] The title bar color doesn't match the tab bar color.

Updated

4 months ago
Iteration: --- → 57.3 - Sep 19

Comment 4

4 months ago
Marking as resolved since Bug 1399498 has been resolved (see Comment #3 above).
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
See Also: → bug 1399498
(Reporter)

Comment 5

4 months ago
Created attachment 8915071 [details]
Windows classic theme (t browser theme defaul).png

I tested this on Windows 7 x64 with FF Nightly 58.0a1(2017-10-03) and I found an issue. Enabled the title bar and then set the Windows theme on "Windows 7 Basic" or "Windows Classic", a white line appears between the title bar and the tab bar.(for a better observation please use browser's light or dark theme).
Note: If I use Aero Theme(Windows 7) this issue is not reproducible. 
Please see the attached file with the actual result.
(Reporter)

Comment 6

4 months ago
Created attachment 8915085 [details]
Aero vs Windows 7 basic theme.png

I also have another observation: Giving the fact that on Aero theme (Windows 7) the title bar and the tab bar have a unique and uniform color the other Windows theme like "Windows 7 Basic" should have the same unique and uniform color between title bar and tab bar. 

Please see the attached file, where I did a comparison between Aero theme and Windows 7 Basic theme.
(Assignee)

Comment 7

3 months ago
Reopening because we should fix comment 6.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

3 months ago
Iteration: 57.3 - Sep 19 → ---
(Assignee)

Updated

3 months ago
Summary: [Windows 7] The title bar color doesn't match the tab bar color. → [Windows 7] The title bar color doesn't match the tab bar color in Light/Dark theme on Aero Basic
Comment hidden (mozreview-request)

Comment 9

3 months ago
mozreview-review
Comment on attachment 8919256 [details]
Bug 1398696 - Override the window background to Windows Aero Basic colors for Light/Dark theme on Windows 7.

https://reviewboard.mozilla.org/r/190158/#review195416
Attachment #8919256 - Flags: review?(dao+bmo) → review+

Comment 10

3 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de4a2586cbfd
Override the window background to Windows Aero Basic colors for Light/Dark theme on Windows 7. r=dao
https://hg.mozilla.org/mozilla-central/rev/de4a2586cbfd
Status: REOPENED → RESOLVED
Last Resolved: 4 months ago3 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
(Assignee)

Comment 12

3 months ago
Comment on attachment 8919256 [details]
Bug 1398696 - Override the window background to Windows Aero Basic colors for Light/Dark theme on Windows 7.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1399498
[User impact if declined]: See attachment 8915085 [details]. Users on Windows 7 Aero Basic have a plain white or dark window background, which looks bad and makes it impossible to see toolbar buttons.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Not really.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's a small CSS only patch that sets a background color. Even if something were wrong with that color, it's guaranteed to be limited to Windows 7 Aero Basic and light/dark theme by the surrounding media queries.
[String changes made/needed]: None
Attachment #8919256 - Flags: approval-mozilla-beta?
(Reporter)

Comment 13

3 months ago
Tested on Windows 7 x64 with FF Nightly 58.0a1(2017-10-18)

With "Windows 7 Basic" theme everything works as expected, but with "Windows Classic" theme the issue is still there.
Flags: needinfo?(jhofmann)
(Assignee)

Comment 14

3 months ago
(In reply to ovidiu boca[:Ovidiu] from comment #13)
> Tested on Windows 7 x64 with FF Nightly 58.0a1(2017-10-18)
> 
> With "Windows 7 Basic" theme everything works as expected, but with "Windows
> Classic" theme the issue is still there.

You mean comment 6? I can't see a white line there, can you point it out in the screenshot? In any case, please file a different bug for that.
Flags: needinfo?(jhofmann)
(Reporter)

Comment 15

3 months ago
In comment 6 the issue was observed on both: "Windows 7 Basic" theme and "Windows Classic" theme. I tested with "Windows 7 Basic" theme and everything works, but if I try with "Windows Classic" theme, the issue is still there, please see the actual result: https://imgur.com/a/fyHRk
(Assignee)

Comment 16

3 months ago
Again, that looks fine to me, can you please highlight or describe the issue somehow?
(Reporter)

Comment 17

3 months ago
The title bar and the tab bar have a unique and uniform color on "Aero" theme but are not the same with "Windows Classic" theme. I made a comparison here: https://imgur.com/a/1t1DW
(Assignee)

Comment 18

3 months ago
That is intended. :)
(Reporter)

Comment 19

3 months ago
Thanks for clearing this out :).

Comment 20

3 months ago
Comment on attachment 8919256 [details]
Bug 1398696 - Override the window background to Windows Aero Basic colors for Light/Dark theme on Windows 7.

severe regression, low risk fix, beta57+
Attachment #8919256 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 21

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/c64932850093
status-firefox57: affected → fixed
(Reporter)

Comment 22

3 months ago
I verified this on Windows 7 with FF Nightly 58.0a1(2017-10-18) and I can't reproduce the initial issue, based on this and on comment 18 this bug is verified fixed.
status-firefox58: fixed → verified
I have verified this issue on Windows 7 with Firefox Beta 57.0b10. The issue is verified fixed based on comment #18.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.