1398696 - [Windows 7] The title bar color doesn't match the tab bar color in Light/Dark theme on Aero Basic

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[ovidiu boca[:Ovidiu]]

Maybe there is a duplicate after this issue. 

[Affected versions]:

- Nightly 57.0a1(2017-09-10)
 
[Affected platforms]:

- Windows 7, Windows 10, Mac OS with "Light" theme.
 
[Steps to reproduce]:

1. Enabled the Title Bar
2. Change the browser theme (select"Light" or "Dark" ) 


Actual result:

The title bar color doesn't match the tab bar color. 

Expected result:

The title bar should match the tab bar color(see the behavior from the "Default" theme)

Note: We also saw this on Mac with the "Light" theme. For "Dark" theme there is bug 1392219.

Comment 1

[ovidiu boca[:Ovidiu]]

Attachment: Light theme on Windows 7.png

Comment 2

[ovidiu boca[:Ovidiu]]

Attachment: Default theme on Windows 7.png

Comment 3

[Johann Hofmann [:johannh]]

This will be fixed in bug 1399498.

Comment 4

[Marco Mucci [:MarcoM]]

Marking as resolved since Bug 1399498 has been resolved (see Comment #3 above).

Comment 5

[ovidiu boca[:Ovidiu]]

Attachment: Windows classic theme (t browser theme defaul).png

I tested this on Windows 7 x64 with FF Nightly 58.0a1(2017-10-03) and I found an issue. Enabled the title bar and then set the Windows theme on "Windows 7 Basic" or "Windows Classic", a white line appears between the title bar and the tab bar.(for a better observation please use browser's light or dark theme).
Note: If I use Aero Theme(Windows 7) this issue is not reproducible. 
Please see the attached file with the actual result.

Comment 6

[ovidiu boca[:Ovidiu]]

Attachment: Aero vs Windows 7 basic theme.png

I also have another observation: Giving the fact that on Aero theme (Windows 7) the title bar and the tab bar have a unique and uniform color the other Windows theme like "Windows 7 Basic" should have the same unique and uniform color between title bar and tab bar. 

Please see the attached file, where I did a comparison between Aero theme and Windows 7 Basic theme.

Comment 7

[Johann Hofmann [:johannh]]

Reopening because we should fix comment 6.

Comment 8

[Johann Hofmann [:johannh]]

Attachment: Bug 1398696 - Override the window background to Windows Aero Basic colors for Light/Dark theme on Windows 7.

This color is originally set to the accent-color of lwthemes, which is expected,
but we want to have the original Aero Basic look in the background on Windows 7
for light/dark and themes to mirror the default theme.

Review commit: https://reviewboard.mozilla.org/r/190158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190158/

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8919256 [details]
Bug 1398696 - Override the window background to Windows Aero Basic colors for Light/Dark theme on Windows 7.

https://reviewboard.mozilla.org/r/190158/#review195416

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de4a2586cbfd
Override the window background to Windows Aero Basic colors for Light/Dark theme on Windows 7. r=dao

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/de4a2586cbfd

Comment 12

[Johann Hofmann [:johannh]]

Comment on attachment 8919256 [details]
Bug 1398696 - Override the window background to Windows Aero Basic colors for Light/Dark theme on Windows 7.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1399498
[User impact if declined]: See attachment 8915085 [details]. Users on Windows 7 Aero Basic have a plain white or dark window background, which looks bad and makes it impossible to see toolbar buttons.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Not really.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's a small CSS only patch that sets a background color. Even if something were wrong with that color, it's guaranteed to be limited to Windows 7 Aero Basic and light/dark theme by the surrounding media queries.
[String changes made/needed]: None

Comment 13

[ovidiu boca[:Ovidiu]]

Tested on Windows 7 x64 with FF Nightly 58.0a1(2017-10-18)

With "Windows 7 Basic" theme everything works as expected, but with "Windows Classic" theme the issue is still there.

Comment 14

[Johann Hofmann [:johannh]]

(In reply to ovidiu boca[:Ovidiu] from comment #13)
> Tested on Windows 7 x64 with FF Nightly 58.0a1(2017-10-18)
> 
> With "Windows 7 Basic" theme everything works as expected, but with "Windows
> Classic" theme the issue is still there.

You mean comment 6? I can't see a white line there, can you point it out in the screenshot? In any case, please file a different bug for that.

Comment 15

[ovidiu boca[:Ovidiu]]

In comment 6 the issue was observed on both: "Windows 7 Basic" theme and "Windows Classic" theme. I tested with "Windows 7 Basic" theme and everything works, but if I try with "Windows Classic" theme, the issue is still there, please see the actual result: https://imgur.com/a/fyHRk

Comment 16

[Johann Hofmann [:johannh]]

Again, that looks fine to me, can you please highlight or describe the issue somehow?

Comment 17

[ovidiu boca[:Ovidiu]]

The title bar and the tab bar have a unique and uniform color on "Aero" theme but are not the same with "Windows Classic" theme. I made a comparison here: https://imgur.com/a/1t1DW

Comment 18

[Johann Hofmann [:johannh]]

That is intended. :)

Comment 19

[ovidiu boca[:Ovidiu]]

Thanks for clearing this out :).

Comment 20

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8919256 [details]
Bug 1398696 - Override the window background to Windows Aero Basic colors for Light/Dark theme on Windows 7.

severe regression, low risk fix, beta57+

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c64932850093

Comment 22

[ovidiu boca[:Ovidiu]]

I verified this on Windows 7 with FF Nightly 58.0a1(2017-10-18) and I can't reproduce the initial issue, based on this and on comment 18 this bug is verified fixed.

Comment 23

[Alexandru Simonca [:asimonca], Release Desktop QA]

I have verified this issue on Windows 7 with Firefox Beta 57.0b10. The issue is verified fixed based on comment #18.