Add more overhead to the webext talos WebExtension

RESOLVED FIXED in Firefox 57

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [PI:September])

Attachments

(6 attachments)

Assignee

Description

2 years ago
The initial version of this test was a good starting point for measuring baseline performance, but since it doesn't use any APIs, it doesn't give us a good idea of how our changes affect performance for real world users. Recent changes that have made a dramatic impact on the performance of real world extensions haven't shown up on talos at all.

At the minimum, I think the test extension needs to:

- Include several blocking webRequest listeners.
- Include at least some common tab listeners.
- Use messaging to and from content scripts.
- Include a browserAction and/or pageAction that it updates occasionally.
:kmag, is this something you are planning on working on?  I like the idea of this and glad you are outlining what needs to be done.

If you are not planning on working on it, are there examples of some of these transactions?
Flags: needinfo?(kmaglione+bmo)
Whiteboard: [PI:September]
Assignee

Comment 2

2 years ago
Yup. That's why I assigned it to myself :)
Flags: needinfo?(kmaglione+bmo)
Assignee

Updated

2 years ago
Depends on: 1399005
Comment hidden (mozreview-request)
Assignee

Comment 9

2 years ago
Will update and sign the XPI after review.
Just a thought, haven't looked at patches yet, a sidebar would always be available in ui.
Assignee

Comment 11

2 years ago
I'm not particularly interested in sidebars. They don't run in the main process, so they aren't likely to cause performance issues except when they're being manipulated, and they're not an especially popular feature in any case.

Comment 12

2 years ago
mozreview-review
Comment on attachment 8906887 [details]
Bug 1398974: Part 1 - Add webRequest listeners to webext talos add-on.

https://reviewboard.mozilla.org/r/178626/#review183750

sort of a rubber stamp here, I don't know much about webextensions.
Attachment #8906887 - Flags: review?(jmaher) → review+

Comment 13

2 years ago
mozreview-review
Comment on attachment 8906888 [details]
Bug 1398974: Part 2 - Add tab listeners to webext talos add-on.

https://reviewboard.mozilla.org/r/178628/#review183754

more of a rubber stamp, nothing raises concern
Attachment #8906888 - Flags: review?(jmaher) → review+

Comment 14

2 years ago
mozreview-review
Comment on attachment 8906889 [details]
Bug 1398974: Part 3 - Add pageAction to webext talos add-on.

https://reviewboard.mozilla.org/r/178630/#review183756

glad you remembered to add icon.png
Attachment #8906889 - Flags: review?(jmaher) → review+

Comment 15

2 years ago
mozreview-review
Comment on attachment 8906890 [details]
Bug 1398974: Part 4 - Add browserAction to webext talos add-on.

https://reviewboard.mozilla.org/r/178632/#review183758
Attachment #8906890 - Flags: review?(jmaher) → review+

Comment 16

2 years ago
mozreview-review
Comment on attachment 8906891 [details]
Bug 1398974: Part 5 - Add content script to webext talos add-on.

https://reviewboard.mozilla.org/r/178634/#review183762

::: testing/talos/talos/webextensions/dummy/manifest.json:21
(Diff revision 1)
>    ],
>    "background": {"scripts": ["background.js"]},
> +  "content_scripts": [
> +    {
> +      "matches": ["<all_urls>"],
> +      "js": ["content.js"]

does content.js exist?
Attachment #8906891 - Flags: review?(jmaher) → review+

Comment 17

2 years ago
mozreview-review
Comment on attachment 8906892 [details]
Bug 1398974: Part 6 - Add content script messaging to webext talos add-on.

https://reviewboard.mozilla.org/r/178636/#review183764

10-4!
Attachment #8906892 - Flags: review?(jmaher) → review+

Comment 18

2 years ago
mozreview-review
Comment on attachment 8906887 [details]
Bug 1398974: Part 1 - Add webRequest listeners to webext talos add-on.

https://reviewboard.mozilla.org/r/178626/#review183884
Attachment #8906887 - Flags: review?(mixedpuppy) → review+

Comment 19

2 years ago
mozreview-review
Comment on attachment 8906888 [details]
Bug 1398974: Part 2 - Add tab listeners to webext talos add-on.

https://reviewboard.mozilla.org/r/178628/#review183886
Attachment #8906888 - Flags: review?(mixedpuppy) → review+

Comment 20

2 years ago
mozreview-review
Comment on attachment 8906889 [details]
Bug 1398974: Part 3 - Add pageAction to webext talos add-on.

https://reviewboard.mozilla.org/r/178630/#review183888
Attachment #8906889 - Flags: review?(mixedpuppy) → review+

Comment 21

2 years ago
mozreview-review
Comment on attachment 8906890 [details]
Bug 1398974: Part 4 - Add browserAction to webext talos add-on.

https://reviewboard.mozilla.org/r/178632/#review183892
Attachment #8906890 - Flags: review?(mixedpuppy) → review+

Comment 22

2 years ago
mozreview-review
Comment on attachment 8906891 [details]
Bug 1398974: Part 5 - Add content script to webext talos add-on.

https://reviewboard.mozilla.org/r/178634/#review183894
Attachment #8906891 - Flags: review?(mixedpuppy) → review+

Comment 23

2 years ago
mozreview-review
Comment on attachment 8906892 [details]
Bug 1398974: Part 6 - Add content script messaging to webext talos add-on.

https://reviewboard.mozilla.org/r/178636/#review183896
Attachment #8906892 - Flags: review?(mixedpuppy) → review+
Assignee

Comment 24

2 years ago
mozreview-review-reply
Comment on attachment 8906891 [details]
Bug 1398974: Part 5 - Add content script to webext talos add-on.

https://reviewboard.mozilla.org/r/178634/#review183762

> does content.js exist?

Yup, it was already there. Don't know why.
Assignee

Comment 25

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ec271cc83a02723b7db3b8d90be1da659c71cb6
Bug 1398974: Part 1 - Add webRequest listeners to webext talos add-on. r=mixedpuppy,jmaher

https://hg.mozilla.org/integration/mozilla-inbound/rev/959398912fee4d16883cf01e37e75879716f9c1a
Bug 1398974: Part 2 - Add tab listeners to webext talos add-on. r=mixedpuppy,jmaher

https://hg.mozilla.org/integration/mozilla-inbound/rev/28b7ba19f12bc685f629b48c3260ba36e1af33c4
Bug 1398974: Part 3 - Add pageAction to webext talos add-on. r=mixedpuppy,jmaher

https://hg.mozilla.org/integration/mozilla-inbound/rev/e3cb7f8e1174bb72ece2d5525961d50ace533275
Bug 1398974: Part 4 - Add browserAction to webext talos add-on. r=mixedpuppy,jmaher

https://hg.mozilla.org/integration/mozilla-inbound/rev/52e225228c3e1297d246bdb34863bcbc8c0c9653
Bug 1398974: Part 5 - Add content script to webext talos add-on. r=mixedpuppy,jmaher

https://hg.mozilla.org/integration/mozilla-inbound/rev/59069fc4ad5150fbb002628a618e4fdb009f7b40
Bug 1398974: Part 6 - Add content script messaging to webext talos add-on. r=mixedpuppy,jmaher

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ff73d0599c56ec91210cd1a936aa85e9597153e
Bug 1398974: Part 7 - Update and sign talos webext extension. r=me

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f6d9ea5a49e003309f5f92ff155accb91c2f474
Bug 1398974: Follow-up: Disconnect StreamFilters when closing extension context. r=me
Assignee

Comment 26

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7877592dff7303ae4bff285b9d51e0ed9c784d1
Backed out changeset 6ff73d0599c5 (bug 1398974) for still being flaky on Winodws. r=backout
Assignee

Updated

2 years ago
Depends on: 1399646
Assignee

Comment 28

2 years ago
I had to back out the XPI update for issues on Windows when the stream filter parts of it were active.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 30

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fbfb64d7b9b351e557785987baecf4e0cbd1649
Backed out changeset 71761ab92e6d (bug 1398974) for OS-X bustage. r=backout
Assignee

Comment 32

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/edd825dd3b1f017ca18b1eb50e2d439e02425240
Bug 1398974: Follow-up: Skip adding request filters to favicon.ico requests. r=me
You need to log in before you can comment on or make changes to this bug.