1399050 - Inherited scale need to apply to children if children have 3d transform.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

layout/reftests/transform-3d/perspective-origin-4a.html is failed due to this.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1399050 - Apply inherited scale on 3d transform as well.

Review commit: https://reviewboard.mozilla.org/r/178710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178710/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8906961 [details]
Bug 1399050 - Apply inherited scale on 3d transform as well.

https://reviewboard.mozilla.org/r/178710/#review183774

Please also add pref(gfx.webrender.layers-free,true) to the perspective-origin-4a.html reftest line. That way we run that reftest with layers-free and ensure we don't regress that going forward. Ethan did something similar in bug 1392523 for other reftests, but I now think we shouldn't bother with running tests in both layers-full and layers-free mode. We should just run them in layers-free if they are passing there, and start phasing out layers-full mode completely.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Yes, but perspective-origin also depend on bug 1394306. I'll add the pref annotation in the bug 1394306.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=00ec9a8ab8bab86b9b5b82763fe2d8148ede3f35

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9338a7982a4
Apply inherited scale on 3d transform as well. r=kats

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e9338a7982a4