Closed Bug 1399050 Opened 7 years ago Closed 7 years ago

Inherited scale need to apply to children if children have 3d transform.

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: mtseng, Assigned: mtseng)

References

Details

(Whiteboard: [wr-mvp] gfx-noted)

Attachments

(1 file)

layout/reftests/transform-3d/perspective-origin-4a.html is failed due to this.
Summary: Inherited scale need to apply to children if children are 3d transform. → Inherited scale need to apply to children if children have 3d transform.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla57
Comment on attachment 8906961 [details]
Bug 1399050 - Apply inherited scale on 3d transform as well.

https://reviewboard.mozilla.org/r/178710/#review183774

Please also add pref(gfx.webrender.layers-free,true) to the perspective-origin-4a.html reftest line. That way we run that reftest with layers-free and ensure we don't regress that going forward. Ethan did something similar in bug 1392523 for other reftests, but I now think we shouldn't bother with running tests in both layers-full and layers-free mode. We should just run them in layers-free if they are passing there, and start phasing out layers-full mode completely.
Attachment #8906961 - Flags: review?(bugmail) → review+
Yes, but perspective-origin also depend on bug 1394306. I'll add the pref annotation in the bug 1394306.
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9338a7982a4
Apply inherited scale on 3d transform as well. r=kats
Depends on: 1403459
You need to log in before you can comment on or make changes to this bug.