1403459 - Fix transform 3d/sorting try failures for layers-free

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Fix fails-if in following tests.

fails-if(webrender) != sorting-1a.html sorting-1-ref.html
fails-if(webrender) == sorting-2a.html sorting-2-ref.html

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

I have a gecko patch for this. However, webrender had some bugs for handling 3d transform. I'll fix webrender first.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1403459 - Passing transform-style from display item directly.

Review commit: https://reviewboard.mozilla.org/r/188606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188606/

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Also need webrender fix. The PR is here https://github.com/servo/webrender/pull/1787

The try combined gecko and webrender patch is here.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=958197010292b196df56583fe54a7d6cb7fbbf3f&selectedJob=136157668

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8917663 [details]
Bug 1403459 - Passing transform-style from display item directly.

https://reviewboard.mozilla.org/r/188606/#review194000

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

kats, since webrender PR has been merged. Would you mind land this patch along with next webrender update? Thanks.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Yup, will do.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Two of the reftests that this patch marked as passing are from the WR update, so I moved those reftest.list changes into bug 1407213. I'll rebase this patch on top of those patches and land it after the WR update.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1403459 - Passing transform-style from display item directly.

Review commit: https://reviewboard.mozilla.org/r/189210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189210/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8917663 [details]
Bug 1403459 - Passing transform-style from display item directly.

Obsoleting the old patch

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8918391 [details]
Bug 1403459 - Passing transform-style from display item directly.

https://reviewboard.mozilla.org/r/189210/#review194492

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74a760610fd0
Passing transform-style from display item directly. r=kats

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/74a760610fd0