Closed Bug 1403459 Opened 4 years ago Closed 4 years ago

Fix transform 3d/sorting try failures for layers-free

Categories

(Core :: Graphics: WebRender, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: mtseng, Assigned: mtseng)

References

Details

(Whiteboard: [wr-mvp] gfx-noted)

Attachments

(1 file, 1 obsolete file)

Fix fails-if in following tests.

fails-if(webrender) != sorting-1a.html sorting-1-ref.html
fails-if(webrender) == sorting-2a.html sorting-2-ref.html
Status: NEW → ASSIGNED
I have a gecko patch for this. However, webrender had some bugs for handling 3d transform. I'll fix webrender first.
Comment on attachment 8917663 [details]
Bug 1403459 - Passing transform-style from display item directly.

https://reviewboard.mozilla.org/r/188606/#review194000
Attachment #8917663 - Flags: review?(bugmail) → review+
kats, since webrender PR has been merged. Would you mind land this patch along with next webrender update? Thanks.
Flags: needinfo?(bugmail)
Yup, will do.
Flags: needinfo?(bugmail)
Two of the reftests that this patch marked as passing are from the WR update, so I moved those reftest.list changes into bug 1407213. I'll rebase this patch on top of those patches and land it after the WR update.
Comment on attachment 8917663 [details]
Bug 1403459 - Passing transform-style from display item directly.

Obsoleting the old patch
Attachment #8917663 - Attachment is obsolete: true
Comment on attachment 8918391 [details]
Bug 1403459 - Passing transform-style from display item directly.

https://reviewboard.mozilla.org/r/189210/#review194492
Attachment #8918391 - Flags: review?(bugmail) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74a760610fd0
Passing transform-style from display item directly. r=kats
https://hg.mozilla.org/mozilla-central/rev/74a760610fd0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Depends on: 1419820
Depends on: 1420497
Depends on: 1420494
You need to log in before you can comment on or make changes to this bug.