List all tabs icon is smaller than expected

NEW
Unassigned

Status

()

Firefox
Theme
P5
normal
10 months ago
8 months ago

People

(Reporter: Valentina Claudia Ona, Unassigned)

Tracking

(Blocks: 1 bug)

57 Branch
Unspecified
All
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox57 wontfix)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(6 attachments)

(Reporter)

Description

10 months ago
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170912013600 

[Affected versions]:  Nightly 57.0a1

[Affected platforms]:  Windows 8.1 x64

[Steps to reproduce]:
1.Launch Nightly 57.0a1 with a new profile.
2.Open the Customization menu.

[Expected result]:
The icons from the screenshot,arrows down and right should match the specifications.

[Actual result]:
The icons from the screenshot,arrows down and right doesn't match the specifications.
Please verify the attachment where you will see exactly which one.

Comment 1

10 months ago
There is no attachment.
Flags: needinfo?(valentina.ona)
(Reporter)

Comment 2

10 months ago
Created attachment 8907020 [details]
icons.asf

Sorry! i attached one more time.
Flags: needinfo?(valentina.ona)

Updated

10 months ago
No longer blocks: 1325171
Whiteboard: [photon-visual][triage] → [photon-structure][triage]

Comment 3

10 months ago
What's an "asf" file? Why isn't a normal png screenshot an option here?
Flags: needinfo?(valentina.ona)
(Reporter)

Comment 4

10 months ago
Created attachment 8907034 [details]
down arrow.bmp

The down arrow(list all tabs button) has a small size than in the specifications.
The screenshot icon is different from the specifications.

https://streamable.com/4y18q
Flags: needinfo?(valentina.ona)
(Reporter)

Comment 5

10 months ago
Created attachment 8907035 [details]
screenshot icon.bmp

Comment 6

10 months ago
The screenshots icon is supposed to have a notification thingy (blue star) on it, so that's not a bug.

I don't really understand what the issue with the arrows is, but judging from the screenshots it has nothing to do with customize mode as the screenshots were taken outside of customize mode.
Blocks: 1355767
Summary: The icons from the customization doesn't respect the specifications. → List all tabs and/or tab scroller buttons doesn't/don't match specced icon(s)
Whiteboard: [photon-structure][triage] → [photon-visual][triage]

Comment 7

10 months ago
(In reply to :Gijs from comment #6)
> I don't really understand what the issue with the arrows is, but judging
> from the screenshots it has nothing to do with customize mode as the
> screenshots were taken outside of customize mode.

Most of the video is from menus, although I don't understand what it's supposed to demonstrate.
No longer blocks: 1355767
Whiteboard: [photon-visual][triage]

Comment 8

10 months ago
OK, this really needs more specifics about what this bug is trying to point out. Please provide more detailed steps to reproduce (if required), and clarify which buttons/arrows are wrong, and which bits of the spec you think they're not matching. I'm also unclear if comment #0 means this *only* reproduces on win8 (and not on win10, or win7, or osx, or...), or if that's just where you happened to test for this bug.
Flags: needinfo?(valentina.ona)
(Reporter)

Comment 9

10 months ago
Created attachment 8907058 [details]
IMG_12092017_160324_0.png

I verify the issue on windows 10 x64 and isnot the same on windows 8.1 x64
I will right you the steps for the screenshot icon.

[Step to reproduce]: 
1. Open a new tab.
2. Go to www.facebook.com
3. Press on "Page action"

[Expected results]: [Expected result]:
The icon from the screenshot should match the specifications.


[Actual results]:
The icon from the screenshot doesn't match the specifications.

[Note]: verify the attachment.


I have 2 different outputs, witch one is the correct one?
Flags: needinfo?(valentina.ona)

Comment 10

10 months ago
(In reply to Valentina Claudia Ona from comment #9)
> Created attachment 8907058 [details]
> IMG_12092017_160324_0.png
> 
> I verify the issue on windows 10 x64 and isnot the same on windows 8.1 x64
> I will right you the steps for the screenshot icon.
> 
> [Step to reproduce]: 
> 1. Open a new tab.
> 2. Go to www.facebook.com
> 3. Press on "Page action"
> 
> [Expected results]: [Expected result]:
> The icon from the screenshot should match the specifications.
> 
> 
> [Actual results]:
> The icon from the screenshot doesn't match the specifications.
> 
> [Note]: verify the attachment.
> 
> 
> I have 2 different outputs, witch one is the correct one?

It depends on whether you've used screenshots before now. It should be the same on a fully clean profile on both OSes. If it's not, please file a github issue against screenshots ( https://github.com/mozilla-services/screenshots ).

So are there other issues with the arrows still, or should we close this bug? Based on the above comment I'm not really sure.
Flags: needinfo?(valentina.ona)
(Reporter)

Comment 11

10 months ago
Created attachment 8907062 [details]
down arrow.bmp

For the arrow i will right the steps:

[Step to reproduce]:

1. Launch Nightly 57.0a1.
2. Open multiple tabs until it appears "list all tabs" button.

[Expected results]: The arrow from "list all tabs" button has a small size then the specifications.


[Actual results]:The arrow from "list all tabs" button should match the specifications. 

[Note]: 

Take a look on the attachment.
Flags: needinfo?(valentina.ona)
(Reporter)

Comment 12

10 months ago
I retested with a new profile on both and you're right.

Comment 13

10 months ago
This changed as part of the photon icon drop, it seems. I don't know if that was desired or not.
Blocks: 1355455
Summary: List all tabs and/or tab scroller buttons doesn't/don't match specced icon(s) → List all tabs icon is smaller than expected
Whiteboard: [photon-visual][triage]

Comment 14

10 months ago
Stephen, we're using the generic arrow-dropdown-16.svg image, the same as for the location bar dropdown for instance. What if anything should change here?
Flags: needinfo?(shorlander)
Created attachment 8907602 [details]
icons Ubuntu 16.04.png

Reproducible on Ubuntu 16.04 x64
OS: Windows → All

Updated

10 months ago
Priority: -- → P5

Updated

10 months ago
Flags: qe-verify?
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Collecting various issues to look into in bug 1408395.

Thanks!
Flags: needinfo?(shorlander)

Updated

9 months ago
Flags: qe-verify? → qe-verify+

Updated

9 months ago
status-firefox57: affected → wontfix
You need to log in before you can comment on or make changes to this bug.