Closed
Bug 1399226
Opened 7 years ago
Closed 7 years ago
Add high-res icons, image placeholders and bug fixes to Activity Stream
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
(Whiteboard: [export])
User Story
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•7 years ago
|
User Story: (updated)
Summary: Add ... and bug fixes to Activity Stream → Add high-res icons, image placeholders and bug fixes to Activity Stream
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8907334 [details] Bug 1399226 - Add high-res icons, image placeholders and bug fixes to Activity Stream. https://reviewboard.mozilla.org/r/179008/#review184102 ::: browser/extensions/activity-stream/data/content/tippytop/top_sites.json:39 (Diff revision 1) > "url": "https://www.facebook.com/", > "image_url": "facebook-com@2x.png" > }, > { > "title": "leboncoin", > "url": "http://www.leboncoin.fr/", Based on the website, I think this wants to be https://www.leboncoin.fr/. That shouldn't block this from landing, but probably worth filing an issues in github. ::: browser/extensions/activity-stream/lib/TelemetryFeed.jsm:206 (Diff revision 1) > perf: {load_trigger_type: "unexpected"} > }; > > + if (url) { > + session.page = url; > + } This is harmless, but I meant to remove it. I'll file a github issue for that.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8907334 [details] Bug 1399226 - Add high-res icons, image placeholders and bug fixes to Activity Stream. https://reviewboard.mozilla.org/r/179008/#review184106 Looks good, just a couple of nits that don't block landing it.
Attachment #8907334 -
Flags: review?(dmose) → review+
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Dan Mosedale (:dmose) from comment #2) > browser/extensions/activity-stream/data/content/tippytop/top_sites.json:39 > > "url": "http://www.leboncoin.fr/", > Based on the website, I think this wants to be https://www.leboncoin.fr/. We actually show the https as the top site, but for matching tippy top image, it doesn't care about protocol.
Assignee | ||
Updated•7 years ago
|
Pushed by edilee@gmail.com: https://hg.mozilla.org/integration/autoland/rev/82f171552905 Add high-res icons, image placeholders and bug fixes to Activity Stream. r=dmose
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/82f171552905
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•6 years ago
|
Assignee: nobody → edilee
Assignee | ||
Updated•6 years ago
|
Whiteboard: [export]
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•