Closed Bug 1399226 Opened 3 years ago Closed 3 years ago

Add high-res icons, image placeholders and bug fixes to Activity Stream

Categories

(Firefox :: New Tab Page, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [export])

User Story

https://github.com/mozilla/activity-stream/compare/34849eee87f87757ceef81b8386e2a1594dc6ee4...781e5de523309dbba06f28104d2172339bc5b80b

Attachments

(1 file)

No description provided.
User Story: (updated)
Summary: Add ... and bug fixes to Activity Stream → Add high-res icons, image placeholders and bug fixes to Activity Stream
Depends on: 1399200, 1398955
Comment on attachment 8907334 [details]
Bug 1399226 - Add high-res icons, image placeholders and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/179008/#review184102

::: browser/extensions/activity-stream/data/content/tippytop/top_sites.json:39
(Diff revision 1)
>      "url": "https://www.facebook.com/",
>      "image_url": "facebook-com@2x.png"
>    },
>    {
>      "title": "leboncoin",
>      "url": "http://www.leboncoin.fr/",

Based on the website, I think this wants to be https://www.leboncoin.fr/.  That shouldn't block this from landing, but probably worth filing an issues in github.

::: browser/extensions/activity-stream/lib/TelemetryFeed.jsm:206
(Diff revision 1)
>        perf: {load_trigger_type: "unexpected"}
>      };
>  
> +    if (url) {
> +      session.page = url;
> +    }

This is harmless, but I meant to remove it.  I'll file a github issue for that.
Comment on attachment 8907334 [details]
Bug 1399226 - Add high-res icons, image placeholders and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/179008/#review184106

Looks good, just a couple of nits that don't block landing it.
Attachment #8907334 - Flags: review?(dmose) → review+
(In reply to Dan Mosedale (:dmose) from comment #2)
> browser/extensions/activity-stream/data/content/tippytop/top_sites.json:39
> >      "url": "http://www.leboncoin.fr/",
> Based on the website, I think this wants to be https://www.leboncoin.fr/. 
We actually show the https as the top site, but for matching tippy top image, it doesn't care about protocol.
Depends on: 1352459, 1398819
Depends on: 1398715
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/82f171552905
Add high-res icons, image placeholders and bug fixes to Activity Stream. r=dmose
https://hg.mozilla.org/mozilla-central/rev/82f171552905
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Blocks: 1399607
Depends on: 1399686
No longer depends on: 1399686
Assignee: nobody → edilee
Whiteboard: [export]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.