1399348 - Intermittent browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_executeScript_bad.js | Uncaught exception - [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.createUnique]"

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=130516577&repo=autoland

https://queue.taskcluster.net/v1/task/ASJ6IGYOR96f2P6Ewr-BhQ/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

8 failures in 1032 pushes (0.008 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 4
* autoland: 4

Platform breakdown:
* windows7-32: 4
* windows8-64: 3
* windows7-32-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-09-11&endday=2017-09-17&tree=all

Comment 2

[Intermittent Failures Robot]

2 failures in 943 pushes (0.002 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 2

Platform breakdown:
* windows7-32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-09-18&endday=2017-09-24&tree=all

Comment 3

[Intermittent Failures Robot]

13 failures in 885 pushes (0.015 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 5
* mozilla-inbound: 4
* mozilla-central: 3
* try: 1

Platform breakdown:
* windows7-32: 4
* windows10-64: 4
* windows7-32-stylo-disabled: 3
* windows10-64-stylo-disabled: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-09-25&endday=2017-10-01&tree=all

Comment 4

[Intermittent Failures Robot]

5 failures in 824 pushes (0.006 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 3
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* windows10-64-stylo-disabled: 2
* windows7-32-stylo-disabled: 1
* windows7-32: 1
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-10-02&endday=2017-10-08&tree=all

Comment 5

[Intermittent Failures Robot]

12 failures in 947 pushes (0.013 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 6
* mozilla-inbound: 4
* mozilla-central: 1
* mozilla-beta: 1

Platform breakdown:
* windows7-32: 6
* windows7-32-stylo-disabled: 2
* windows10-64: 2
* windows10-64-stylo-disabled: 1
* windows10-64-devedition: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-10-09&endday=2017-10-15&tree=all

Comment 6

[Intermittent Failures Robot]

5 failures in 864 pushes (0.006 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 2
* try: 1
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* windows7-32-stylo-disabled: 2
* windows7-32: 1
* windows10-64-stylo-disabled: 1
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-10-16&endday=2017-10-22&tree=all

Comment 7

[Intermittent Failures Robot]

5 failures in 912 pushes (0.005 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 4
* mozilla-inbound: 1

Platform breakdown:
* windows7-32: 4
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-10-23&endday=2017-10-29&tree=all

Comment 8

[Eliza Balazs [:ebalazs_]]

In the last 7 days, there have been 33 failures.

The failures occur on Windows 7, Windows 7-32 (disabled and nightly) and Windows 10-64 (enabled and disabled).
The build types affected are pgo, opt and debug. 

Log example: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=142195610&lineNumber=4412

And a relevant part of the log were the test failed:

23:29:28     INFO -  1860 INFO TEST-START | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_webNavigation_onCreatedNavigationTarget_window_open.js
5933
23:29:29     INFO -  Not taking screenshot here: see the one that was previously logged
5934
23:29:29     INFO -  Buffered messages logged at 23:29:28
5935
23:29:29     INFO -  1861 INFO Entering test bound test_window_open
5936
23:29:29     INFO -  Buffered messages finished
5937
23:29:29    ERROR -  1862 INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_webNavigation_onCreatedNavigationTarget_window_open.js | Uncaught exception - [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.createUnique]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://testing-common/ExtensionTestCommon.jsm :: generateZipFile :: line 271"  data: no]
5938
23:29:29     INFO -  Stack trace:
5939
23:29:29     INFO -      generateZipFile@resource://testing-common/ExtensionTestCommon.jsm:271:5
5940
23:29:29     INFO -      generateXPI@resource://testing-common/ExtensionTestCommon.jsm:263:12
5941
23:29:29     INFO -      generate@resource://testing-common/ExtensionTestCommon.jsm:357:16
5942
23:29:29     INFO -      generate@resource://gre/modules/Extension.jsm:1148:12
5943
23:29:29     INFO -      _receiveMessageAPI@chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:579:25
5944
23:29:29     INFO -      ChromePowers.prototype._receiveMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:83:14
5945
23:29:29     INFO -      ChromePowers.prototype._sendAsyncMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:45:3
5946
23:29:29     INFO -      loadExtension@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:2037:5
5947
23:29:29     INFO -      ExtensionTestUtils.loadExtension@chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:105:19
5948
23:29:29     INFO -      test_window_open@chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_webNavigation_onCreatedNavigationTarget_window_open.js:47:21
5949
23:29:29     INFO -      Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:806:21
5950
23:29:29     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:797:9
5951
23:29:29     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
5952
23:29:29     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
5953
23:29:29     INFO -  1863 INFO Leaving test bound test_window_open
5954
23:29:29     INFO -  1864 INFO Entering test bound test_window_open_close_from_browserAction_popup
5955
23:29:29     INFO -  Not taking screenshot here: see the one that was previously logged
5956
23:29:29    ERROR -  1865 INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_webNavigation_onCreatedNavigationTarget_window_open.js | Uncaught exception - [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.createUnique]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://testing-common/ExtensionTestCommon.jsm :: generateZipFile :: line 271"  data: no]
5957
23:29:29     INFO -  Stack trace:
5958
23:29:29     INFO -      generateZipFile@resource://testing-common/ExtensionTestCommon.jsm:271:5
5959
23:29:29     INFO -      generateXPI@resource://testing-common/ExtensionTestCommon.jsm:263:12
5960
23:29:29     INFO -      generate@resource://testing-common/ExtensionTestCommon.jsm:357:16
5961
23:29:29     INFO -      generate@resource://gre/modules/Extension.jsm:1148:12
5962
23:29:29     INFO -      _receiveMessageAPI@chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:579:25
5963
23:29:29     INFO -      ChromePowers.prototype._receiveMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:83:14
5964
23:29:29     INFO -      ChromePowers.prototype._sendAsyncMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:45:3
5965
23:29:29     INFO -      loadExtension@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:2037:5
5966
23:29:29     INFO -      ExtensionTestUtils.loadExtension@chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:105:19
5967
23:29:29     INFO -      test_window_open_close_from_browserAction_popup@chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_webNavigation_onCreatedNavigationTarget_window_open.js:110:21
5968
23:29:29     INFO -      Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:806:21
5969
23:29:29     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:797:9
5970
23:29:29     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
5971
23:29:29     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
5972
23:29:29     INFO -  1866 INFO Leaving test bound test_window_open_close_from_browserAction_popup
5973
23:29:29     INFO -  GECKO(4952) | MEMORY STAT | vsize 989MB | vsizeMaxContiguous 515MB | residentFast 376MB | heapAllocated 118MB
5974
23:29:29     INFO -  1867 INFO TEST-OK | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_webNavigation_onCreatedNavigationTarget_window_open.js | took 646ms
5975
23:29:29     INFO -  Not taking screenshot here: see the one that was previously logged
5976
23:29:29    ERROR -  1868 INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_webNavigation_onCreatedNavigationTarget_window_open.js | Found an unexpected tab at the end of test run: http://mochi.test:8888/browser/browser/components/extensions/test/browser/webNav_createdTargetSource.html -
5977
23:29:29     INFO -  Not taking screenshot here: see the one that was previously logged
5978
23:29:29    ERROR -  1869 INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_webNavigation_onCreatedNavigationTarget_window_open.js | Found an unexpected tab at the end of test run: http://mochi.test:8888/browser/browser/components/extensions/test/browser/webNav_createdTargetSource.html -
5979
23:29:29     INFO -  1870 INFO checking window state

:andym, I see that you are the triage owner, can you help find someone to look into this test?

Comment 9

[Intermittent Failures Robot]

36 failures in 857 pushes (0.042 failures/push) were associated with this bug in the last 7 days. 

This is the #48 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 15
* autoland: 14
* mozilla-central: 6
* try: 1

Platform breakdown:
* windows7-32: 18
* windows10-64: 8
* windows10-64-stylo-disabled: 6
* windows7-32-stylo-disabled: 3
* windows7-32-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-10-30&endday=2017-11-05&tree=all

Comment 10

[Bob Silverberg [:bsilverberg]]

I will try to take a look at this one as well.

Comment 11

[Intermittent Failures Robot]

50 failures in 849 pushes (0.059 failures/push) were associated with this bug in the last 7 days. 

This is the #35 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 23
* autoland: 20
* mozilla-central: 6
* try: 1

Platform breakdown:
* windows7-32: 20
* windows10-64: 20
* windows10-64-stylo-disabled: 6
* windows7-32-stylo-disabled: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-11-06&endday=2017-11-12&tree=all

Comment 12

[Tiberius Oros[:tiberius_oros]]

In the last week there have been 49 failures.
The failures occur on windows 7 and windows10-64 plaforms.
Affected build types: opt and pgo.

Since November 12th, the number of failures seems to be decreasing.

Here is a recent log file with the failure: 
https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=144408050

and relevant snippet from it:

21:20:46     INFO -  788 INFO Entering test bound testMatchDataURI
3755
21:20:46     INFO -  Buffered messages finished
3756
21:20:46    ERROR -  789 INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js | Uncaught exception - [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.createUnique]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://testing-common/ExtensionTestCommon.jsm :: generateZipFile :: line 269"  data: no]
3757
21:20:46     INFO -  Stack trace:
3758
21:20:46     INFO -      generateZipFile@resource://testing-common/ExtensionTestCommon.jsm:269:5
3759
21:20:46     INFO -      generateXPI@resource://testing-common/ExtensionTestCommon.jsm:261:12
3760
21:20:46     INFO -      generate@resource://testing-common/ExtensionTestCommon.jsm:355:16
3761
21:20:46     INFO -      generate@resource://gre/modules/Extension.jsm:1141:12
3762
21:20:46     INFO -      _receiveMessageAPI@chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:579:25
3763
21:20:46     INFO -      ChromePowers.prototype._receiveMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:83:14
3764
21:20:46     INFO -      ChromePowers.prototype._sendAsyncMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:45:3
3765
21:20:46     INFO -      loadExtension@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:2037:5
3766
21:20:46     INFO -      ExtensionTestUtils.loadExtension@chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:105:19
3767
21:20:46     INFO -      testMatchDataURI@chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js:212:18
3768
21:20:46     INFO -      Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1065:21
3769
21:20:46     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:1056:9
3770
21:20:46     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:956:9
3771
21:20:46     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
3772
21:20:46     INFO -  790 INFO Leaving test bound testMatchDataURI

Comment 13

[Bob Silverberg [:bsilverberg]]

I took a look at this but I'm not sure exactly what's causing the problem nor what a fix would be.

The error is coming from the call to file.createUnique [1] in generateZipFile in ExtensionTestCommon.jsm, with the error message "NS_ERROR_FILE_ACCESS_DENIED".

I was able to reproduce the failure on my Windows VM via —verify, with the failure occurring at different points in the suite of tests on different runs. I’m wondering if the content script that is being attempted in the default tab, which is meant to fail, isn’t running/completing before the test ends and therefore is somehow preventing the zip file from being removed.

To test that theory I added a sleep of 1000ms immediately before the call to `await extension.unload();` in testHasNoPermission, and after doing so I was unable to reproduce the failure on Windows. 

Kris, if this is in fact what is causing the failure, what can we do about it?

[1] https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionTestCommon.jsm#269

Comment 14

[Intermittent Failures Robot]

28 failures in 762 pushes (0.037 failures/push) were associated with this bug in the last 7 days. 

This is the #46 most frequent failure this week.   

Repository breakdown:
* autoland: 11
* mozilla-inbound: 7
* mozilla-central: 7
* mozilla-beta: 2
* try: 1

Platform breakdown:
* windows10-64: 14
* windows7-32: 6
* windows10-64-stylo-disabled: 4
* windows7-32-stylo-disabled: 2
* windows7-32-nightly: 1
* windows10-64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-11-13&endday=2017-11-19&tree=all

Comment 15

[Tiberius Oros[:tiberius_oros]]

39 Total failures in the last week.
 
Occurrences per platform:
 - 21 windows10-64
 - 17 Windows 7
 -  1 windows7-32-stylo-disabled
 
Occurrences per build type:
 - 19 pgo 
 - 15 opt
 -  5 debug
 
  
Here is a relevant recent log: 
https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=146952409

and a relevant snippet from it:

23:15:09     INFO -  1278 INFO Console message: Ignoring response to aborted listener for 549755813925
3956
23:15:09     INFO -  1279 INFO Console message: Cannot send function call result: other side closed connection (call data: ({path:"tabs.executeScript", args:[null, {allFrames:null, code:null, cssOrigin:null, file:"script.js", frameId:null, matchAboutBlank:null, runAt:"document_idle"}]}))
3957
23:15:09     INFO -  1280 INFO Test active tab, commands, no key press
3958
23:15:09     INFO -  Buffered messages finished
3959
23:15:09    ERROR -  1281 INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js | Uncaught exception - [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.createUnique]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://testing-common/ExtensionTestCommon.jsm :: generateZipFile :: line 269"  data: no]
3960
23:15:09     INFO -  Stack trace:
3961
23:15:09     INFO -      generateZipFile@resource://testing-common/ExtensionTestCommon.jsm:269:5
3962
23:15:09     INFO -      generateXPI@resource://testing-common/ExtensionTestCommon.jsm:261:12
3963
23:15:09     INFO -      generate@resource://testing-common/ExtensionTestCommon.jsm:355:16
3964
23:15:09     INFO -      generate@resource://gre/modules/Extension.jsm:1141:12
3965
23:15:09     INFO -      _receiveMessageAPI@chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:579:25
3966
23:15:09     INFO -      ChromePowers.prototype._receiveMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:83:14
3967
23:15:09     INFO -      ChromePowers.prototype._sendAsyncMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:45:3
3968
23:15:09     INFO -      loadExtension@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:2037:5
3969
23:15:09     INFO -      ExtensionTestUtils.loadExtension@chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:105:19
3970
23:15:09     INFO -      testHasNoPermission@chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js:47:19
3971
23:15:09     INFO -      async*testBadPermissions@chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js:168:9
3972
23:15:09     INFO -      Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1065:21
3973
23:15:09     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:1056:9
3974
23:15:09     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:956:9
3975
23:15:09     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
3976
23:15:09     INFO -  1282 INFO Leaving test bound testBadPermissions

:kmag, could you please have a look?

Comment 16

[Intermittent Failures Robot]

40 failures in 744 pushes (0.054 failures/push) were associated with this bug in the last 7 days. 

This is the #26 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 17
* autoland: 17
* mozilla-central: 4
* mozilla-beta: 2

Platform breakdown:
* windows10-64: 23
* windows7-32: 15
* windows7-32-stylo-disabled: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-11-20&endday=2017-11-26&tree=all

Comment 17

[Intermittent Failures Robot]

20 failures in 792 pushes (0.025 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 10
* mozilla-inbound: 6
* mozilla-central: 4

Platform breakdown:
* windows10-64: 11
* windows7-32: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-11-27&endday=2017-12-03&tree=all

Comment 18

[Intermittent Failures Robot]

24 failures in 889 pushes (0.027 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 14
* autoland: 9
* mozilla-beta: 1

Platform breakdown:
* windows10-64: 14
* windows7-32: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-12-04&endday=2017-12-10&tree=all

Comment 19

[Intermittent Failures Robot]

5 failures in 423 pushes (0.012 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 4
* mozilla-inbound: 1

Platform breakdown:
* windows7-32: 3
* windows10-64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-12-11&endday=2017-12-17&tree=all

Comment 20

[Intermittent Failures Robot]

3 failures in 590 pushes (0.005 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1
* mozilla-central: 1
* autoland: 1

Platform breakdown:
* windows10-64: 2
* windows10-64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-12-18&endday=2017-12-24&tree=all

Comment 21

[Intermittent Failures Robot]

4 failures in 147 pushes (0.027 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 2
* mozilla-inbound: 1
* autoland: 1

Platform breakdown:
* windows7-32: 2
* windows10-64-nightly: 1
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2017-12-25&endday=2017-12-31&tree=all

Comment 23

[Intermittent Failures Robot]

15 failures in 462 pushes (0.032 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 6
* mozilla-central: 5
* autoland: 4

Platform breakdown:
* windows10-64: 8
* windows7-32: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-01-01&endday=2018-01-07&tree=all

Comment 24

[Tiberius Oros[:tiberius_oros]]

34 Total failures in the last week.
 
Occurrences per platform:
 - 19 windows10-64
 - 15 Windows 7

Occurrences per build type:
 - 16 pgo 
 - 12 opt
 -  6 debug

Here is a recent log file and a snippet from it: 
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=155781410

00:00:14     INFO -  758 INFO Leaving test bound testBadPermissions
3939
00:00:14     INFO -  759 INFO Entering test bound testMatchDataURI
3940
00:00:14     INFO -  Buffered messages finished
3941
00:00:14    ERROR -  760 INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_executeScript_bad.js | Uncaught exception - [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.createUnique]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://testing-common/ExtensionTestCommon.jsm :: generateZipFile :: line 271"  data: no]
3942
00:00:14     INFO -  Stack trace:
3943
00:00:14     INFO -      generateZipFile@resource://testing-common/ExtensionTestCommon.jsm:271:5
3944
00:00:14     INFO -      generateXPI@resource://testing-common/ExtensionTestCommon.jsm:263:12
3945
00:00:14     INFO -      generate@resource://testing-common/ExtensionTestCommon.jsm:357:16
3946
00:00:14     INFO -      _receiveMessageAPI@chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:583:25
3947
00:00:14     INFO -      ChromePowers.prototype._receiveMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:83:14
3948
00:00:14     INFO -      ChromePowers.prototype._sendAsyncMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:45:3
3949
00:00:14     INFO -      loadExtension@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:2039:5
3950
00:00:14     INFO -      ExtensionTestUtils.loadExtension@chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:105:19
3951
00:00:14     INFO -      testMatchDataURI@chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_executeScript_bad.js:212:18
3952
00:00:14     INFO -      Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1065:21
3953
00:00:14     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:1056:9
3954
00:00:14     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:956:9
3955
00:00:14     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
3956
00:00:14     INFO -  761 INFO Leaving test bound testMatchDataURI


:kmag, any updates on this?

Comment 25

[Intermittent Failures Robot]

37 failures in 788 pushes (0.047 failures/push) were associated with this bug in the last 7 days. 

This is the #44 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 21
* mozilla-inbound: 8
* mozilla-central: 4
* try: 3
* mozilla-beta: 1

Platform breakdown:
* windows10-64: 20
* windows7-32: 16
* windows10-64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-01-08&endday=2018-01-14&tree=all

Comment 26

[Intermittent Failures Robot]

27 failures in 657 pushes (0.041 failures/push) were associated with this bug in the last 7 days. 

This is the #37 most frequent failure this week.   

Repository breakdown:
* autoland: 13
* mozilla-inbound: 8
* mozilla-central: 4
* oak: 2

Platform breakdown:
* windows10-64: 14
* windows7-32: 13

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-01-15&endday=2018-01-21&tree=all

Comment 27

[Intermittent Failures Robot]

22 failures in 701 pushes (0.031 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 12
* mozilla-inbound: 7
* mozilla-central: 2
* mozilla-release: 1

Platform breakdown:
* windows7-32: 11
* windows10-64: 10
* windows10-64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-01-22&endday=2018-01-28&tree=all

Comment 28

[Intermittent Failures Robot]

19 failures in 735 pushes (0.026 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 9
* mozilla-inbound: 6
* mozilla-central: 3
* mozilla-beta: 1

Platform breakdown:
* windows7-32: 15
* windows10-64: 3
* windows10-64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-01-29&endday=2018-02-04&tree=all

Comment 29

[Intermittent Failures Robot]

12 failures in 702 pushes (0.017 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 6
* mozilla-inbound: 4
* mozilla-central: 1
* mozilla-beta: 1

Platform breakdown:
* windows7-32: 7
* windows10-64: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-02-05&endday=2018-02-11&tree=all

Comment 30

[Intermittent Failures Robot]

7 failures in 685 pushes (0.01 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 3
* mozilla-central: 2
* mozilla-inbound: 1
* mozilla-beta: 1

Platform breakdown:
* windows10-64: 4
* windows7-32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-02-12&endday=2018-02-18&tree=all

Comment 31

[Intermittent Failures Robot]

23 failures in 675 pushes (0.034 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 14
* mozilla-inbound: 5
* mozilla-central: 3
* try: 1

Platform breakdown:
* windows10-64: 12
* windows7-32: 11

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-02-19&endday=2018-02-25&tree=all

Comment 32

[Intermittent Failures Robot]

23 failures in 831 pushes (0.028 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 12
* mozilla-inbound: 6
* mozilla-central: 3
* try: 2

Platform breakdown:
* windows7-32: 11
* windows10-64: 11
* windows7-32-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-02-26&endday=2018-03-04&tree=all

Comment 33

[Intermittent Failures Robot]

21 failures in 747 pushes (0.028 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 11
* try: 3
* mozilla-central: 3
* mozilla-release: 2
* mozilla-inbound: 2

Platform breakdown:
* windows10-64: 9
* windows7-32: 7
* windows10-64-nightly: 3
* linux64-stylo-disabled: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-03-05&endday=2018-03-11&tree=all

Comment 34

[Intermittent Failures Robot]

12 failures in 814 pushes (0.015 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 5
* mozilla-central: 3
* try: 2
* mozilla-inbound: 2

Platform breakdown:
* windows10-64: 7
* windows7-32: 3
* windows7-32-nightly: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1399348&startday=2018-03-12&endday=2018-03-18&tree=all

Comment 35

[Intermittent Failures Robot]

5 failures in 822 pushes (0.006 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 3
* mozilla-inbound: 1
* autoland: 1

Platform breakdown:
* windows10-64: 4
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1399348&startday=2018-03-20&endday=2018-03-26&tree=trunk

Comment 36

[Intermittent Failures Robot]

5 failures in 718 pushes (0.007 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 2
* try: 1
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* windows10-64: 3
* windows7-32: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1399348&startday=2018-03-26&endday=2018-04-01&tree=trunk

Comment 37

[Intermittent Failures Robot]

15 failures in 765 pushes (0.02 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 7
* autoland: 6
* try: 2

Platform breakdown:
* windows7-32: 9
* windows10-64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1399348&startday=2018-04-02&endday=2018-04-08&tree=trunk

Comment 38

[Intermittent Failures Robot]

6 failures in 792 pushes (0.008 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 4
* mozilla-inbound: 2

Platform breakdown:
* windows10-64: 5
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1399348&startday=2018-04-09&endday=2018-04-15&tree=trunk

Comment 39

[Intermittent Failures Robot]

4 failures in 782 pushes (0.005 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 2
* try: 1
* mozilla-inbound: 1

Platform breakdown:
* windows7-32: 3
* windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1399348&startday=2018-04-16&endday=2018-04-22&tree=trunk

Comment 40

[Rob Wu [:robwu]]

Attachment: Bug 1399348 - Explicitly wait and check for error in test browser_ext_tabs_executeScript_bad

I think that the intermittent error in the bug may be caused by
a pending executeScript call that is somehow handled around the
shutdown of the extension.

To verify this hypothesis, the test now explicitly waits for the
result of the first executeScript call before executing the last
script that is responsible for test completion.

The test should explicitly be checking for the error anyway.

Review commit: https://reviewboard.mozilla.org/r/238972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238972/

Comment 41

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8970163 [details]
Bug 1399348 - Explicitly wait and check for error in test browser_ext_tabs_executeScript_bad

https://reviewboard.mozilla.org/r/238972/#review245182

::: browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js:20
(Diff revision 1)
> -        // Execute a script we know we have permissions for in the
> +      // Execute a script we know we have permissions for in the
> -        // second tab, in the hopes that it will execute after the
> +      // second tab, in the hopes that it will execute after the
> -        // first one. This has intermittent failure written all over
> +      // first one.
> -        // it, but it's just about the best we can do until we
> -        // support callbacks for executeScript.
> -        browser.tabs.executeScript(tabs[1].id, {
> +      browser.tabs.executeScript(tabs[1].id, {
> -          file: "second-script.js",
> +        file: "second-script.js",
> -        });
> +      });

It looks that this second browser.tabs.executeScript was a workaround needed because tabs.executeScript wasn't rejecting (or setting the runtime.lastError property) on failures yet when this test has been created.

can we remove it now?

::: mobile/android/components/extensions/test/mochitest/test_ext_tabs_executeScript_bad.html:36
(Diff revision 1)
> -        browser.tabs.executeScript(tabs[1].id, {
> +      browser.tabs.executeScript(tabs[1].id, {
> -          file: "second-script.js",
> +        file: "second-script.js",
> -        });
> +      });

Same question as the one on the test for Firefox Desktop.

Comment 42

[Rob Wu [:robwu]]

Assigning to me since I attached a patch.

The patch improves the test (makes it more deterministic), but I don't know whether the intermittent will be fixed by it.

Comment 43

[Rob Wu [:robwu]]

Comment on attachment 8970163 [details]
Bug 1399348 - Explicitly wait and check for error in test browser_ext_tabs_executeScript_bad

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238972/diff/1-2/

Comment 44

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8970163 [details]
Bug 1399348 - Explicitly wait and check for error in test browser_ext_tabs_executeScript_bad

https://reviewboard.mozilla.org/r/238972/#review245380

Thanks Rob, getting rid of the "PromiseTestUtils.whitelistRejectionsGlobally" (introduced by Bug 1242505) in favor of "catching the rejection of the (expected) invalid tabs.executeScript" sounds good to me.

As briefly discussed over IRC, as long as we have a filed issue related to remove the second tabs.executeScript call (that was previously used as a workaround for the missing callback/returned promise support in tabs.executeScript), I'm ok with this change in the meantime, and see if it was enough to fix the remaining intermittency of this test.

r+ on green try 
(well, "green as much as it was before" ;-), given that this test was still already failing intermittently, even if less often after we landed the fix from Bug 1435100).

::: browser/components/extensions/test/browser/browser_ext_tabs_executeScript_bad.js:342
(Diff revision 2)
>  // TODO: Test that |executeScript| fails if the tab has navigated to a
>  // new page, and no longer matches our expected state. This involves
> -// intentionally trying to trigger a race condition, and is probably not
> +// intentionally trying to trigger a race condition.

This TODO sounds a lot like a test for a scenario pretty similar to the one described by Bug 1452045.

I think that it could be worth to mention that bug number on this TODO (and maybe comment in that bugzilla issue that once we fix and write a test for Bug 1452045, we can remove this TODO).

Comment 45

[Rob Wu [:robwu]]

Comment on attachment 8970163 [details]
Bug 1399348 - Explicitly wait and check for error in test browser_ext_tabs_executeScript_bad

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238972/diff/2-3/

Comment 46

[Rob Wu [:robwu]]

Adding leave-open so that we know whether the intermittents are really solved.

The separately filed bug 1457115 will remind me of this bug, so if the intermittents are solved I will close this bug by then.

Comment 47

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd9ba54d497c
Explicitly wait and check for error in test browser_ext_tabs_executeScript_bad r=rpl

Comment 48

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dd9ba54d497c

Comment 49

[Intermittent Failures Robot]

3 failures in 780 pushes (0.004 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 2
* mozilla-beta: 1

Platform breakdown:
* windows10-64: 2
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1399348&startday=2018-04-23&endday=2018-04-29&tree=trunk

Comment 50

[Rob Wu [:robwu]]

The intermittents disappeared completely, which confirms my suspicion that something was wrong with resource locking and dynamic scripts.

I filed bug 1463489 with the findings of the investigation.

Now I have obtained the results, the test can be simplified further (bug 1457115).

Comment 51

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/0c8f4c1d5c05

Comment 52

[Intermittent Failures Robot]

1 failures in 760 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-beta: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1399348&startday=2018-07-23&endday=2018-07-29&tree=trunk