1399398 - Turn on the Storage Management feature

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Comment 1

[Fischer [:Fischer]]

Attachment: Bug 1399398 - Turn on the Storage Management feature,

Review commit: https://reviewboard.mozilla.org/r/179198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179198/

Comment 2

[Fischer [:Fischer]]

Attachment: signedOff.pdf

Comment 3

[Fischer [:Fischer]]

Attachment: new_storage_API.pdf

Comment 4

[Fischer [:Fischer]]

Comment on attachment 8907497 [details]
Bug 1399398 - Turn on the Storage Management feature,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/179198/diff/1-2/

Comment 5

[Fischer [:Fischer]]

(In reply to Fischer [:Fischer] from comment #4)
> Comment on attachment 8907497 [details]
> Bug 1399398 - Turn on the Storage Management feature,
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/179198/diff/1-2/
Hi Gijs and Jared,
Please see [1][2] for the related reports.
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=38625bc1fd91

p.s The DOM side enabling is on the bug 1399038.

[1] attachment 8907557 [details]: signedOff.pdf
[2] attachment 8907559 [details]: new_storage_API.pdf

Thanks

Comment 6

[:Gijs (out for now; he/him)]

Comment on attachment 8907497 [details]
Bug 1399398 - Turn on the Storage Management feature,

https://reviewboard.mozilla.org/r/179198/#review184944

::: browser/app/profile/firefox.js:717
(Diff revision 2)
> -// Once the Storage Management is completed.
> +// The Storage Management is completed so
> +// the task to clear and collect appcache will be done by Storage Management
>  // (The Storage Management-related prefs are browser.storageManager.* )
> -// The Offline(Appcache) Group section in about:preferences will be hidden.
> +// The Offline(Appcache) Group section in about:preferences should be hidden.

Please rewrite this comment to:

```js
// We prefer the storage manager (see browser.storageManager.enabled)
// over the old offlineGroup UI. Removing the offline group UI is
// bug <...>.
```

and file a followup bug to remove the offline group UI.

Comment 7

[Fischer [:Fischer]]

Comment on attachment 8907497 [details]
Bug 1399398 - Turn on the Storage Management feature,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/179198/diff/2-3/

Comment 8

[Fischer [:Fischer]]

Comment on attachment 8907497 [details]
Bug 1399398 - Turn on the Storage Management feature,

https://reviewboard.mozilla.org/r/179198/#review184944

> Please rewrite this comment to:
> 
> ```js
> // We prefer the storage manager (see browser.storageManager.enabled)
> // over the old offlineGroup UI. Removing the offline group UI is
> // bug <...>.
> ```
> 
> and file a followup bug to remove the offline group UI.

OK, updated

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94db30cdece1
Turn on the Storage Management feature, r=Gijs

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/94db30cdece1