Closed Bug 1399398 Opened 7 years ago Closed 7 years ago

Turn on the Storage Management feature

Categories

(Firefox :: Settings UI, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: Fischer, Assigned: Fischer)

References

Details

(Whiteboard: [storage-v1])

Attachments

(3 files)

      No description provided.
Assignee: nobody → fliu
Status: NEW → ASSIGNED
Whiteboard: [storage-v1]
Attached file signedOff.pdf
Attached file new_storage_API.pdf
See Also: → 1399038
(In reply to Fischer [:Fischer] from comment #4)
> Comment on attachment 8907497 [details]
> Bug 1399398 - Turn on the Storage Management feature,
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/179198/diff/1-2/
Hi Gijs and Jared,
Please see [1][2] for the related reports.
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=38625bc1fd91

p.s The DOM side enabling is on the bug 1399038.

[1] attachment 8907557 [details]: signedOff.pdf
[2] attachment 8907559 [details]: new_storage_API.pdf

Thanks
Comment on attachment 8907497 [details]
Bug 1399398 - Turn on the Storage Management feature,

https://reviewboard.mozilla.org/r/179198/#review184944

::: browser/app/profile/firefox.js:717
(Diff revision 2)
> -// Once the Storage Management is completed.
> +// The Storage Management is completed so
> +// the task to clear and collect appcache will be done by Storage Management
>  // (The Storage Management-related prefs are browser.storageManager.* )
> -// The Offline(Appcache) Group section in about:preferences will be hidden.
> +// The Offline(Appcache) Group section in about:preferences should be hidden.

Please rewrite this comment to:

```js
// We prefer the storage manager (see browser.storageManager.enabled)
// over the old offlineGroup UI. Removing the offline group UI is
// bug <...>.
```

and file a followup bug to remove the offline group UI.
Attachment #8907497 - Flags: review?(gijskruitbosch+bugs) → review+
Blocks: 1399808
Comment on attachment 8907497 [details]
Bug 1399398 - Turn on the Storage Management feature,

https://reviewboard.mozilla.org/r/179198/#review184944

> Please rewrite this comment to:
> 
> ```js
> // We prefer the storage manager (see browser.storageManager.enabled)
> // over the old offlineGroup UI. Removing the offline group UI is
> // bug <...>.
> ```
> 
> and file a followup bug to remove the offline group UI.

OK, updated
Keywords: checkin-needed
Pushed by shuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94db30cdece1
Turn on the Storage Management feature, r=Gijs
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/94db30cdece1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.