139943 - Command line CSS-checking tool

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I hacked up a little command line CSS-checking tool so that I could do a
CSS-check on all the CSS files in the tree with a little 'find' magic.

I'd like to get this checked in so I don't lose it.  I'll probably need someone
to run it over the commercial tree before I land bug 3935.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And, FWIW, I ran this over all CSS files in the tree except for some stuff in
layout/html/tests/css/ (I think that's where it was), and filed bug 139942 with
the resulting errors.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

For the record, to run it, I executed (roughly -- I saved the find results in a
file and 'cat'-ed them, actually) the following *one* line in bash:

find /builds/.../mozilla/ -name "*.css" | while read FNAME; do ./run-mozilla.sh
./ParseCSS $FNAME >> csserrors; done

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: the |#ifdef|s that need to be changed to use this

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I changed the XXX comment in attachment 80899 [details] [diff] [review] to refer to bug 74709.

Comment 6

[Marc Attinasi]

Looks fine: 

in FileToURI
+    CallCreateInstance(kStandardURLCID, &url);
you might want to check |url| against null, and also check for a null uri in
this bit:
+        nsCOMPtr<nsIURI> uri = FileToURI(filename);
+        ParseCSSFile(uri);

Comment 7

[Chris Waterson]

Comment on attachment 80899 [details] [diff] [review]
patch

sr=waterson

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch with null checks

Comment 9

[Chris Waterson]

Comment on attachment 81741 [details] [diff] [review]
patch with null checks

sr=waterson

Comment 10

[Marc Attinasi]

Comment on attachment 81741 [details] [diff] [review]
patch with null checks

r=attinasi

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 81741 [details] [diff] [review]
patch with null checks

a=[e-mail] for branch (and trunk) checkin

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk 2002-04-30 17:03 PDT.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked into 1.0 branch, 2002-04-30 19:54 PDT.

Comment 14

[Asa Dotzler [:asa]]

adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.

Comment 15

[Madhur Bhatia]

David,
Could you please verify this on branch and change the keyword from fixed1.0.0 to
verifed1.0.0

Thanks !!

Comment 16

[Madhur Bhatia]

as per David's comments in comment # 13,  am marking ths bug with keyword 
verified1.0.0