This is a bug for the CSS errors in the chrome that have crept in since bug
71637 was fixed. The patch I'm about to attach includes all the errors on the
1.0 branch except for those in messageBody.css, which is covered by bug .
I haven't tested this at all, and I don't think it should be checked in as-is.
But I certainly think it's an interesting demonstration of how little some of
the CSS in the tree has been tested.
Created attachment 80900 [details] [diff] [review]
patch fixing CSS errors in chrome
This is a patch against the 1.0 branch.
The bug on messageBody.css is bug 130728.
I found this using the command-line tool I just wrote (see bug 139943).
Arguably, the incorrect lines should be removed, not fixed...
@@ -201,8 +201,8 @@
font-family: arial, helvetica, sans-serif;
- margin-top: 0;
- margin-bottom: 4;
+ margin-top: 0px;
+ margin-bottom: 4px;
"line-height: 1;" is a no-op, right? Remove it?
No, since 'line-height' is inherited. And there's a .7 in the previous rule,
which I expect it's overriding.
There's also a bad 'background-color' declaration in pref-viewing_messages.xul
that I should fix.
(Good point about the inheritance, which I hadn't considered. Although, looking
at the usage, it seems like the 'inthissection' and 'inthissections' are used
independently. But it's obviously not your job to fix every bit of redundant
css in the tree :-).
For reference, bug 65469 is the bug on CSS error reporting an bug 155855 is the
bug on turning on CSS error reporting in DEBUG builds only. (I intend to do the
localization sometime before trying to turn it on for release builds.)
Created attachment 90270 [details] [diff] [review]
similar patch against current trunk
*** Bug 158069 has been marked as a duplicate of this bug. ***
David: what do you want to do with this patch? Could we get simple stuff in at
least? Adding the correct @namespace rules for example would already fix some
errors and I think it's mostly clear that that was just an oversight.
Which ones? Adding some of those rules might break other things.
People need to look at the CSSERR parts of the patch. Let's try and get this
Created attachment 138226 [details]
I filed bugs on the appropriate components and attached patches. Hopefully the
owners will be able to determine if the patches are appropriate. I did not
include anything for layout/html/tests and was not able to fix all errors. The
remaining errors are mainly due to # pre-processor statements or vendor
specific properties I am not familiar with.
I think this has been fixed for a while; these don't creep in much anymore now that they show up on the console.