139942 - CSS errors in chrome

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a bug for the CSS errors in the chrome that have crept in since bug
71637 was fixed.  The patch I'm about to attach includes all the errors on the
1.0 branch except for those in messageBody.css, which is covered by bug .

I haven't tested this at all, and I don't think it should be checked in as-is. 
But I certainly think it's an interesting demonstration of how little some of
the CSS in the tree has been tested.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch fixing CSS errors in chrome

This is a patch against the 1.0 branch.

The bug on messageBody.css is bug 130728.

I found this using the command-line tool I just wrote (see bug 139943).

Comment 2

[Hixie (not reading bugmail)]

Arguably, the incorrect lines should be removed, not fixed...

Comment 3

[John Morrison]

@@ -201,8 +201,8 @@
     font-family: arial, helvetica, sans-serif; 
     font-size: 12px;
   line-height: 1;
-    margin-top: 0;
-    margin-bottom: 4;
+    margin-top: 0px;
+    margin-bottom: 4px;
   }

"line-height: 1;" is a no-op, right? Remove it?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No, since 'line-height' is inherited.  And there's a .7 in the previous rule,
which I expect it's overriding.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There's also a bad 'background-color' declaration in pref-viewing_messages.xul
that I should fix.

Comment 6

[John Morrison]

(Good point about the inheritance, which I hadn't considered. Although, looking 
at the usage, it seems like the 'inthissection' and 'inthissections' are used
independently. But it's obviously not your job to fix every bit of redundant
css in the tree :-).

Comment 7

[Madhur Bhatia]

cc'ing myself

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

For reference, bug 65469 is the bug on CSS error reporting an bug 155855 is the
bug on turning on CSS error reporting in DEBUG builds only.  (I intend to do the
localization sometime before trying to turn it on for release builds.)

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: similar patch against current trunk

Comment 10

[Jerry]

*** Bug 158069 has been marked as a duplicate of this bug. ***

Comment 11

[Peter Van der Beken [:peterv]]

David: what do you want to do with this patch? Could we get simple stuff in at
least? Adding the correct @namespace rules for example would already fix some
errors and I think it's mostly clear that that was just an oversight.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Which ones?  Adding some of those rules might break other things.

Comment 13

[Simon Fraser [no longer active]]

People need to look at the CSSERR parts of the patch. Let's try and get this
resolved.

Comment 14

[Bob Clary [:bc] (inactive)]

Attachment: remaining errors

I filed bugs on the appropriate components and attached patches. Hopefully the
owners will be able to determine if the patches are appropriate. I did not
include anything for layout/html/tests and was not able to fix all errors. The
remaining errors are mainly due to # pre-processor statements or vendor
specific properties I am not familiar with.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think this has been fixed for a while; these don't creep in much anymore now that they show up on the console.