Over the years Windows has internally referred to Settings as Options or Settings. This inconsistency has gradually resolved to Settings over Options and in Windows 10 consistently uses Settings. For consistency we should change Options to Settings and on Windows this should resolve to about:settings
2 months ago
I was trying to implement this, but it looks super hairy. We use "options" in a *lot* of places ( https://dxr.mozilla.org/mozilla-central/search?q=Options+file%3A.dtd&redirect=true and https://dxr.mozilla.org/mozilla-central/search?q=Options+file%3A.properties&redirect=false (that's 50-60 strings in total, minus comments plus change for access keys)). We would have to update all/most of those strings, and rev their ids, and change their access keys, and then potentially change other items' access keys (e.g. in the Tools menu, we want the "s" access key, so we need to change the 'sync now' access key). *** I don't know if this is realistically doable for 57, even without the URL change, also because of the mayhem it inflicts on localizers this close to the merge (which is *this week*). Can we please wontfix for 57? This was filed very late in the cycle, and isn't really all that related to the other structure changes we're making for 57, so I think it can wait a cycle. *** Yes, I realize we could in theory only update the items that refer to the "actual" full-on Firefox options, but that (a) introduces inconsistency, and (b) would still require auditing all those strings, updating them, getting that reviewed, landed, and then making localizers do the same thing.
(In reply to :Gijs from comment #1) > Can we please wontfix for 57? This was filed very late in the cycle, and > isn't really all that related to the other structure changes we're making > for 57, so I think it can wait a cycle. We *really* need to keep this out of 57. Changing strings all over the place means shipping mixed translations until all languages have caught up with the changes (unless we decide to fix only English). Doing it now, it means shipping several beta in poor state, and maybe even 57 release. There is very little to gain from making this change now.
Stephen replied on slack. Gonna wontfix for 57.
Side questions: * Should we start using "Settings" for new features and strings? * Does it mean that we're going to have 3 variants: Options (Linux), Settings (Windows), and Preferences (macOS)? That seems extremely hard to manage.
(In reply to Francesco Lodolo [:flod] from comment #4) > Side questions: > * Should we start using "Settings" for new features and strings? > * Does it mean that we're going to have 3 variants: Options (Linux) I think we use "Preferences" on Linux, certainly for the main prefs... what did I miss?
(In reply to :Gijs (no reviews; PTO recovery mode) from comment #5) > > * Does it mean that we're going to have 3 variants: Options (Linux) > > I think we use "Preferences" on Linux, certainly for the main prefs... what > did I miss? Clearly not enough coffee on my side. * Linux, macOS: Preferences * Windows: Options (changing to Settings) So there would still be 2 variants.
(In reply to Francesco Lodolo [:flod] from comment #6) > So there would still be 2 variants. Yep, we're just changing Windows. :-)