1399731 - Fix Developer Edition Branding DMG

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Stephen Horlander [:shorlander]]

Attachment: fix-developer-edition-dmg.patch

Developer Edition Disk Image doesn't have a background image and the icons are misaligned.

Comment 1

[Justin Dolske [:Dolske]]

(Note that this is an existing bug we noticed while updating the branding in bug 1399717 -- the currently shipping DevEdition DMG is broken!)

Comment 2

[Justin Dolske [:Dolske]]

Verified this fixes the DMG locally for me.

I think there must have been 2 separate bugs:

* The icon misalignment was caused because the .DSStore file (/browser/branding/aurora/dsstore) only referenced "Aurora.app", not "FirefoxDeveloperEdition.app". I caught basically the same problem when reviewing bug 1399691, because my build environment was creating "FirefoxDebug.app" (but worked fine when changing my mozconfig to generate a non-debug "Firefox.app"). This would imply the icon has probably _always_ been misaligned for DevEdition.

* Not sure why the background wasn't being shown, though. That was fine for me with the aforementioned "FirefoxDebug.app" issue. Running strings against the old dsstore file shows is seems to know about a background.png, but somehow it wasn't being picked up. In any case, this bug fixes it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/cb717386aec8
Fix Developer Edition Branding DMG. r=dolske, a=fixups for m-c

Comment 4

[Justin Dolske [:Dolske]]

Attachment: Screenshot, before (already-shipping Firefox DevEditon 56b11)

Comment 5

[Justin Dolske [:Dolske]]

Attachment: Screenshot, after

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

This regressed between DevEd 58.0b16 and 59.0b1, see bug 1455768.