Implement the photon styles for the inspector breadcrumbs

RESOLVED FIXED in Firefox 58

Status

P3
normal
RESOLVED FIXED
a year ago
7 months ago

People

(Reporter: gl, Assigned: hobindar)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
Firefox 58
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fix-optional, firefox58 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
Update the inspector breadcrumbs to look like the photon mockups.
status-firefox57: --- → fix-optional
(Reporter)

Updated

a year ago
Assignee: gl → nobody
Status: ASSIGNED → NEW
(Reporter)

Updated

a year ago
Assignee: nobody → darrenhobin
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 3

a year ago
mozreview-review
Comment on attachment 8911224 [details]
Bug 1399948 - Part 1: Refactor breadcrumb css into separate file.

https://reviewboard.mozilla.org/r/182714/#review188148
Attachment #8911224 - Flags: review?(gl) → review+
(Reporter)

Updated

a year ago
Keywords: leave-open

Comment 4

a year ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64a52ab3bab3
Part 1: Refactor breadcrumb css into separate file. r=gl
(Reporter)

Comment 6

a year ago
mozreview-review
Comment on attachment 8911436 [details]
Bug 1399948 - Part 2: Implement photon styles for breadcrumbs.

https://reviewboard.mozilla.org/r/182904/#review188156

Clearing the review on this since this requires more work.
Attachment #8911436 - Flags: review?(gl)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8911224 - Attachment is obsolete: true
(Reporter)

Updated

a year ago
Attachment #8911436 - Flags: review?(gl) → review?(bgrinstead)
(Reporter)

Comment 8

a year ago
Passing this review to bgrins since I am swamped for reviews. This bug is about implementing the photon styles for the breadcrumbs seen here - https://docs.google.com/document/d/1AJ7oHC7akXJiliheHjhFc4fTonaN31Eo_P2M8gssL8s/edit. We saw that the firebug breadcrumbs basically looked similar to what we were aiming for so. So, the task was to un-prefix the firebug theme breadcrumbs and remove the existing styles for the light/dark theme breadcrumbs.

Comment 9

a year ago
mozreview-review
Comment on attachment 8911436 [details]
Bug 1399948 - Part 2: Implement photon styles for breadcrumbs.

https://reviewboard.mozilla.org/r/182904/#review190634

This is great, thanks!
Attachment #8911436 - Flags: review?(bgrinstead) → review+
(Reporter)

Updated

a year ago
Keywords: leave-open
(Reporter)

Updated

a year ago
Status: NEW → ASSIGNED
(Reporter)

Updated

a year ago
Keywords: checkin-needed

Comment 10

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b8c11514db36
Part 2: Implement photon styles for breadcrumbs. r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b8c11514db36
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58

Updated

a year ago
Depends on: 1428917

Updated

7 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.