1399948 - Implement the photon styles for the inspector breadcrumbs

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Update the inspector breadcrumbs to look like the photon mockups.

Comment 1

[Darren Hobin [:hobindar]]

Attachment: Bug 1399948 - Part 1: Refactor breadcrumb css into separate file.

Review commit: https://reviewboard.mozilla.org/r/182714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182714/

Comment 2

[Darren Hobin [:hobindar]]

Attachment: Bug 1399948 - Part 2: Implement photon styles for breadcrumbs.

Review commit: https://reviewboard.mozilla.org/r/182904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182904/

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8911224 [details]
Bug 1399948 - Part 1: Refactor breadcrumb css into separate file.

https://reviewboard.mozilla.org/r/182714/#review188148

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64a52ab3bab3
Part 1: Refactor breadcrumb css into separate file. r=gl

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/64a52ab3bab3

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8911436 [details]
Bug 1399948 - Part 2: Implement photon styles for breadcrumbs.

https://reviewboard.mozilla.org/r/182904/#review188156

Clearing the review on this since this requires more work.

Comment 7

[Darren Hobin [:hobindar]]

Comment on attachment 8911436 [details]
Bug 1399948 - Part 2: Implement photon styles for breadcrumbs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182904/diff/1-2/

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Passing this review to bgrins since I am swamped for reviews. This bug is about implementing the photon styles for the breadcrumbs seen here - https://docs.google.com/document/d/1AJ7oHC7akXJiliheHjhFc4fTonaN31Eo_P2M8gssL8s/edit. We saw that the firebug breadcrumbs basically looked similar to what we were aiming for so. So, the task was to un-prefix the firebug theme breadcrumbs and remove the existing styles for the light/dark theme breadcrumbs.

Comment 9

[Brian Grinstead [:bgrins]]

Comment on attachment 8911436 [details]
Bug 1399948 - Part 2: Implement photon styles for breadcrumbs.

https://reviewboard.mozilla.org/r/182904/#review190634

This is great, thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8c11514db36
Part 2: Implement photon styles for breadcrumbs. r=bgrins

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b8c11514db36