1400175 - plugin-container crashes when linked with BIND_NOW

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jan Alexander Steffens [:heftig]]

Attachment: plugin-crash.diff

libxul.so requires the symbol gdk_screen_get_monitor_workarea but this symbol is not available in gtk2 and mozgtk does not provide a stub.

For the official builds, this is not a problem as the code using this function never gets called so the linker never looks it up.

Our (Arch Linux) builds have -z now in our LD flags, so the linker resolves all symbols at load time. The plugin-container crashes as it cannot bind gdk_screen_get_monitor_workarea.

The attached patch solves the problem by having mozgtk2 provide a stub. It also replaces the call when building against GTK2, but that's not needed (it should be sane but I didn't test a cairo-gtk2 build, anyway) so you can ignore that hunk.

Comment 1

[Jan Alexander Steffens [:heftig]]

Attachment: Bug 1400175 - Stub gdk_screen_get_monitor_workarea in mozgtk2;

Review commit: https://reviewboard.mozilla.org/r/180248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180248/

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8908585 [details]
Bug 1400175 - Stub gdk_screen_get_monitor_workarea in mozgtk2;

https://reviewboard.mozilla.org/r/180248/#review185846

Thank you!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e46b61728739
Stub gdk_screen_get_monitor_workarea in mozgtk2; r=karlt

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e46b61728739