1400337 - throbber should have two states, gray for connecting and blue for transferring data

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Asa Dotzler [:asa]]

For several days I've only seen the gray throbber. It used to have two states, gray for connecting and blue for transferring data. Now it only shows gray. Tested Windows nightly builds on Win 10.

Comment 1

[Dave Townsend [:mossop]]

Mozregression says that bug 1380150 broke this.

Comment 2

[:Gijs (he/him)]

The issue is that the progress change listener never seems to get passed either request or webprogress objects, whatever its arguments/contracts might be pretending. As a result, we now no longer ever set the 'progress' flag:

https://dxr.mozilla.org/mozilla-central/rev/6be5c7d30d2def62a762ac187252eba626b23a92/browser/base/content/tabbrowser.xml#672-673

I don't really have a great idea for a fix off-hand. I'll keep looking for a bit.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1400337 - only set 'progress' attribute if 'busy' is already set,

Review commit: https://reviewboard.mozilla.org/r/180632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180632/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8909034 [details]
Bug 1400337 - only set 'progress' attribute if 'busy' is already set,

https://reviewboard.mozilla.org/r/180632/#review185828

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eb9099d21dd
only set 'progress' attribute if 'busy' is already set, r=jaws

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8eb9099d21dd