Closed Bug 1400337 Opened 2 years ago Closed 2 years ago
throbber should have two states, gray for connecting and blue for transferring data
59 bytes, text/x-review-board-request
For several days I've only seen the gray throbber. It used to have two states, gray for connecting and blue for transferring data. Now it only shows gray. Tested Windows nightly builds on Win 10.
Mozregression says that bug 1380150 broke this.
Whiteboard: [photon-animation] → [photon-animation] [triage]
The issue is that the progress change listener never seems to get passed either request or webprogress objects, whatever its arguments/contracts might be pretending. As a result, we now no longer ever set the 'progress' flag: https://dxr.mozilla.org/mozilla-central/rev/6be5c7d30d2def62a762ac187252eba626b23a92/browser/base/content/tabbrowser.xml#672-673 I don't really have a great idea for a fix off-hand. I'll keep looking for a bit.
Comment on attachment 8909034 [details] Bug 1400337 - only set 'progress' attribute if 'busy' is already set, https://reviewboard.mozilla.org/r/180632/#review185828
Attachment #8909034 - Flags: review+
Attachment #8909034 - Flags: review?(dao+bmo)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [photon-animation] [triage] → [reserve-photon-animation]
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8eb9099d21dd only set 'progress' attribute if 'busy' is already set, r=jaws
You need to log in before you can comment on or make changes to this bug.