Closed Bug 1380150 Opened 2 years ago Closed 2 years ago
Flickering between favicon and loading indicator after first load
59 bytes, text/x-review-board-request
Once a site loads the favicon appears, but sometimes more content is loaded causing the loading motion to start again repeatably (flickering between the favicon and loading indicator). This causes the experience to feel like a glitch. Note, this currently occurs in Firefox and is not a regression - but not a good experience in the current and new designs. I expect that once the load is complete the first time the motion shouldn't play again. Another option is to have a threshold of when the motion can be played again.
Whiteboard: [photon-animation] → [photon-animation][triage]
Priority: -- → P3
QA Contact: jwilliams
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Whiteboard: [reserve-photon-animation] → [photon-visual][triage]
QA Contact: brindusa.tot
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8904746 [details] Bug 1380150 - Prevent subsequent loads on a page after the initial page load has completed from showing the progress indicator on the tab. This will prevent the favicon from flickering. https://reviewboard.mozilla.org/r/176532/#review181516 This affects whether other progress listeners will get called for these loads, not just the icon, because now you're early-returning from `_shouldShowProgress`. Affecting other listeners here doesn't seem quite right. I'm also confused about the approach. Wouldn't it be enough to just not care about subresource loads here? Maybe I misunderstand how this is supposed to work... ::: browser/base/content/tabbrowser.xml:758 (Diff revision 1) > } > delete this.mBrowser.initialPageLoadedFromURLBar; > // If the browser is loading it must not be crashed anymore > this.mTab.removeAttribute("crashed"); > + > + let listener = this.mTabBrowser._tabListeners.get(this.mTab); Leftover?
Attachment #8904746 - Flags: review?(gijskruitbosch+bugs)
Attachment #8904746 - Attachment is obsolete: true
Comment on attachment 8906072 [details] Bug 1380150 - Prevent subresource loads from showing the progress indicator on the tab. https://reviewboard.mozilla.org/r/177810/#review182984 Very straightforward, r=me on the code. I assume you've tested this... :-)
Attachment #8906072 - Flags: review?(gijskruitbosch+bugs) → review+
Yes, tested on the URL linked to by this bug's URL field.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/440b703da884 Prevent subresource loads from showing the progress indicator on the tab. r=Gijs
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c9fe4ec27ca3 Prevent subresource loads from showing the progress indicator on the tab. r=Gijs
Flags: qe-verify? → qe-verify+
QA Contact: stefan.georgiev
I was able to reproduce this behavior on Nightly build 57.0a1 from 20170910220126. Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 (20170911100210) I have verified this issue as fixed on Nightly build 57.0a1 from 20170911100210.
You need to log in before you can comment on or make changes to this bug.