1400420 - Focusing to element can be covered by browser.preferences.search header (either because moving focus upwards, or because prefs are scrolled down but focus is at the top)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[YF (Yang)]

STR:
1. Open about:preferences
2. Alt+Shift+B to focus on Use Bookmark, and again to 
3. Press Alt+Shift+B three times.

STR 2:
Use Shift+Tab repeatedly after focus on element at bottom in about:preferences.


Actual results:
Focus on Use Bookmark… but it is cannot be see.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

I saw some different behaviors depends on platforms

Key shortcut:

On Mac, it's Ctrl+Opt+B
On Linux & Windows, it's Alt+Shift+B

Behavior:

On Mac & Linux, the key shortcut will open bookmark dialog directly.
On Windows, the key shortcut will focus on Use Bookmark button.

I believe that the focus ring might be covered behind search area.

Comment 3

[sebastian.kleine]

Any news on this? This is by the way relevant for WCAG compliance (at least the german BITV version of it). And to me it's a browser bug that a field that get's the focus by using "tab" key does not get into the visible area. The browser should know about a fixed header and adjust accordingly.

Comment 4

[:Gijs (he/him)]

(In reply to sebastian.kleine from comment #3)

The browser should know about a fixed header and adjust accordingly.

It doesn't 'know' in a simple fashion because the fixed header could be anywhere. There are, however, relatively new-ish CSS methods to tell the browser to adjust scrolling in a container based on such headers, that weren't there when this bug was filed, that we can use to fix this in the prefs, and that other site authors can use to fix their site. I'll add a patch using those.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1400420 - fix tabbing backwards in prefs to not hide items behind the search/policies sticky header, r?#preferences-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c040d6dff93
fix tabbing backwards in prefs to not hide items behind the search/policies sticky header, r=preferences-reviewers,mstriemer

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on browser_containers_name_input.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/cfe12bdd9849f26ab4cfcfdbc549d0e82172d0ac
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&test_paths=browser%2Fcomponents%2Fpreferences%2Ftests&revision=4c040d6dff93069395399a4f0d7e1d96be11616d&selectedTaskRun=PCeS8Ct-RmuDws_CmOnMQg.0
Failure log: https://treeherder.mozilla.org/logviewer?job_id=361047332&repo=autoland&lineNumber=2641
Failure line: TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_containers_name_input.js | A promise chain failed to handle a rejection: Modifications are not allowed for this document - stack: (No stack available.)

Comment 8

[:Gijs (he/him)]

Hrmpf, can't reproduce locally with either opt or debug builds... try + guessing it is, I guess? https://treeherder.mozilla.org/jobs?repo=try&revision=e699c55dde553dfa9d87dbce6f20e2523fdbeebe

Comment 9

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #8)

Hrmpf, can't reproduce locally with either opt or debug builds... try + guessing it is, I guess? https://treeherder.mozilla.org/jobs?repo=try&revision=e699c55dde553dfa9d87dbce6f20e2523fdbeebe

That's all green so hopefully my guess was right...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67d5d9f83775
fix tabbing backwards in prefs to not hide items behind the search/policies sticky header, r=preferences-reviewers,mstriemer

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/67d5d9f83775

Comment 12

[Ardelean Oana]

Reproducible on older Nightly(tested on 58.0a1 and a more recent 96.0a1) versions on MacOS and Ubuntu. The issue seems to be fixed on the latest Nightly build on both Mac and Ubuntu; focus works properly.