Closed
Bug 1400440
Opened 7 years ago
Closed 7 years ago
Fix and enable APZ frame delay on Fennec
Categories
(Core :: Panning and Zooming, enhancement)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(2 files)
In bug 1375949 we implemented an APZ frame delay and enabled it on the Nightly channel in bug 1384708. In bug 1390145 we disabled it on Fennec, because it caused a dynamic toolbar regression. This bug tracks fixing the regression so we can re-enable the APZ frame delay on Fennec.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•7 years ago
|
||
Note that I'd like to enable the APZ frame delay on Fennec Nightly, but not riding the trains in 57 yet, so it receives a few weeks of exposure to Nightly users (potentially catching any additional Fennec-specific regressions), the way it did on desktop. If you feel strongly that it should ride the trains in 57, I'm open to changing my mind.
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8908884 [details] Bug 1400440 - Apply scroll shift for dynamic toolbar to the composited scroll offset right away. https://reviewboard.mozilla.org/r/180512/#review185722
Attachment #8908884 -
Flags: review?(bugmail) → review+
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8908885 [details] Bug 1400440 - Re-enable apz.frame_delay.enabled on Fennec Nightly. https://reviewboard.mozilla.org/r/180514/#review185724 Yeah let's keep this on Nightly for a bit.
Attachment #8908885 -
Flags: review?(bugmail) → review+
|
||
Comment 6•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s efecec38efc8 -d 68c789e404f0: rebasing 421063:efecec38efc8 "Bug 1400440 - Apply scroll shift for dynamic toolbar to the composited scroll offset right away. r=kats" merging gfx/layers/apz/src/AsyncPanZoomController.cpp rebasing 421064:f873d0e83e9c "Bug 1400440 - Re-enable apz.frame_delay.enabled on Fennec Nightly. r=kats" (tip) merging mobile/android/app/mobile.js warning: conflicts while merging mobile/android/app/mobile.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d2c4c8a2982 Apply scroll shift for dynamic toolbar to the composited scroll offset right away. r=kats https://hg.mozilla.org/integration/autoland/rev/cffcb90edf57 Re-enable apz.frame_delay.enabled on Fennec Nightly. r=kats
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6d2c4c8a2982 https://hg.mozilla.org/mozilla-central/rev/cffcb90edf57
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•