1400456 - browser.tabs.move() has unexpected behavior when moving multiple tabs between windows

Status: RESOLVED DUPLICATE of bug 1809364

(WebExtensions :: General, enhancement, P5)

Description

[u462496]

When moving tabs between windows:

If the _tPos's of the tabs to be moved are lesser than the index being moved to in the other window, the tabs appear in reverse order of how they appeared in the original window - expected behavior (I think).

If the _tPos's of the tabs to be moved are greater than the index being moved to in the other window, the tabs appear in the same of how they appeared in the original window - not expected behavior (I think).

If some _tPos's are greater and some lesser, some of the tabs appear the same, some reversed from how they appeared in the original window.

Reference:

http://searchfox.org/mozilla-central/source/browser/components/extensions/ext-tabs.js#599-604

I am wondering that when moving tabs to another window, what the _tPos of the tabs in the original window has to do with the new window move?  It seems we should be ignoring the original _tPos's in that case.

Naively, ignoring tabs moved from another window in the referenced code seems to work:

  if (nativeTab.ownerGlobal == window &&
      lastInsertion.has(window) &&
      lastInsertion.get(window) === insertionPoint &&
      nativeTab._tPos > insertionPoint) {
    insertionPoint++;
    indexMap.set(window, insertionPoint);
  }

Comment 1

[u462496]

I think I stated the expected behavior in the reverse.  From the documentation, the expected behavior would be:

"If you include [windowId], and tabIds contains more than one tab, then the first tab in tabIds will be moved to index, and the other tabs will follow it in the order given in tabIds".  I take this to mean that the moved tabs will appear in the tabs bar in the order of tabIds, which certainly seems intuitive to me.

In that case, incrementation of insertionPoint should actually occur every time for tabs moved from another window, in which case this code seems to work:

  if ((nativeTab.ownerGlobal != window) ||
      lastInsertion.has(window) &&
      lastInsertion.get(window) === insertionPoint &&
      nativeTab._tPos > insertionPoint)) {
    insertionPoint++;
    indexMap.set(window, insertionPoint);
  }

Andy, do you care to comment on this?

In any case, again, _tPos's of tabs moved from another window should be irrelevant, since that relationship only has to do with the fact that when moving tabs within the same window, each tab moved from before the insertion point affects the _tPos of all tabs preceding the insertion point.

Comment 2

[Andy McKay]

Ah right, good call. That makes sense to me.

Comment 3

[Firefox Bug Husbandry Bot]

Bulk move of bugs per https://bugzilla.mozilla.org/show_bug.cgi?id=1483958

Comment 4

[Oriol Brufau [:Oriol]]

This seems the same as what I fixed in bug 1809364.