1809364 - tabs.move is broken when moving multiple tabs into a different window

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P3)

Description

[Oriol Brufau [:Oriol]]

So, bug 1323311 tried to improve browser.tabs.move, but:

• The logic doesn't really make sense (e.g. why use 2 different maps to track indices?).
• It broke moving multiple tabs between windows, they appear in the wrong order. That's because it used nativeTab._tPos > insertionPoint where insertionPoint may be referring to a different window so comparing with _tPos is wrong.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1809364 - Make tabs.move on multiple tabs more reliable (2). r?robwu

Bug 1323311 tried to improve browser.tabs.move, but the logic didn't
really make sense (e.g. why use 2 different maps to track indices?),
and it broke moving multiple tabs between windows: they would appear
in the wrong order.

Comment 2

[Oriol Brufau [:Oriol]]

Example:

var tabs = await Promise.all([
  browser.tabs.create({url: "about:blank?1", index: 1}),
  browser.tabs.create({url: "about:blank?2", index: 2}),
  browser.tabs.create({url: "about:blank?3", index: 3}),
]);
var win2 = await browser.windows.create();
browser.tabs.move(tabs.map(t => t.id), {index: 0, windowId: win2.id})

The tabs in the new window will be about:blank?1, about:blank?3, about:blank?2, New Tab.

The order should be about:blank?1, about:blank?2, about:blank?3, New Tab.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1323311

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e402dcbe2983
Make tabs.move on multiple tabs more reliable (2). r=robwu

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e402dcbe2983