1400549 - Crash in mozilla::gfx::SourceSurfaceVolatileData::Map

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-1f2bfa88-2029-49f5-bd43-4b3fe0170916.
=============================================================

There are 41 in nightly 57 with buildid 20170916100147 and 73 for FennecAndroid with buildid 20170916100141. 
In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1380649.

[1] https://hg.mozilla.org/mozilla-central/rev?node=722569a89186be92efbaebfa99005e5c46e27cf5

Comment 1

[Calixte Denizet (:calixte)]

The signature is ranked #4 in nightly top-crashers for FennecAndroid.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

I was expecting the diagnostic assert to crash (to figure out what went wrong) but not nearly as often as we are seeing (it was relatively rarely observed, or so I thought...). Backed out the offending change and I think the traces I've looked at gave me the information I needed to solve the original problem.

Comment 3

[George K.]

I'm apparently experiencing this crash pretty regularly on macOS 10.12.6 today, so if you need any additional info or testing let me know.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b3f6d72c338e

Comment 6

[Andrew McCreight [:mccr8]]

FWIW, this also ended up being a top crash on OSX, with a staggering 90% of all OSX crashes.

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Andrew McCreight [:mccr8] from comment #6)
> FWIW, this also ended up being a top crash on OSX, with a staggering 90% of
> all OSX crashes.

Yes. My apologies. Really, given 3 reports over 2 years of images occasionally missing off pages in Firefox, I did not expect it to be happening constantly to every nightly user :(. This has not been a good weekend for me and crashes it seems.