Closed Bug 1400575 Opened 2 years ago Closed 2 years ago

Port bug 1387582 to TB [Allow modifying the toolbar text color separately from the global text color]

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files, 3 obsolete files)

From bug 1387582: You can set the global text color (colors.textcolor) and a toolbar background (colors.toolbar), but you can't set the text color of the toolbars (colors.toolbartext?).
Attached patch toolbarTextColor.patch (obsolete) — Splinter Review
Direct port of https://hg.mozilla.org/mozilla-central/rev/7bda9cc7b798 (CSS part) plus added support for status bar which no more exists in FX.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8909011 - Flags: review?(jorgk)
Attached file nuvola-webext-theme.xpi (obsolete) —
For easier review I add a test theme which makes the text red.
Looks like I need to refresh by build here first to make it work :-(
With the patch and the special test theme, the text colour on toolbars goes red. Also, the colour on the compose window's menu (File, Edit, View, etc.) and the text of the active tab in the main window. The latter is most likely due to:
	
.tabmail-tab[visuallyselected=true]:-moz-lwtheme {
  color: var(--toolbar-color, inherit);
}

Is that really desired?
Attached patch toolbarTextColor.patch (obsolete) — Splinter Review
(In reply to Jorg K (GMT+2) from comment #4)
> With the patch and the special test theme, the text colour on toolbars goes
> red. Also, the colour on the compose window's menu (File, Edit, View, etc.)
> and the text of the active tab in the main window. The latter is most likely
> due to:
> 	
> .tabmail-tab[visuallyselected=true]:-moz-lwtheme {
>   color: var(--toolbar-color, inherit);
> }
> 
> Is that really desired?

Yes, because normally when someone sets the text color he sets the toolbar background color too. And this background color is also on the selected tab.

I'll attach a better test theme to show this.

I found a bug there Win7 Aero's menubar hadn't the correct colors because it is special where the menubar is positioned. I also moved the addressbook.css code to the shared file.
Attachment #8909011 - Attachment is obsolete: true
Attachment #8909011 - Flags: review?(jorgk)
Attachment #8909099 - Flags: review?(jorgk)
Attached file test-webext-theme.xpi
Better test theme.
Attachment #8909012 - Attachment is obsolete: true
Attachment #8909100 - Attachment mime type: application/x-xpinstall → application/octet-stream
Comment on attachment 8909099 [details] [diff] [review]
toolbarTextColor.patch

(In reply to Richard Marti (:Paenglab) from comment #6)
> Better test theme.
That theme is terrible :-(

;-)
Attachment #8909099 - Flags: review?(jorgk) → review+
Only change: I added a '-moz-appearance: none;' to OSX AB's and composer's toolboxes to really show the background color.

(In reply to Jorg K (GMT+2) from comment #7)
> (In reply to Richard Marti (:Paenglab) from comment #6)
> > Better test theme.
> That theme is terrible :-(

I hope you didn't got eye cancer.
Attachment #8909099 - Attachment is obsolete: true
Attachment #8909135 - Flags: review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5a2d4268fbd5
Port bug 1387582 to TB [Add toolbar_text color property to theming API]. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
Blocks: 1387582
You need to log in before you can comment on or make changes to this bug.