1400812 - Consider removal containers drawer icon

Status: VERIFIED FIXED

(Firefox :: Security, defect)

Description

[Jonathan Kingston [:jkt] he/him]

As we have the + button long press the containers drawer icon has become a little confusing. I'm happy to reimplement this as a web extension if people like it's minimal interface over https://addons.mozilla.org/en-GB/firefox/addon/multi-account-containers/

This code adds complexity that we likely don't need to Firefox that can be implemented in an extension as proven.

As we have had a fair few users confused about what containers are, I think we can remove this.

Comment 1

[Jonathan Kingston [:jkt] he/him]

I made this to replace: https://addons.mozilla.org/en-US/firefox/addon/containers-drawer/

Comment 2

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1400812 - Removal of containers drawer icon.

Review commit: https://reviewboard.mozilla.org/r/182250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182250/

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8910787 [details]
Bug 1400812 - Removal of containers drawer icon.

https://reviewboard.mozilla.org/r/182250/#review187590

You must ask a review to browser peer.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8910787 [details]
Bug 1400812 - Removal of containers drawer icon.

https://reviewboard.mozilla.org/r/182250/#review187592

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1d60297f919
Removal of containers drawer icon. r=baku,dao

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d1d60297f919

Comment 7

[Sylvestre Ledru [:Sylvestre]]

We probably want this to ride the trains with 58

Comment 8

[Dão Gottwald [:dao]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #7)
> We probably want this to ride the trains with 58

I think it would make sense to uplift this since this feature is unsupported at this point.

Comment 9

[Jonathan Kingston [:jkt] he/him]

It's not really unsupported, but I dunno perhaps there is a perf improvement of removing it too?

The rationale of removing was because we want to promote our extension and users got confused, as users can install something similar too it's not relevant to keep the overhead of perf/maintaining here. Also as containers is difficult to understand as it is every little cognitive hurdle is worth ironing out.

I'll request uplift and see. Thanks.

Comment 10

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8910787 [details]
Bug 1400812 - Removal of containers drawer icon.

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Confusion on containers feature, perf issue perhaps too?
[Is this code covered by automated tests?]: No, there never was one.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Not required however,open customise in Firefox and see if there is a drawer icon with "Open Container Drawer" as it's text. There should be no icon.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is just code removal for a widget that are never shown unless the user customises their browser.
[String changes made/needed]: N/A

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8910787 [details]
Bug 1400812 - Removal of containers drawer icon.

Taking it to prevent from shipping useless code.
Should be in 57b3

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Jonathan Kingston [:jkt] from comment #10)
> [String changes made/needed]: N/A

FYI: String removal counts as string changes.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/df744fbcedc4

Comment 14

[B.J. Herbison]

The removal left "containers-panelmenu" in my CustomizableUI.getWidgetIdsInArea("TabsToolbar"), which means my New Tab button is invisible.

Discussed in bug 1370791.

Comment 15

[Vlad Bacia-Mociran [:VladB]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20170929100122

This issue can be reproduce with Nightly Build ID: 20170901220209 on Windows 8.1 x64.

This issue has been verified on latest Firefox Nightly Build ID: 20170929100122 on Windows 8.1 x64, Mac OS 10.12 and Ubuntu 14.04 and it is no longer reproducible. When opening the Customization menu, there is no "Open Container Tab" button, it has been removed.

Comment 16

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 58.0a1 (20170918220054) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 57.0b13 Win 8.1 x64, Ubuntu 14.04 x64 and Mac OS X 10.13.