1400858 - [RTL] Tab titles not displayed for some webpages

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Oana Horvath [:ohorvath]]

Attachment: RTL-tabs titles.png

Devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Huawei MediaPad M2 (Android 5.1.1)

Build: Nightly 57.0a1 (2017-09-18);

Steps to reproduce:
1. On a tablet device, set the browser language to an RTL supported language.
2. Go to a webpage like amazon.com or addons.mozilla.com.
3. Check the tab title.

Expected result:
The page name should be displayed.

Actual result:
Page titles are not displayed on the tab.

Comment 1

[Wesly Huang (EPM)]

Jingwei, maybe it's an alignment issue so can be easily fixed? Would you help on it? 

If can't catch the merge day then let's get it done in Sprint#58.1 (then uplift to 57 Beta). Thanks.

Comment 2

[Jing-wei Wu [:jwu]]

Hi Oana,

I cannot reproduce this issue within these two tablets:

Pixel C (Android 8.0.0)
https://imgur.com/a/sNHlK

Nexus 7 emulator (Android 6.0) 
https://imgur.com/a/mSMlS

Which language did you use for testing? Hope it's not device or brand specific bug...

Comment 3

[Oana Horvath [:ohorvath]]

Attachment: RTL languages.jpg

Checked with the following devices and the results are:

Asus ZenPad 8.0 Z380KL (Android 6.0.1) - Reproducing
Huawei MediaPad M2 (Android 5.1.1) - Reproducing
Sony Xperia Z2 (Android 5.0.2) - Reproducing

Xiaomi Mi Pad 2 (Android 5.1) - Not reproducing
Samsung Galaxy Tab S3 (Android 7.0) - Not reproducing
Samsung Galaxy Tab Active (Android 5.1.1) - Not reproducing

It is somehow device specific but I can't figure out what is the cause, sometimes it appears back by changing the device orientation, but not 100% of cases. 
I attached a screenshot of the languages I've checked, if I'm not mistaken, they are: Hebrew, Arabic and Persian.

Comment 4

[Jing-wei Wu [:jwu]]

After some investigation, I think maybe this issue isn't directly caused by RTL, but has similar root cause described in bug 1400164.

The title view is an instance of FadedSingleColorTextView, which doesn't implement 'Checkable' interface. When we toggle tabs, it might not be notified that status is changed and cause the text color unchanged.

Comment 5

[Jing-wei Wu [:jwu]]

Attachment: Bug 1400858 - Introduce class CheckableFadedSingleColorTextView for supporting 'Checkable' status.

Review commit: https://reviewboard.mozilla.org/r/181668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181668/

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8910176 [details]
Bug 1400858 - Introduce class CheckableFadedSingleColorTextView for supporting 'Checkable' status.

https://reviewboard.mozilla.org/r/181668/#review187034

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b165925af92a
Introduce class CheckableFadedSingleColorTextView for supporting 'Checkable' status. r=nechen

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b165925af92a

Comment 9

[Oana Horvath [:ohorvath]]

Still reproducing on my devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Huawei MediaPad M2 (Android 5.1.1)
Build: Nightly 58 (2017-09-26) and Beta 57.0b3.