1400868 - Intermittent leakcheck | tab process: 7648 bytes leaked (nsDisplayLayerEventRegions, nsDisplayTransform, nsDisplayWrapList, nsRect, nsTArray_base)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: kgupta [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=131734764&repo=autoland

https://queue.taskcluster.net/v1/task/cBDLRinxTISCk3XLafkd9g/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/cBDLRinxTISCk3XLafkd9g/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

I think this is a regression from bug 1400034 that I missed in my try pushes. I'm investigating.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This should be fixed on autoland by the backout in https://bugzilla.mozilla.org/show_bug.cgi?id=1400034#c26 but we'll need to fix it properly before relanding, so let's keep this bug open and blocking bug 1400888.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I can reproduce a leak of some nsDisplayLayerEventRegions when I run the transform-3d/backface-visibility-1b.html reftest locally on a debug build. I'll investigate.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

That one was introduced in https://hg.mozilla.org/mozilla-central/rev/f8712cfa2588#l2.12 - we're not destroying the display item before "continue"ing.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1400868 - Destroy backface-hidden display items that we're not going to process.

Review commit: https://reviewboard.mozilla.org/r/180894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180894/

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed9d813db9659b701dbab5568c43cbffa08d88b2 - R8 is green here, so this seems sufficient to fix the leak.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Redirecting review since Morris is on PTO ^

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8909351 [details]
Bug 1400868 - Destroy backface-hidden display items that we're not going to process.

https://reviewboard.mozilla.org/r/180894/#review186522

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05c577db8142
Destroy backface-hidden display items that we're not going to process. r=jrmuizel

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/05c577db8142

Comment 10

[Intermittent Failures Robot]

8 failures in 943 pushes (0.008 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 8

Platform breakdown:
* linux64-qr: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1400868&startday=2017-09-18&endday=2017-09-24&tree=all