Closed Bug 1400868 Opened 4 years ago Closed 4 years ago
Intermittent leakcheck | tab process: 7648 bytes leaked (ns
Display Layer Event Regions, ns Display Transform, ns Display Wrap List, ns Rect, ns TArray _base)
59 bytes, text/x-review-board-request
Filed by: kgupta [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=131734764&repo=autoland https://queue.taskcluster.net/v1/task/cBDLRinxTISCk3XLafkd9g/runs/0/artifacts/public/logs/live_backing.log https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/cBDLRinxTISCk3XLafkd9g/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1 I think this is a regression from bug 1400034 that I missed in my try pushes. I'm investigating.
Assignee: nobody → bugmail
OS: Unspecified → Linux
Priority: P5 → P1
Hardware: Unspecified → x86_64
Version: unspecified → 57 Branch
This should be fixed on autoland by the backout in https://bugzilla.mozilla.org/show_bug.cgi?id=1400034#c26 but we'll need to fix it properly before relanding, so let's keep this bug open and blocking bug 1400888.
I can reproduce a leak of some nsDisplayLayerEventRegions when I run the transform-3d/backface-visibility-1b.html reftest locally on a debug build. I'll investigate.
That one was introduced in https://hg.mozilla.org/mozilla-central/rev/f8712cfa2588#l2.12 - we're not destroying the display item before "continue"ing.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed9d813db9659b701dbab5568c43cbffa08d88b2 - R8 is green here, so this seems sufficient to fix the leak.
Status: NEW → ASSIGNED
Whiteboard: [gfx-noted][wr-mvp][triage] → [wr-mvp] [gfx-noted]
Target Milestone: --- → mozilla57
Attachment #8909351 - Flags: review?(mtseng) → review?(jmuizelaar)
Redirecting review since Morris is on PTO ^
4 years ago
Comment on attachment 8909351 [details] Bug 1400868 - Destroy backface-hidden display items that we're not going to process. https://reviewboard.mozilla.org/r/180894/#review186522
Attachment #8909351 - Flags: review?(jmuizelaar) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/05c577db8142 Destroy backface-hidden display items that we're not going to process. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.