1400888 - Turn on layers-free for transform/ and transform-3d/ reftests

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

I tried turning on layers-free for the transform/ and transform-3d/ reftests in bug 1400034, but it exposed some leaks and intermittent fuzzy failures so we backed it out. The leaks are permafail on R8 debug, the fuzzies affect a few different transform-3d tests. See the R8 jobs on the following:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=583a3dec5b1d4099aec9d3916229ff3bb1b4e0ba

https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=1e2233c98ff1e88570cf61b52ee3bf57e39950df&filter-searchStr=qr&group_state=expanded&bugfiler&tochange=776c180fb82ac7e04ffc9b72a9691930a3eae019

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I went through all the R8 failures in the above links and listed the fuzzy-fails:

from the try push
/transform-3d/rotatey-1a.html (1,6)
/transform-3d/perspective-origin-1b.html (1,1)
/transform-3d/rotatex-transformorigin-1a.html (1,2)
/transform-3d/rotatex-transformorigin-1a.html (1,1)
/transform-3d/perspective-origin-1b.html (1,1)
/transform-3d/rotatex-transformorigin-1a.html (1,1)
/transform-3d/rotatex-transformorigin-1a.html (1,1)
/transform-3d/perspective-origin-1b.html (1,1)
/transform-3d/rotatex-transformorigin-1a.html (1,1)

from autoland
/transform-3d/rotatey-1a.html (1,2)
/transform-3d/rotatey-1a.html (1,4)
/transform-3d/rotatey-1a.html (1,4)
/transform-3d/rotatey-1a.html (1,6)
/transform-3d/perspective-origin-1b.html (1,1)
/transform-3d/rotatey-1a.html (1,2)
/transform-3d/perspective-origin-1b.html (1,1)

So that boils down to this:
transform-3d/rotatey-1a.html -> (0-1,0-6)
transform-3d/perspective-origin-1b.html -> (0-1,0-1)
transform-3d/rotatex-transformorigin-1a.html -> (0-1,0-1)

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #1)
> So that boils down to this:
> transform-3d/rotatey-1a.html -> (0-1,0-6)
> transform-3d/perspective-origin-1b.html -> (0-1,0-1)
> transform-3d/rotatex-transformorigin-1a.html -> (0-1,0-1)

I applied these fuzzes and things are looking good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcf1c207014ce2bdd8b462cd86aa87bc277c1d02

I'll put up two patches for review. One is the part3 patch from bug 1400034 which was already r+'d on that bug (and landed and then backed out). The other is the above fuzzes to make the reftests green.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1400888 - Turn on layers-free for transform/ and transform-3d/ reftests.

Review commit: https://reviewboard.mozilla.org/r/180910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180910/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1400888 - Mark some transform-3d reftests intermittently fuzzy in layers-free webrender.

Review commit: https://reviewboard.mozilla.org/r/180912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180912/

Comment 5

[Ethan Lin[:ethlin]]

Comment on attachment 8909390 [details]
Bug 1400888 - Turn on layers-free for transform/ and transform-3d/ reftests.

https://reviewboard.mozilla.org/r/180910/#review186392

Comment 6

[Ethan Lin[:ethlin]]

Comment on attachment 8909391 [details]
Bug 1400888 - Mark some transform-3d reftests intermittently fuzzy in layers-free webrender.

https://reviewboard.mozilla.org/r/180912/#review186394

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a0c39ba138b
Turn on layers-free for transform/ and transform-3d/ reftests. r=ethlin
https://hg.mozilla.org/integration/autoland/rev/f1cbf53a14ea
Mark some transform-3d reftests intermittently fuzzy in layers-free webrender. r=ethlin

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2a0c39ba138b
https://hg.mozilla.org/mozilla-central/rev/f1cbf53a14ea