1400902 - [Shield][Admin] Creating new extension with best-proxy switcher AMO add-on bounces off

Status: RESOLVED FIXED

(Shield :: General, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: best_proxy_switcher-5.4.0-an+fx.xpi

[Environment:]
Firefox 56.0b12 20170914024831

[Preconditions:]
You need access to Admin interface (https://normandy-admin.stage.mozaws.net/control) or New Admin interface (https://normandy-admin.stage.mozaws.net/control-new)
1. Obtain a copy of Firefox with the SHIELD recipe client system add-on installed. You can check about:support to ensure that you have it.
2. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
3. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
4. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90.
5. Set the preference value for extensions.shield-recipe-client.api_url set to https://normandy.stage.mozaws.net/api/v1

[Steps:]
1. Open Firefox.
2. Open https://normandy-admin.stage.mozaws.net/control-new
3. Download the attached add-on. (downloaded from AMO)
4. Click on View all Extensions.
5. Click on New extension.
6. Upload the attached file.
7. Press save.

[Actual Result:]
The new extension is not saved.

[Expected Result:]
The new extension should be saved.

Comment 1

[Michael Cooper [:mythmon]]

The STR above result in the server responding with HTTP 413 Request Entity Too Large, i.e. the add-on is too big. We don't have any explicit policies about add-on size, and this add-on does not appear to be unreasonably sized (at 2.23MB). This is likely a default setting meant to prevent abuse.

This same test works as expected in my local environment, which makes me think this is out side of our code. relud: Can you comment on what might be causing these limits?

Comment 2

[Daniel Thorn [:relud]]

probably a result of the client_max_body_size setting in nginx which has a default of 1m

http://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size

Comment 3

[Michael Cooper [:mythmon]]

Yep, that would do it. We should probably increase that value for the upload url. Can we set this to 100MB for `/api/v2/extension/`?

Why 100MB? I have anecdotal evidence of extensions up to 70MB (the b2g simulator). That got uploaded to AMO, and we probably shouldn't be more restrictive than AMO. Plus it is a nice round number.

Comment 4

[Adrian Florinescu [:aflorinescu]]

I personally have no problem with 100MB, but if we are going to align with AMOs' upload limit, let's make it 200MB ->see bug 1374648.

Comment 5

[Michael Cooper [:mythmon]]

Thanks for digging this up Adrian. +1 to a 200MB limit.

Comment 6

[Daniel Thorn [:relud]]

will be fixed by https://github.com/mozilla-services/cloudops-deployment/pull/1172

Comment 7

[Daniel Thorn [:relud]]

PR merged. Build #354 will take this to stage, and the next deploy to prod admin will have this.