Closed Bug 140107 Opened 22 years ago Closed 22 years ago

HTTP headers show in frame [when server pipelines chunked responses]

Categories

(Core :: Networking: HTTP, defect, P3)

Product:
Core
Component:
Networking: HTTP
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: darin.moz, Assigned: darin.moz)

References

(
URL
)

Details

(Keywords: topembed, Whiteboard: [pipelining][adt2 RTM][verified trunk] [ETA 06/21])

Attachments

(2 files, 1 obsolete file)

screenshot
94.20 KB, image/png
Details
v2 patch
7.91 KB, patch
dougt
: review+
jud
: approval+
Details | Diff | Splinter Review 
HTTP headers show in frame

Not 100% reproducible, and possibly related to pipelining being enabled.

linux build 2002-04-25/10
Attached image screenshot — 

    
  
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [pipelining]
Target Milestone: --- → mozilla1.0

    
    

    
  
leaving untargeted for now
Target Milestone: mozilla1.0 → ---

    
    

    
  
I cannot reproduce this in RC2, build 20020507-00 on Linux.

BTW, isnt' this a dupe of bug #140853 ?

    
    

    
  
considering this bug have a lower number and was therefore reported before bug
#140853 , it must be the other way around.
That bug #140853 is a DUP of this bug.

Bug #140853 however have had more discussion so we might as well mark this bug a
DUP of bug #140853.
In anycase it's the same bug.

They may also both be dups of bug #82948 or just related to it.
IMO we should mark both as DUPS of bug #82948.

    
    

    
  
defenitly a dupe of bug 82948
which is already assigned.

    
    

    
  
mass futuring of untargeted bugs
Target Milestone: --- → Future

    
    

    
  
*** Bug 150672 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 147097 has been marked as a duplicate of this bug. ***

    
  
Target Milestone: Future → mozilla1.0.1

    
  
Summary: HTTP headers show in frame → HTTP headers show in frame [when server pipelines chunked responses]

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1 patch (obsolete)
        — 
          — Splinter Review
      

    


  
this patch fixes the problem.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2 patch
        — 
          — Splinter Review
      

    


  
cleaned up patch.

        Attachment #87875 -
        Attachment is obsolete: true

    
    

    
  
this latest patch is functionally equivalent to the first, but it goes one step
further by simplifying some related code.  i've tested the patch with a number
of different sites, and it seems to do the trick.
Whiteboard: [pipelining] → [pipelining][adt2 RTM]

    
    

    
  
Comment on attachment 87985 [details] [diff] [review]
v2 patch

sr=rpotts@netscape.com

looks good.

        Attachment #87985 -
        Flags: superreview+

    
    

    
  
Comment on attachment 87985 [details] [diff] [review]
v2 patch

i liked the other ascii picture better. :-)

r=dougt

        Attachment #87985 -
        Flags: superreview+ → review+

    
    

    
  
fixed-on-trunk

hoping to land this fix on the 1.0 branch as well.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: mozilla1.0.1, 
          
            topembed
Resolution: --- → FIXED

    
    

    
  
*** Bug 140853 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 144574 has been marked as a duplicate of this bug. ***

    
    

    
  
tested with and without pipelining and checked sites in duplicate bugs

verified trunk - 06/18/02 builds - win NT4, linux rh6, mac osX
Status: RESOLVED → VERIFIED

    
    

    
  
*** Bug 82948 has been marked as a duplicate of this bug. ***

    
  
Whiteboard: [pipelining][adt2 RTM] → [pipelining][adt2 RTM][verified trunk]

    
  
Keywords: adt1.0.1

    
  

        Attachment #87985 -
        Flags: approval+

    
    

    
  
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+

    
    

    
  
adt1.0.1 (on ADT's behalf) approval for checkin to the 1.0 branch, pending
drivers' approval. pls check this in asap, then add the "fixed1.0.1" keyword.
Blocks: 143047
Keywords: adt1.0.1 → adt1.0.1+, 
          
            approval, 
          
            nsbeta1+
Whiteboard: [pipelining][adt2 RTM][verified trunk] → [pipelining][adt2 RTM][verified trunk] [ETA 06/21]

    
    

    
  
fixed1.0.1
Keywords: mozilla1.0.1+ → fixed1.0.1

    
    

    
  
*** Bug 148298 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 155876 has been marked as a duplicate of this bug. ***

    
  
Keywords: verified1.0.1

    
    

    
  
removing fixed1.0.1 keyword
Keywords: fixed1.0.1

    
    

    
  
*** Bug 164833 has been marked as a duplicate of this bug. ***

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: