Closed Bug 1401090 Opened 3 years ago Closed 2 years ago

Intermittent test_FrameSelection.html,test_HaveMetadataUnbufferedSeek.html,test_EndedEvent.html | application crashed [@ mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::~Log] after Assertion failure: [GFX1]: BlitImage(SurfaceTextureImage) not implemen

Categories

(Core :: Graphics, defect, P2)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox57 --- disabled
firefox58 --- disabled

People

(Reporter: philor, Assigned: snorp)

References

Details

(Keywords: crash, intermittent-failure, Whiteboard: [gfx-noted][stockwell disabled])

Crash Data

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1396704 +++

https://treeherder.mozilla.org/logviewer.html#?job_id=131900006&repo=mozilla-inbound

[task 2017-09-19T05:01:59.347Z] 05:01:59  WARNING -  PROCESS-CRASH | dom/media/mediasource/test/test_FrameSelection.html | application crashed [@ mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::~Log]

[task 2017-09-19T05:02:02.689Z] 05:02:02     INFO -  09-18 22:01:20.910 F/MOZ_Assert(  795): Assertion failure: [GFX1]: BlitImage(SurfaceTextureImage) not implemented., at /builds/worker/workspace/build/src/gfx/2d/Logging.h:520
Assignee: nobody → jgilbert
Priority: P1 → P2
Whiteboard: [gfx-noted]
Is this expected? Weren't we getting a SurfaceTexture backend? Or was it removed?
What should we be expecting here?
Flags: needinfo?(snorp)
We removed or disabled the SurfaceTexture blitting because the attach/detach stuff in SurfaceTexture support was also removed, but we probably need to bring all of this back. We should probably not take thumbnails during tests, though....
Flags: needinfo?(snorp)
this is failing quite often on android/debug- :snorp, is this something you can get fixed?
Flags: needinfo?(snorp)
Whiteboard: [gfx-noted] → [gfx-noted][stockwell needswork]
I have a patch up to just remove the error, but I'm actually fixing the implementation in bug 1395497. We'll see which one wins!
Flags: needinfo?(snorp)
Comment on attachment 8912248 [details]
Bug 1401090 - Don't die in debug build when trying to copy SurfaceTexture

https://reviewboard.mozilla.org/r/183594/#review190008
Attachment #8912248 - Flags: review?(jgilbert) → review+
:snorp, can we land your patch today, or is there a reason to hold off?  I am mostly concerned about the high rate of failure and getting that under control.
Flags: needinfo?(snorp)
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b5bef1c1595
Disable test_FrameSelection.html,test_HaveMetadataUnbufferedSeek.html,test_EndedEvent.html on android for frequent failures. r=me, a=test-only
please remember to enable this test when fixing the failure!
Keywords: leave-open
Whiteboard: [gfx-noted][stockwell disable-recommended] → [gfx-noted][stockwell disabled]
On Beta, this patch just shifted the failures to test_MediaSource.html. So I don't think we're going to successfully disable our way to victory here unless we swing a very large and indiscriminate hammer.
Flags: needinfo?(jmaher)
bummer this is still failing on beta, maybe :snorp will want to land his patch soon and we can see this fixed- otherwise in due time we will work on disabling more tests.
Flags: needinfo?(jmaher)
Per IRC discussion with snorp, this patch is being superseded by bug 1395497.
Depends on: 1395497
Flags: needinfo?(snorp)
Assignee: jgilbert → snorp
Closing because no crash reported since 12 weeks.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.