1401109 - firefox 55 driven by geckodriver crashes on quit

Status: RESOLVED FIXED

(Testing :: geckodriver, defect)

Description

[Alexei Barantsev]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36

Steps to reproduce:

Running this scenario using Java Selenium binding 3.5.3, geckodriver 0.19 and Firefox 55 on Windows 7 x64:

WebDriver driver = new FirefoxDriver();
driver.quit();


Actual results:

System crash dialog apperas when the browser attempts to stop that contains this data:

Сигнатура проблемы:
  Имя события проблемы:	APPCRASH
  Имя приложения:	firefox.exe
  Версия приложения:	55.0.3.6445
  Отметка времени приложения:	599ed8ae
  Имя модуля с ошибкой:	xul.dll
  Версия модуля с ошибкой:	55.0.3.6445
  Отметка времени модуля с ошибкой:	599edd23
  Код исключения:	80000003
  Смещение исключения:	0000000000440ce1
  Версия ОС:	6.1.7601.2.1.0.256.48
  Код языка:	1049
  Дополнительные сведения 1:	c2b3
  Дополнительные сведения 2:	c2b305fdc6a0733c90e0a63499347497
  Дополнительные сведения 3:	e42d
  Дополнительные сведения 4:	e42d40d978a6282905b34081644adee0

Geckodriver trace level log: https://gist.github.com/barancev/61ba5773f553c8dd890edd11cf3b1d8f

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Moving to geckodriver for now to investigate.

Comment 2

[Alexei Barantsev]

Note: Firefox 56 (from dev channel) and 57 (from nightly channel) don't crash.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ted, would you mind having a look and tell us why the Windows crash reporter comes up? Via bug 1388249 I added the necessary crash reporter environment variables to geckodriver, which should always enable breakpad, but never show it's UI. Is the above a situation when breakpad cannot handle the crash, and Windows' own crash reporter picks it up?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Alexei, some more questions:

* Which version of Firefox are you using 32bit or 64bit?
* Does the crash also happen when you add a delay of about 10s before quitting Firefox?
* The trace log shows a navigation request. Does the crash also happen without it?

I'm trying to reproduce such a crash but cannot right now.

Comment 5

[Alexei Barantsev]

* Tried both 32-bit and 64-bit
* Adding a delay does not preven crash
* Removing navigation does not prevent crash too

Note, that if I start browser witout geckodriver, as a human, it does not crash on exit.

Comment 6

[u577193]

May this helps: I've seen this behaviour with earlier versions and found a waorkaround by de-activationg multi-processing of Firefox!
Maybe you could check, whether the multiple processes of 'firefox.exe' are quit in the right order when executiong driver.quit()!

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Firefox 56 will be released soon, so I don't think it makes sense to investigate the problem further. If 56 and 57 work fine, everyone who has this problem would just have to upgrade Firefox.

Closing as WFM.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Going to reopen, so that we can make sure to handle such a condition correctly. As it has been reported via https://github.com/mozilla/geckodriver/issues/966 geckodriver may leave processes behind. So that should definitely be fixed.

Comment 9

[Alexei Barantsev]

I can confirm that Firefox 56 does not crash on quit.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I believe that the underlying problem here is bug 1403923. Currently we request a quit of Firefox but while it is closing down we force kill the process.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is now fixed by my patch on bug 1403923, and already available in the latest Nightly build.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sorry, it's not in the Nightly, but you need a new build or the upcoming release of geckodriver.