1431058 - By default delete_session has to perform a safe shutdown of Firefox

Status: RESOLVED INVALID

(Testing :: geckodriver, enhancement)

Description

[Cosmin Sabou [:CosminS]]

+++ This bug was initially created as a clone of Bug #1403923 +++

New fail: https://treeherder.mozilla.org/#/jobs?repo=autoland&noautoclassify&fromchange=46f721d7988bcc0bd1cbf22854d40abd0cf1c2b2&selectedJob=156849268&filter-searchStr=9c01d623a4ec4479607bcad7655b9e5f2334ad5b

Right now geckodriver is forcing the exit of Firefox by sending the kill signal:

https://searchfox.org/mozilla-central/rev/f54c1723befe6bcc7229f005217d5c681128fcad/testing/geckodriver/src/marionette.rs#582-587

https://github.com/jgraham/rust_mozrunner/blob/master/src/runner.rs#L145

This is unfortunate given the following reasons:

* The shutdown can force an internal crash, which most people noticed with Firefox 55 on Windows. With more recent builds it's a MOZ_CRASH only for debug builds.

* Any component shutdown logic will not be performed. It means that we can not guarantee that eg sessionrestore is able to save the session, or places to store the latest changes to bookmarks

* The exit code of the child process is not 0 but indicates that something was broken

Lets really sanely shutdown Firefox. See bug 1141335 which covers the flip for Marionette, whereby with marionette_driver we have the `in_app` flag, which most of our tests are using nowadays.

It's not that urgent right now, given that we do not have the restart capability yet. But it would still be good to have it soonish.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't understand this cloned bug. If it is about a test failure which appears, please use the bugfiler of Treeherder so a proper bug with a summary gets filed that makes it possible to star.

Comment 2

[Intermittent Failures Robot]

1 failures in 657 pushes (0.002 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1431058&startday=2018-01-15&endday=2018-01-21&tree=all