1401137 - Update hard-coded SUMO link to Safe Browsing page

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

In bug 1363051 and bug 1359289 we added hard-coded SUMO links because we were lacking an in-product URL. Once we hear back from Joni we should replace these with ones that were properly formatted with app.support.baseURL.

https://searchfox.org/mozilla-central/search?q=how-does-phishing-and-malware-protection-work&case=false&regexp=false&path=

Comment 1

[Joni Chan]

Hi Johann,

Here is the proper in-product URL: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/phishing-malware

Please let me know if that doesn't fix the issue.

Comment 2

[Johann Hofmann [:johannh]]

Thank you! Vedant, would you like to take this bug and update the URLs?

Comment 3

[Vedant Chakravadhanula(:vedantc98)]

Hey Johann, thanks, and sorry for not getting back sooner.
Yes, I'll update the link. 
Thanks again !

Comment 4

[Johann Hofmann [:johannh]]

Any update? :)

Feel free to unassign yourself if you don't have time right now or reach out to me on IRC if you need help.

Comment 5

[Vedant Chakravadhanula(:vedantc98)]

I've just finished working on this bug, I'll push a patch and add you for review now.

Comment 6

[Vedant Chakravadhanula(:vedantc98)]

Attachment: Bug 1401137 - Updated hard-coded SUMO link to the safe browsing page.

The link to the phishin-malware support site was hard-coded in bug 1363051 and bug 1359289. The links have been built through the urlFormatter.

Review commit: https://reviewboard.mozilla.org/r/192410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192410/

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 8921383 [details]
Bug 1401137 - Updated hard-coded SUMO link to the safe browsing page.

https://reviewboard.mozilla.org/r/192410/#review197558

Looks great, thank you!

Comment 8

[Johann Hofmann [:johannh]]

Oh, this never got checked in, ha! Let me do that for you...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daea037cd968
Updated hard-coded SUMO link to the safe browsing page. r=johannh

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/daea037cd968