59 bytes, text/x-review-board-request
In bug 1363051 and bug 1359289 we added hard-coded SUMO links because we were lacking an in-product URL. Once we hear back from Joni we should replace these with ones that were properly formatted with app.support.baseURL. https://searchfox.org/mozilla-central/search?q=how-does-phishing-and-malware-protection-work&case=false®exp=false&path=
Hi Johann, Here is the proper in-product URL: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/phishing-malware Please let me know if that doesn't fix the issue.
Thank you! Vedant, would you like to take this bug and update the URLs?
Hey Johann, thanks, and sorry for not getting back sooner. Yes, I'll update the link. Thanks again !
Assignee: nobody → vedantc98
Status: NEW → ASSIGNED
Any update? :) Feel free to unassign yourself if you don't have time right now or reach out to me on IRC if you need help.
I've just finished working on this bug, I'll push a patch and add you for review now.
Comment on attachment 8921383 [details] Bug 1401137 - Updated hard-coded SUMO link to the safe browsing page. https://reviewboard.mozilla.org/r/192410/#review197558 Looks great, thank you!
Attachment #8921383 - Flags: review?(jhofmann) → review+
Oh, this never got checked in, ha! Let me do that for you...
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/daea037cd968 Updated hard-coded SUMO link to the safe browsing page. r=johannh
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.