1401232 - Sidebar not reopened when upgrading from build before bug 1391280 to build after bug 1391280

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[:Gijs (out for now; he/him)]

STR:

1. clean profile on build from Sept 13 or earlier
2. open bookmarks sidebar
3. close firefox
4. run build with current nightly

ER:

bookmarks sidebar is open

AR:

bookmarks sidebar is not open


We could potentially fix this with a UI migration in nsBrowserGlue.js (I think). I'm undecided as to whether that's worth the effort. It would also disrupt nightly users in that it would reopen a closed sidebar for them.

Brian, thoughts?

Comment 1

[Brian Grinstead [:bgrins]]

I'd prioritize getting it right for release users over disrupting Nightly users **if** we could come up with a simple and low-risk migration. Is the solution here basically setting "checked" to true in the xul store if "sidebarcommand" is non-empty, or is it more complicated than that?

Comment 2

[:Gijs (out for now; he/him)]

(In reply to Brian Grinstead [:bgrins] from comment #1)
> Is the
> solution here basically setting "checked" to true in the xul store if
> "sidebarcommand" is non-empty, or is it more complicated than that?

I believe that's what it would take, yes, but I have not yet tried it.

Comment 3

[:Gijs (out for now; he/him)]

I'll come up with a patch tomorrow.

Comment 4

[:Gijs (out for now; he/him)]

Attachment: Bug 1401232 - ensure sidebar persists correctly on update,

Review commit: https://reviewboard.mozilla.org/r/181732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181732/

Comment 5

[:Gijs (out for now; he/him)]

Note to self: need to rebase around bug 1388422 which is also adding a UI migration.

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8910241 [details]
Bug 1401232 - ensure sidebar persists correctly on update,

https://reviewboard.mozilla.org/r/181732/#review187110

I've tested this in three ways (the nightly I was using is from 09-08-2017)

1) Make a profile on nightly. Run the same profile with this patch applied = sidebar isn't opened
2) Make a profile on nightly and open then close the bookmarks sidebar. Run the same profile with this patch applied = bookmarks sidebar isn't opened
3) Make a profile on nightly and open bookmarks sidebar.  Run the same profile with this patch applied = bookmarks sidebar is opened

These all seem right to me and it makes sense, since there shouldn't be anything in the store for (1), and we did set the sidebarcommand to an empty string after closing before so the call to `xulStore.getValue` should be falsy for (2).

Comment 7

[:Gijs (out for now; he/him)]

Comment on attachment 8910241 [details]
Bug 1401232 - ensure sidebar persists correctly on update,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181732/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39b1badf8930
ensure sidebar persists correctly on update, r=bgrins

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/39b1badf8930

Comment 10

[Emil Ghitta, QA [:emilghitta]]

I have verified that the issue mentioned in comment 0 is not reproducible using Firefox 57.0b9 (Build Id:20171016185129) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.