Closed Bug 1401272 Opened 8 years ago Closed 6 years ago

Use MySQL Strict Mode (django_mysql.W001)

Categories

(developer.mozilla.org Graveyard :: General, enhancement, P2)

All
Other
enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jwhitlock, Assigned: jwhitlock)

References

Details

(Keywords: in-triage, Whiteboard: [specification][type:bug][points:3])

What did you do? ================ Ran a command (./manage.py make_sitemaps) with warnings enabled. What happened? ============== System check identified some issues: ?: (django_mysql.W001) MySQL Strict Mode is not set for database connection 'default' HINT: MySQL's Strict Mode fixes many data integrity problems in MySQL, such as data truncation upon insertion, by escalating warnings into errors. It is strongly recommended you activate it. See: http://django-mysql.readthedocs.org/en/latest/checks.html#django-mysql-w001-strict-mode What should have happened? ========================== No warnings should have been identified. Is there anything else we should know? ====================================== More details are at: http://django-mysql.readthedocs.org/en/latest/checks.html#django-mysql-w001-strict-mode Enabling this feature may expose bugs in Kuma. Some may be detected by tests, and some detected at runtime. It should be enabled when there is time to rapidly fix the exposed bugs.
Keywords: in-triage
I thought I opened a more recent bug for this, but it is the original. Here's my strategy: 1. Enable in development environment for a week, fix any issues. 2. Enable in staging, test 3. Enable in production
Priority: -- → P2
Summary: Use MySQL sql_mode=STRICT_TRANS_TABLES → Use MySQL Strict Mode (django_mysql.W001)
Whiteboard: [specification][type:bug] → [specification][type:bug][points:3]
Depends on: 1525165
Blocks: 1525165
No longer depends on: 1525165

Deployed to staging and production. No integrity issues found.

Assignee: nobody → jwhitlock
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.