Open Bug 1401319 Opened 2 years ago Updated 2 years ago

spidermonkey tests fail on mips64el architecture

Categories

(Core :: JavaScript Engine, defect, P5)

52 Branch
defect

Tracking

()

ASSIGNED
Tracking Status
firefox57 --- fix-optional

People

(Reporter: jbicha, Assigned: sfink, NeedInfo)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170914154903

Steps to reproduce:

This is a follow up from bug 1357593. When we packaged SpiderMonkey/mozjs52 for Debian, we discovered that mips64el should also be exempted from a few tests like other 64-bit architectures.


Actual results:

https://buildd.debian.org/status/fetch.php?pkg=mozjs52&arch=mips64el&ver=52.3.1-4&stamp=1504676727

Excerpts:
TEST-UNEXPECTED-FAIL | js1_5/Array/regress-157652.js | (args: "") | (TIMEOUT)
TEST-UNEXPECTED-FAIL | js1_5/Regress/regress-422348.js | (args: "") | (TIMEOUT)
## ecma_6/Array/for_of_1.js: rc = 3, run time = 0.329201
ecma_6/Array/for_of_1.js:100:5 Error: Assertion failed: got 156, expected 300
Stack:
  TestChangeArrayPrototype@ecma_6/Array/for_of_1.js:100:5
  @ecma_6/Array/for_of_1.js:102:1
TEST-UNEXPECTED-FAIL | ecma_6/Array/for_of_1.js | (args: "")


Expected results:

I am attaching a patch to fix the first 2 test failures since that's just a modification of the previously accepted patch. Do you want me to file a separate bug for the third failure?
Attachment #8909961 - Flags: review?(sphink)
I'm really not feeling good about enumerating every possible 64-bit platform. And when I looked up what xulRuntime actually is, I found that it has an is64Bit accessor. So let's use that instead.
Attachment #8910013 - Flags: review?(jcoppeard)
Assignee: nobody → sphink
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8909961 [details] [diff] [review]
0001-tests-skip-a-couple-tests-on-mips64.patch

Review of attachment 8909961 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is fine, but I'd rather the 64-bit test say what it means. So I'll do the plumbing necessary.
Attachment #8909961 - Flags: review?(sphink)
(In reply to Jeremy Bicha from comment #0)
> Expected results:
> 
> I am attaching a patch to fix the first 2 test failures since that's just a
> modification of the previously accepted patch. Do you want me to file a
> separate bug for the third failure?

Yes, that third one should have its own bug. Thanks!
Attachment #8910013 - Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/699842251977
Implement xulRuntime.is64Bit for manifest tests, r=jonco
Backed out for spidermonkey arm bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/440965fa9a236c5d4ac69c84c6080a4be75fc0ab

A recent push with the failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=16f7779bc325484892766b270986f2bbaacbe2bc&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=retry&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=132254310&repo=mozilla-inbound

[task 2017-09-20T16:45:33.774Z] TEST-PASS | testAssemblerBuffer_BufferOffset | ok
[task 2017-09-20T16:45:33.774Z] 
[task 2017-09-20T16:45:33.774Z] Passed: ran 277 tests.
[task 2017-09-20T16:45:33.786Z] make -C js/src check-jstests
[task 2017-09-20T16:45:33.897Z] make[1]: Entering directory '/builds/worker/workspace/build/src/obj-spider/js/src'
[task 2017-09-20T16:45:33.897Z] /builds/worker/workspace/build/src/obj-spider/_virtualenv/bin/python -u /builds/worker/workspace/build/src/js/src/tests/jstests.py \
[task 2017-09-20T16:45:33.897Z] 	--no-progress --format=automation --timeout 300 \
[task 2017-09-20T16:45:33.897Z] 	 \
[task 2017-09-20T16:45:33.897Z] 	../../dist/bin/js
[task 2017-09-20T16:45:33.948Z] Traceback (most recent call last):
[task 2017-09-20T16:45:33.948Z]   File "/builds/worker/workspace/build/src/js/src/tests/jstests.py", line 393, in <module>
[task 2017-09-20T16:45:33.948Z]     sys.exit(main())
[task 2017-09-20T16:45:33.948Z]   File "/builds/worker/workspace/build/src/js/src/tests/jstests.py", line 355, in main
[task 2017-09-20T16:45:33.948Z]     test_count, test_gen = load_tests(options, requested_paths, excluded_paths)
[task 2017-09-20T16:45:33.948Z]   File "/builds/worker/workspace/build/src/js/src/tests/jstests.py", line 268, in load_tests
[task 2017-09-20T16:45:33.948Z]     xul_info = manifest.XULInfo.create(options.js_shell)
[task 2017-09-20T16:45:33.948Z]   File "/builds/worker/workspace/build/src/js/src/tests/lib/manifest.py", line 84, in create
[task 2017-09-20T16:45:33.949Z]     return cls(**kw)
[task 2017-09-20T16:45:33.949Z] TypeError: __init__() takes exactly 5 arguments (4 given)
[task 2017-09-20T16:45:33.951Z] Makefile:82: recipe for target 'check-jstests' failed
Flags: needinfo?(sphink)
Priority: -- → P5
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86d7b2f346f0
Implement xulRuntime.is64Bit for manifest tests, r=jonco
Backed out for running and failing modified tests:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c7a64044f5688baf96ad28736cc4be57d6036d0

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c0e228638fe4bce3321c16a3ab812beb7275556c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=133185614&repo=mozilla-inbound

[task 2017-09-25T20:33:40.383Z] 20:33:40     INFO - REFTEST TEST-START | file:///builds/worker/workspace/build/tests/jsreftest/tests/jsreftest.html?test=js1_5/Array/regress-157652.js
[task 2017-09-25T20:33:40.384Z] 20:33:40     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/jsreftest/tests/jsreftest.html?test=js1_5/Array/regress-157652.js | 2426 / 10699 (22%)
[task 2017-09-25T20:33:40.414Z] 20:33:40     INFO - TEST-INFO | BUGNUMBER: 157652
[task 2017-09-25T20:33:40.418Z] 20:33:40     INFO - TEST-INFO | STATUS: Testing that Array.sort() doesn't crash on very large arrays
[task 2017-09-25T20:33:40.419Z] 20:33:40     INFO - TEST-INFO | --- NOTE: IN THIS TESTCASE, WE EXPECT EXIT CODE 0 ---
[task 2017-09-25T20:33:40.420Z] 20:33:40     INFO - TEST-INFO | --- NOTE: IN THIS TESTCASE, WE EXPECT EXIT CODE 5 ---
[task 2017-09-25T20:33:40.440Z] 20:33:40     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/jsreftest/tests/jsreftest.html?test=js1_5/Array/regress-157652.js | Testing that Array.sort() doesn't crash on very large arrays Expected value 'InternalError: allocation size overflow', Actual value 'out of memory'  item 1
[task 2017-09-25T20:33:40.443Z] 20:33:40     INFO - REFTEST TEST-END | file:///builds/worker/workspace/build/tests/jsreftest/tests/jsreftest.html?test=js1_5/Array/regress-157652.js
You need to log in before you can comment on or make changes to this bug.