1401447 - 3d animated CSS transforms do not work correctly in WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Asif Youssuff]

Attachment: webrender vs standard nightly.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170919220202

Steps to reproduce:

Enable WebRender with steps:

    turn off layers.async-pan-zoom.enabled
    turn on gfx.webrender.enabled
    turn on gfx.webrendest.enabled
    turn on gfx.webrender.layers-free
    add and turn on gfx.webrender.blob-images
    if you are on Linux, turn on layers.acceleration.force-enabled

Navigate to: https://codepen.io/thebabydino/pen/YrqVXZ


Actual results:

The shapes in the rendered testcase are not 3d blocks, but just the surface of the blocks. 


Expected results:

Same rendering as without WebRender enabled. 

See video (WR on left, latest Nightly on right).

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

This is enabling some of the non-defaults (no APZ and acceleration), but with the other ones, it's a blocker for nightly.

Comment 2

[Darkspirit]

non-WR: broken? (it looks more like a wall and not a cube)
WR: fixed, perf could be better
Chromium: good

mozregression --find-fix --bad 2017-12-01 --good 2018-01-10 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrendest.enabled:true gfx.webrender.layers-free:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://codepen.io/thebabydino/pen/YrqVXZ"
> 17:36.15 INFO: First good revision: 8ccb0e9d9bbeeed7d7e4474849debd7d21b65971
> 17:36.15 INFO: Last bad revision: c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4
> 17:36.15 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4&tochange=8ccb0e9d9bbeeed7d7e4474849debd7d21b65971

Fixed by:
> da9b75fc0866	Kartikaya Gupta — Bug 1426116 - Update webrender to commit a422f907be948b92bf5c7003a01f7744391a795e. r=jrmuizel

-----

> WR @ 1142dfc557c319119a5117450718c5b67a93cb9f
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=57823e03a9dfbf2184311b6c25a68268959336aa
gone

> WR @ afaa8bb6a9f33f498882225b5f5a433b5d993616
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=3671b6b97ada77219651965f509e455bdbdb1e13
gone

> WR @ 45dc6a3a0f18c783714e9b4107ef43876daf5b97
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=cba115d8b3cc01cb6c2de6787631cb50ed0df5c5
gone

> WR @ 22a3390754b0ed77bcbe60af55b96ccb1d6d68b8
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e31657c5e8895405136ba969db48469a8fe950f
gone

> WR @ 7340ae7ea75af331392c6fa489e2e562b25f2372
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d37dc87ce7b8c53bc61bb39869eb73c63e439e6
gone

> WR @ 3db4c461b2125bbd995ef4c370d006042f66e3de
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6ab230bfe667079ecded0cfb4e7c3ccd99c1dd6
gone

> WR @ 3c71e4c0944c1c04d7a21169fe24895dfa5d3d41
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a64d2fba6ee70fd9e387626862b80ae032831d
gone

> WR @ ee85aebd51d7f94bdd5c634dcad766b4ef09a8e9
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=93c140660ca9f7d9a98f86c9f4a90dfed9f39684
gone

> WR @ 58652a2bc8f26c8c2245cac42dc6c53ee591dfe2
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c77924e14b9efa85984228218c19681c7269e47
gone

> WR @ 4e6310e86b38511ae690296367e31186c6e059f1, with serde fixup on the gecko side
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9a2e235993f2f520b7ae007199458fdf4a71138
gone

> WR @ a21197eb1e427730c7bec6eec07bc6cc352d452e, with the above mentioned reftests flipped to passing
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3ec971f55a01196b05242b7d21c037b386cc2f7
gone

> WR @ a422f907be948b92bf5c7003a01f7744391a795e
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=13b4882f8ac1c1f43c87a286119ca6b08c59fde0
mozregression --repo try --launch 13b4882f8ac1c1f43c87a286119ca6b08c59fde0 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrendest.enabled:true gfx.webrender.layers-free:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://codepen.io/thebabydino/pen/YrqVXZ"
-> good

Fix range:
https://github.com/servo/webrender/compare/1142dfc557c319119a5117450718c5b67a93cb9f...a422f907be948b92bf5c7003a01f7744391a795e