Closed Bug 1426116 Opened 6 years ago Closed 6 years ago

Update webrender to a422f907be948b92bf5c7003a01f7744391a795e

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Product:
Core
Component:
Graphics: WebRender
Version:
59 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [wr-reserve] [gfx-noted])

Attachments

(7 files)

Bug 1426116 - Update webrender to commit a422f907be948b92bf5c7003a01f7744391a795e.
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
Bug 1426116 - Update for changes in WR PR 2251.
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
Bug 1426116 - Update Cargo lockfiles and re-vendor rust dependencies.
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
Bug 1426116 - Regenerate FFI header and remove RGB8 references to go with changes in WR PR 2260.
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
Bug 1426116 - Update reftest results for changes from WR PR 2200.
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
Bug 1426116 - Update reftest results from WR PR 2262.
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
Bug 1426116 - Update the reftest annotations after we fixed the webrender box shadow problem (WR PR 2261).
59 bytes, text/x-review-board-request
kats
: review+
Details 
+++ This bug was initially created as a clone of Bug #1424631 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
WR @ 1142dfc557c319119a5117450718c5b67a93cb9f

https://treeherder.mozilla.org/#/jobs?repo=try&revision=57823e03a9dfbf2184311b6c25a68268959336aa
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7898144dfd3d44a645e4ae276f5cdf9b83372ba4

Green except for a couple of intermittents. The R3 orange is expected and was already fixed in bug 1424631, will get picked up when that merges to m-c.

WR @ afaa8bb6a9f33f498882225b5f5a433b5d993616

https://treeherder.mozilla.org/#/jobs?repo=try&revision=612158d78d64bedcb91f771ff7a708c03de21971
https://treeherder.mozilla.org/#/jobs?repo=try&revision=070705b9bb26d797cda0e5065e53816e42994d60

Green, with a WR-specific intermittent that I haven't seen before. Filed bug 1426336 for it.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #6)
> WR @ 3db4c461b2125bbd995ef4c370d006042f66e3de
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=159021ac746251c647ff249c20c879aa978ec78c
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=a837bbb9d750c94e9217280e2c554bb604d18825
> 
> R6 and R8 unexpected-pass, from servo/webrender#2200

This also had a talos-g1 failure which seems like a new permafail. There's a crash in the log:

thread 'WRRenderBackend#2' panicked at 'index out of bounds: the len is 95 but the index is 114', /builds/worker/workspace/build/src/gfx/webrender/src/tiling.rs:357:24
stack backtrace:
   0:     0x7f869fb1d5a3 - std::sys::imp::backtrace::tracing::imp::unwind_backtrace::h8ed7485deb8ab958
   1:     0x7f869fb1bc3c - std::panicking::default_hook::{{closure}}::h0088fe51b67c687c
   2:     0x7f869fb1b66d - std::panicking::default_hook::hf425c768c5ffbbad
   3:     0x7f869fb1b180 - std::panicking::rust_panic_with_hook::h25b934bb4484e9e0
   4:     0x7f869fb1b02b - std::panicking::begin_panic::h59483e27e93d7bc6
   5:     0x7f869fb1afb9 - std::panicking::begin_panic_fmt::h5f221297e8a3dbdb
   6:     0x7f869fb2a552 - core::panicking::panic_fmt::h4d1ab9bae1f32475
   7:     0x7f869fb2a0c8 - core::panicking::panic_bounds_check::h00738207f5476c9a
   8:     0x7f869f794963 - webrender::tiling::add_to_batch::h7b2798112eb6277f
   9:     0x7f869f7906e7 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h96617c0b83ce7e61
  10:     0x7f869f792949 - webrender::tiling::add_to_batch::h7b2798112eb6277f
  11:     0x7f869f7906e7 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h96617c0b83ce7e61
  12:     0x7f869f792949 - webrender::tiling::add_to_batch::h7b2798112eb6277f
  13:     0x7f869f7906e7 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h96617c0b83ce7e61
  14:     0x7f869f792949 - webrender::tiling::add_to_batch::h7b2798112eb6277f
  15:     0x7f869f7906e7 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h96617c0b83ce7e61
  16:     0x7f869f792949 - webrender::tiling::add_to_batch::h7b2798112eb6277f
  17:     0x7f869f7906e7 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h96617c0b83ce7e61
  18:     0x7f869f78c89e - <webrender::tiling::ColorRenderTarget as webrender::tiling::RenderTarget>::build::h59ee348c847e01f9
  19:     0x7f869f77d95c - webrender::render_backend::Document::render::h0b03f37d044c5133
  20:     0x7f869f76fda0 - webrender::render_backend::RenderBackend::process_document::h230f39c50c061181
  21:     0x7f869f7618fe - webrender::render_backend::RenderBackend::run::hfcff2106d02ba5af
  22:     0x7f869f75f2c7 - std::sys_common::backtrace::__rust_begin_short_backtrace::h4fd2c39ea14e04c8
  23:     0x7f869f75e8d6 - <F as alloc::boxed::FnBox<A>>::call_box::h5b4d88bc74f2775c
  24:     0x7f869fb27a23 - std::sys::imp::thread::Thread::new::thread_start::hbaf1b5aa1ca8e3ea
  25:     0x7f86a98c8e99 - start_thread
  26:     0x7f86a89d838c - clone
Redirecting call to abort() to mozalloc_abort
(skipped a bunch more at 3db4c461b2125bbd995ef4c370d006042f66e3de)

WR @ 3c71e4c0944c1c04d7a21169fe24895dfa5d3d41

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a64d2fba6ee70fd9e387626862b80ae032831d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fefd7d05785678ee6125f465792272d9076e80b

Looks green. A couple of oranges but I suspect they are intermittents. I retriggered to verify.
Blocks: 1394568
WR @ ee85aebd51d7f94bdd5c634dcad766b4ef09a8e9

https://treeherder.mozilla.org/#/jobs?repo=try&revision=93c140660ca9f7d9a98f86c9f4a90dfed9f39684
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e80fea434469d77c52faf66e29d8ca46f2a264fb

Green

WR @ 58652a2bc8f26c8c2245cac42dc6c53ee591dfe2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c77924e14b9efa85984228218c19681c7269e47
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1a5f2e6fc138acdbe14cde6d21f2ae04d0af181
https://treeherder.mozilla.org/#/jobs?repo=try&revision=77f704ace3f86af5c75af19c4d208ec3c6dc26ba
https://treeherder.mozilla.org/#/jobs?repo=try&revision=acd423f16cc629477ba56f871d2bdffb94176135

Green with intermittents

WR @ 4e6310e86b38511ae690296367e31186c6e059f1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3799a5ffaa7cd4599903e1b97add4944b0e9eca
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b82fd328c5fa636a040113b1d8b05304b2e63ab
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca74bf06e365529f0b382bb9d456c4c28f87e586
https://treeherder.mozilla.org/#/jobs?repo=try&revision=543bce3c4098fff2d5e74c69c9794f91d3d6d2cd

Bustage, from servo/webrender#2251 (serde stuff)

WR @ 4e6310e86b38511ae690296367e31186c6e059f1, with serde fixup on the gecko side

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9a2e235993f2f520b7ae007199458fdf4a71138
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e01643df414eef5090783960924a8cf9a17b0e41
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed5ed4fc4ca449a6c901d74d06e8ffc8a7389637
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2919a80045c7cab0e64b3cf135e8338875794394

Green

WR @ 1705cb1da38bcf8fdfbbd72c5714e9a5c41d9c7a (now with cbindgen 0.3.3, to match m-c)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f41082fedc6c81b69b804edf39566a1bb3505ddb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e99f97c2272e0aa89f26d03827e8e290d9c66ca
https://treeherder.mozilla.org/#/jobs?repo=try&revision=89e16011a820d34d975265d2664ca23ca31003f2
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c8f863631f41a17cf0b716b17c7f710d00ec39b

Bustage, from servo/webrender#2260
WR @ a21197eb1e427730c7bec6eec07bc6cc352d452e, with RGB8 fixup

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0bf52962c187103c0df91f6e3dc16cbe282b8479
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6279ceadb72cc37942cefc8938903b8cf3393080

R3 and R5 unexpected-passes. Fix range is:

*   a21197eb Auto merge of #2264 - stjepang:update-crossbeam, r=emilio
|\
| * 9b9fdd30 Update crossbeam to 0.2.12
|/
*   1705cb1d Auto merge of #2260 - glennw:no-rgb8, r=kvark
|\
| * fe9c2d8a Remove RG8 and RGB8 support from texture cache.
* e431fed6 Auto merge of #2262 - lsalzman:italics-hinting-fix, r=jrmuizel
* 229913ad fix vertical offset of FreeType outline glyphs
* 19294042 disable FreeType hinting if font transform is not axis-aligned

so I'm guessing this is from servo/webrender#2262
(In reply to Kartikaya Gupta (away until jan08) (email:kats@mozilla.com) from comment #11)
> WR @ a21197eb1e427730c7bec6eec07bc6cc352d452e, with RGB8 fixup
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=0bf52962c187103c0df91f6e3dc16cbe282b8479
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=6279ceadb72cc37942cefc8938903b8cf3393080
> 
> R3 and R5 unexpected-passes. Fix range is:
> 
> *   a21197eb Auto merge of #2264 - stjepang:update-crossbeam, r=emilio
> |\
> | * 9b9fdd30 Update crossbeam to 0.2.12
> |/
> *   1705cb1d Auto merge of #2260 - glennw:no-rgb8, r=kvark
> |\
> | * fe9c2d8a Remove RG8 and RGB8 support from texture cache.
> * e431fed6 Auto merge of #2262 - lsalzman:italics-hinting-fix, r=jrmuizel
> * 229913ad fix vertical offset of FreeType outline glyphs
> * 19294042 disable FreeType hinting if font transform is not axis-aligned
> 
> so I'm guessing this is from servo/webrender#2262

Yes, that's addressed in my patch in bug 1394568. Still waiting for Gankro to review. But you can just mark those as passing as a quick spot fix.
Blocks: 1423696
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to a422f907be948b92bf5c7003a01f7744391a795e
Version: unspecified → 59 Branch
Comment on attachment 8940719 [details]
Bug 1426116 - Update the reftest annotations after we fixed the webrender box shadow problem (WR PR 2261).

https://reviewboard.mozilla.org/r/210990/#review216692

This is ethan's patch from bug 1423696, so carrying r+ from there
Attachment #8940719 - Flags: review?(bugmail) → review+
Comment on attachment 8940714 [details]
Bug 1426116 - Update for changes in WR PR 2251.

https://reviewboard.mozilla.org/r/210980/#review216820
Attachment #8940714 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8940715 [details]
Bug 1426116 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/210982/#review216822
Attachment #8940715 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8940716 [details]
Bug 1426116 - Regenerate FFI header and remove RGB8 references to go with changes in WR PR 2260.

https://reviewboard.mozilla.org/r/210984/#review216824
Attachment #8940716 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8940717 [details]
Bug 1426116 - Update reftest results for changes from WR PR 2200.

https://reviewboard.mozilla.org/r/210986/#review216826
Attachment #8940717 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8940718 [details]
Bug 1426116 - Update reftest results from WR PR 2262.

https://reviewboard.mozilla.org/r/210988/#review216828
Attachment #8940718 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8940713 [details]
Bug 1426116 - Update webrender to commit a422f907be948b92bf5c7003a01f7744391a795e.

https://reviewboard.mozilla.org/r/210978/#review216818
Attachment #8940713 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da9b75fc0866
Update webrender to commit a422f907be948b92bf5c7003a01f7744391a795e. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/7855af69185d
Update for changes in WR PR 2251. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/e37afa9046ed
Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/39f6c70f793e
Regenerate FFI header and remove RGB8 references to go with changes in WR PR 2260. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a7f7b7350673
Update reftest results for changes from WR PR 2200. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/ca6f08cff784
Update reftest results from WR PR 2262. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8ccb0e9d9bbe
Update the reftest annotations after we fixed the webrender box shadow problem (WR PR 2261). r=kats
No longer blocks: 1420754
No longer blocks: 1421526
No longer blocks: 1422455
Depends on: 1429235
Depends on: 1429428
Depends on: 1430063
Blocks: 1428654
Depends on: 1431575
Blocks: 1409564
Blocks: 1401447
Depends on: 1445789
Blocks: 1449904
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: