1401609 - Some canvases on perf-html.io don't update

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Markus Stange [:mstange]]

Steps to reproduce:
 1. Enable webrender, webrendest, layers-free and blob images.
 2. Open this profile: https://perfht.ml/2jM7NEH
 3. Create a selection in the upper part of the page by dragging the mouse over the graphs.
 4. "Zoom" into that selection by clicking the magnifying glass.

The markers and the graphs should now be zoomed in to show only the selected time range. However, only the "marker" canvases update; the "stack graph" canvases still show the pre-zoom state.

Comment 1

[Markus Stange [:mstange]]

This bug was not fixed by bug 1405481.

Comment 2

[Markus Stange [:mstange]]

Attachment: testcase

Click the canvas. Every time you click, the canvas should toggle between green and blue. With WebRender it seems to stay green forever.

Whenever the canvas's internal surface gets reset because the canvas width or height gets changed, with WebRender we seem to fail to adopt the new surface. Instead, the original surface keeps being displayed forever.

Sotaro, would you like to look into this?

Comment 3

[Sotaro Ikeda [:sotaro]]

Thanks, I am going to look into it.

Comment 4

[Sotaro Ikeda [:sotaro]]

Non-WebRender case, CanvasRenderingContext2D recreates CanvasLayer and CanvasRenderer when after CanvasRenderingContext2D::ClearTarget() is called. But WebRender case, CanvasRenderer is not re-created, but CanvasRenderingContext2D assumes it.

Comment 5

[Sotaro Ikeda [:sotaro]]

CanvasRenderingContext2D::SetDimensions() calls CanvasRenderingContext2D::ClearTarget(). Then CanvasRenderingContext2D creates new BufferProvider for rendering, but WebRenderCanvasData(CanvasRenderer) continues to use old obsoleted BufferProvider.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 1 - Add UpdateWebRenderCanvasData() to handle CanvasRenderer re-creation

Comment 7

[Sotaro Ikeda [:sotaro]]

attachment 8921771 [details] [diff] [review] was created by referencing GetCanvasLayer().

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - Change reftest.list

Comment 9

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f63c0ba05acd8df7667b230df697d5a8227d147a

Comment 10

[Sotaro Ikeda [:sotaro]]

jrmuizel, can you also review attachment 8921798 [details] [diff] [review]? Thanks!

Comment 11

[Sotaro Ikeda [:sotaro]]

:mstange, thanks!

Comment 12

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8064942017bd422b28e87c63e16118d163d6dca2

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cb78523022e
Add UpdateWebRenderCanvasData() to handle CanvasRenderer re-creation r=jrmuizel,mstange

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8cb78523022e

Comment 15

[Darkspirit]

(In reply to Markus Stange [:mstange] from comment #2)
> Created attachment 8920661 [details]
> testcase
> 
> Click the canvas. Every time you click, the canvas should toggle between green and blue. With WebRender it seems to stay green forever.

Verified fixed in Nightly 58 x64 20171029220112 de_DE @ Debian Testing (Radeon RX480). Thank you!