Closed Bug 1401620 Opened 2 years ago Closed 2 years ago

Snap: Use Canonical partner config instead of a duplicated one


(Release Engineering :: Release Automation: Other, enhancement)

Not set


(firefox56 fixed, firefox57 fixed, firefox58 fixed)

Tracking Status
firefox56 --- fixed
firefox57 --- fixed
firefox58 --- fixed


(Reporter: jlorenzo, Assigned: jlorenzo)




(3 files)

At the moment, distribution.ini is stored in-tree at [1]. We may eventually generate non-Ubuntu snaps. However, the first releases will be Ubuntu-based. Then, we must use the config defined at [2]. This public repo should be cloned and replace the files copied at [3]

I would say we should merge them, because the one we use has special config variables and they are not the same with the repack.

app.update.enabled=false -> to disable automatic update checks (they are useless in snap). Ideally we should disable the updater all together, but that requires a full rebuild

intl.locale.matchOS=true -> The snap package comes with multiple locales. There is no UI to select the desired locale, so we have to use the LANG env variable to detect it. -> Not sure if this is required, but IIRC something didn't work to set the default browser from snap.
Thanks for the context, Rail!

:mkaply planned to modify what's in the partner repo so that it matches Canonical's. I just realized he's waiting on us to get that landed. I'm on it.
Assignee: nobody → jlorenzo
Keywords: good-first-bug
Attachment #8910658 - Flags: review?(mozilla)
Depends on: 1390071
Attached file releasetasks PR
I pushed a new image in order to have git in it. I tested that image manually at [1]. I tweaked the task definition a little bit in order to use that I'm going to upload. I stripped out the upload part, for this test.

Attachment #8910722 - Flags: review?(rail)
Comment on attachment 8910723 [details]
Bug 1401620 - Snap: Use Canonical partner config instead of a duplicated one
Attachment #8910723 - Flags: review?(rail) → review+
Attachment #8910722 - Flags: review?(rail) → review+
Pushed by
Snap: Use Canonical partner config instead of a duplicated one r=rail
Closed: 2 years ago
Resolution: --- → FIXED

+ git clone /home/worker/workspace/partner_config
./ line 31: git: command not found
Resolution: FIXED → ---
Looks like we didn't pull Done on bm85. Hopefully this fixes the issue.
Attachment #8910658 - Flags: review?(mozilla)
Was fixed in 57.0b4: Thanks Rail for pulling the latest changes!
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.