1401620 - Snap: Use Canonical partner config instead of a duplicated one

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Johan Lorenzo [:jlorenzo]]

At the moment, distribution.ini is stored in-tree at [1]. We may eventually generate non-Ubuntu snaps. However, the first releases will be Ubuntu-based. Then, we must use the config defined at [2]. This public repo should be cloned and replace the files copied at [3]

[1] https://dxr.mozilla.org/mozilla-beta/source/taskcluster/docker/firefox-snap/distribution.ini
[2] https://github.com/mozilla-partners/canonical
[3] https://dxr.mozilla.org/mozilla-beta/rev/a0f805dbe65da9f2d2283912248ab6267f441004/taskcluster/docker/firefox-snap/runme.sh#30

Comment 1

[Rail Aliiev [:rail]]

I would say we should merge them, because the one we use has special config variables and they are not the same with the repack.

app.update.enabled=false -> to disable automatic update checks (they are useless in snap). Ideally we should disable the updater all together, but that requires a full rebuild

intl.locale.matchOS=true -> The snap package comes with multiple locales. There is no UI to select the desired locale, so we have to use the LANG env variable to detect it.


browser.shell.checkDefaultBrowser=false -> Not sure if this is required, but IIRC something didn't work to set the default browser from snap.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Thanks for the context, Rail!

:mkaply planned to modify what's in the partner repo so that it matches Canonical's. I just realized he's waiting on us to get that landed. I'm on it.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: mozilla-partners/canonical PR

Comment 4

[Johan Lorenzo [:jlorenzo]]

Attachment: releasetasks PR

I pushed a new image in order to have git in it. I tested that image manually at [1]. I tweaked the task definition a little bit in order to use runme.sh that I'm going to upload. I stripped out the upload part, for this test.

[1] https://tools.taskcluster.net/groups/OfrDPb7wSsi_WDUq3Rq-BQ/tasks/OfrDPb7wSsi_WDUq3Rq-BQ/details
[2] https://gist.githubusercontent.com/JohanLorenzo/226fde90d7aa5feeefc6948c913ebdc6/raw/2dc950db66e4c107d8625c067927a6a9adae1479/runme.sh

Comment 5

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1401620 - Snap: Use Canonical partner config instead of a duplicated one

Review commit: https://reviewboard.mozilla.org/r/182184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182184/

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 8910723 [details]
Bug 1401620 - Snap: Use Canonical partner config instead of a duplicated one

https://reviewboard.mozilla.org/r/182184/#review187536

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2a032f9e256
Snap: Use Canonical partner config instead of a duplicated one r=rail

Comment 8

[Johan Lorenzo [:jlorenzo]]

Patches landed:
* https://github.com/mozilla-partners/canonical/commit/9a364d8eaceaf6ff6956e55074579db60a1c0deb
* https://github.com/mozilla-releng/releasetasks/commit/7f11f8bd7d490e0bf2708babd789d67393bf5041
* https://hg.mozilla.org/releases/mozilla-beta/rev/3be11e46a4ce0d7d5861ef27a606a4d47290222b
* https://hg.mozilla.org/releases/mozilla-release/rev/a55bd7719defc14c5c2051feb6333d3fe1413167

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d2a032f9e256

Comment 10

[Rail Aliiev [:rail]]

https://mozilla-release-logs.s3.amazonaws.com/mozilla-beta/firefox-57.0b3/build1/mozilla-beta_snap_generation-all-BUF9YOBNQua_5RDfPHm_dA-0

+ git clone https://github.com/mozilla-partners/canonical.git /home/worker/workspace/partner_config
./runme.sh: line 31: git: command not found

Comment 11

[Rail Aliiev [:rail]]

Looks like we didn't pull https://github.com/mozilla-releng/releasetasks/pull/287/files. Done on bm85. Hopefully this fixes the issue.

Comment 12

[Johan Lorenzo [:jlorenzo]]

Was fixed in 57.0b4: https://tools.taskcluster.net/groups/deNL0h2DTy6JN_rrrUqY4w/tasks/YqPB7HIlS12NC4RGvkTtzw/details. Thanks Rail for pulling the latest changes!