Make 'print...' on linux/windows show the print preview again, but don't show the 'ctrl-p' shortcut for "normal" print

RESOLVED FIXED in Firefox 57

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Per discussion in bug 1387846 and slack, let's make the hamburger panel's print item go back to showing the print preview item, but don't show the print shortcut.
If print preview if more useful than print on linux/windows, shouldn't the ctrl-p shortcut stay but be modified to open print preview instead of print?
(In reply to Oriol Brufau [:Oriol] from comment #2)
> If print preview if more useful than print on linux/windows, shouldn't the
> ctrl-p shortcut stay but be modified to open print preview instead of print?

We'd break a lot of people's muscle memory and convention from other programs, so certainly not in this bug where we're addressing the immediate change from bug 1387846. It'd have much wider implications to actually change where the shortcut points. File a separate bug.
Comment on attachment 8910503 [details]
Bug 1401754 - print in the hamburger panel should open preview on Windows/Linux but not suggest its shortcut is ctrl-p,

https://reviewboard.mozilla.org/r/181918/#review187476

Reluctant r+. While this does adress an inconsistency, I'm not convinced that not exposing the shortcut key is a net win.
Attachment #8910503 - Flags: review?(dao+bmo) → review+
Assignee: nobody → gijskruitbosch+bugs
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/81c637ca25e6
print in the hamburger panel should open preview on Windows/Linux but not suggest its shortcut is ctrl-p, r=dao
https://hg.mozilla.org/mozilla-central/rev/81c637ca25e6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.