1401754 - Make 'print...' on linux/windows show the print preview again, but don't show the 'ctrl-p' shortcut for "normal" print

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (away/busy until Mar 10)]

Per discussion in bug 1387846 and slack, let's make the hamburger panel's print item go back to showing the print preview item, but don't show the print shortcut.

Comment 1

[:Gijs (away/busy until Mar 10)]

Attachment: Bug 1401754 - print in the hamburger panel should open preview on Windows/Linux but not suggest its shortcut is ctrl-p,

Review commit: https://reviewboard.mozilla.org/r/181918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181918/

Comment 2

[Oriol Brufau [:Oriol]]

If print preview if more useful than print on linux/windows, shouldn't the ctrl-p shortcut stay but be modified to open print preview instead of print?

Comment 3

[:Gijs (away/busy until Mar 10)]

(In reply to Oriol Brufau [:Oriol] from comment #2)
> If print preview if more useful than print on linux/windows, shouldn't the
> ctrl-p shortcut stay but be modified to open print preview instead of print?

We'd break a lot of people's muscle memory and convention from other programs, so certainly not in this bug where we're addressing the immediate change from bug 1387846. It'd have much wider implications to actually change where the shortcut points. File a separate bug.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8910503 [details]
Bug 1401754 - print in the hamburger panel should open preview on Windows/Linux but not suggest its shortcut is ctrl-p,

https://reviewboard.mozilla.org/r/181918/#review187476

Reluctant r+. While this does adress an inconsistency, I'm not convinced that not exposing the shortcut key is a net win.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81c637ca25e6
print in the hamburger panel should open preview on Windows/Linux but not suggest its shortcut is ctrl-p, r=dao

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/81c637ca25e6