1401924 - Theme transparency shows hidden icons

Status: RESOLVED DUPLICATE of bug 1387354

(Firefox :: Theme, defect)

Description

[Jonathan Kingston [:jkt] he/him]

Attachment: double-icons-theme.PNG

When changing a theme in Firefox extensions, if the colour set is semitransparent in Windows I can see icons underneath the normal close icons that I shouldn't be able to see.

The following code change here: https://github.com/jonathanKingston/containers-theme/commit/3220c77c6a87951cb232afb89e410699d0c1c4bd

Made the attached image issue, you can see that there is a shadow of other icons under the normal close, min, max icons.

Comment 1

[Johann Hofmann [:johannh]]

Interesting, could this be the cause of bug 1387354?

Comment 2

[Jonathan Kingston [:jkt] he/him]

Certainly could be yeah, I'm not sure how we render those icons but it looks liek we put ours over the top to cover native icons perhaps.

Comment 3

[Jonathan Kingston [:jkt] he/him]

titlebar-buttonbox is the buttons on top, the others appear to come from: titlebar-placeholder-on-TabsToolbar-for-captions-buttons

Comment 4

[Jonathan Kingston [:jkt] he/him]

Ok so it appears that titlebar-placeholder-on-TabsToolbar-for-captions-buttons covers these native buttons, perhaps we should prevent --toolbarbutton-active-background from being transparent for this element?

Perhaps even finding the right element to do background: var(--toolbarbutton-active-background), -moz-Dialog; on.