1401956 - Browser restart required after upgrading to the latest “Grammarly For Firefox” version

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation.gif

[Affected versions]:
Firefox 57.0a1 (20170920220431)
Firefox 56 RC (20170918210324)
Firefox 55.0.3 (20170824053622)

[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.12.3


[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install the following webextension version: https://addons.mozilla.org/firefox/downloads/file/668017/grammarly_for_firefox-8.769.994-an+fx.xpi?src=version-history
3.Go to Add-ons Manager -> Extensions and check for updates.
4.Reload the page after the new version is downloaded.
 
[Expected Results]:
The webextension is automatically updated to the latest version and there is no restart required.

[Actual Results]:
- A browser restart is required in order to complete the upgrade.
- See attached screencast.

Comment 1

[Andrew Swan [:aswan]]

This extension uses browser.runtime.onUpdateAvailable to defer the update.  From a quick glance at the code, I'm not sure what they're trying to achieve by deferring it, but there's no Firefox bug here.

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Problem is that Firefox need to be restarted, which is nearly like in legacy non e10s extension era. Now, every WebExtension, even old legacy extension, with e10s compatibility are not need to Firefox to be restarted, when extension was updated to newer version. So I think it's clearly the bug there.

Comment 3

[Andrew Swan [:aswan]]

I'm not sure what to add beyond comment 1.  A webextension can choose to defer updates until the next restart and that's what grammarly is doing.  I have no idea why grammarly chooses to do that, but feel free to ask the extension author.