Closed Bug 1402053 Opened 3 years ago Closed 3 years ago

Remove our obsolete implementation of Unicode normalization, now that we can use ICU on all platforms

Categories

(Core :: Internationalization, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(1 file)

Now that we have ICU available on all platforms, we can completely remove our obsolete implementation of normalization.
Comment on attachment 8910879 [details] [diff] [review]
Remove our obsolete implementation of Unicode normalization, now that we can use ICU on all platforms

Review of attachment 8910879 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm, splinter isn't showing this as nicely as I'd have liked: what I actually did was to "hg rm nsUnicodeNormalizer.cpp" and then "hg mv nsUnicodeNormalizer_ICU.cpp nsUnicodeNormalizer.cpp", but it doesn't indicate the rename, it just looks like an edit.
Comment on attachment 8910879 [details] [diff] [review]
Remove our obsolete implementation of Unicode normalization, now that we can use ICU on all platforms

Review of attachment 8910879 [details] [diff] [review]:
-----------------------------------------------------------------

We can remove nsIUnicodeNormalizer after resolving bug 1402048.  But since there is unused #include "nsIUnicodeNormalizer.h" in c-c, I will file a bug for c-c.
Attachment #8910879 - Flags: review?(m_kato) → review+
Blocks: 1402193
Blocks: 1292486
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/513b9e8f28e6
Remove our obsolete implementation of Unicode normalization, now that we can use ICU on all platforms. r=m_kato
https://hg.mozilla.org/mozilla-central/rev/513b9e8f28e6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.