1402192 - Top Sites drag and drop

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[anleck]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170921100141

Steps to reproduce:

Try to drag a Top Site to desired location
(Firefox 57, 58)


Actual results:

Nothing


Expected results:

Top Site should have repositioned - only pinned Sites should be locked in place

Comment 2

[Kevin Ernst]

For the benefit of anyone who found themselves here trying to find a way to reorder the tiles on the "new" New Tab page, there's a solution here[0], in the Mozilla support forum.

Basically, toggle about:config?filter=browser.newtabpage.activity-stream.enabled to "false", rearrange the tiles, then toggle back to "true". You might need to force-reload (Shift+Ctrl/⌘+R) the New Tab page to see the results.

[0] https://support.mozilla.org/en-US/questions/1178312#answer-1030416

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3902

Comment 5

[Ed Lee :Mardak]

Attachment: video of ce7650f PR3902

Aaron, given that we're close to 59 freeze, is the current PR's behavior acceptable to ship as is? In particular:

- the dragged item jumps back to its original spot when the drag position is not directly on top of a site (i.e., in the whitespace between sites)

- on drop, there's a flash of the original sites ordering before it updates

- the original site's position gets its meatball menu shown for the new site (even though the pointer is where the site was dropped)

Comment 6

[Ed Lee :Mardak]

Attachment: video of ce7650f PR3902

Comment 7

[Ed Lee :Mardak]

Attachment: video of 93b759f PR3902

Looks good!

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/313a951204c17c1c9a0b301dff3357d8e7c6d615
feat (topsites): Fix Bug 1402192 - Top Sites Drag n Drop

https://github.com/mozilla/activity-stream/commit/b946c01c7808b7e38dd511e521dddadaf3f5fe6a
Merge pull request #3902 from rlr/bug1402192/dragndrop

feat (topsites): Fix Bug 1402192 - Top Sites Drag n Drop

Comment 10

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7d9c675dabf5

Comment 11

[Md. Majedul islam]

I have reproduced this bug with Firefox nightly 58.0a1 (2017-09-21) on Windows 10, 64 Bit.

The Bug's fix is now verified on latest nightly 59.0a1 (2018-01-04).

Build ID       20180104100157
User Agent     Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Comment 12

[Mohammad Maruf Rahman]

I have successfully reproduced the bug with Nightly 58.0a1 (2017-09-21) on Ubuntu 12.04 LTS!

This bug's fix is Verified with latest Beta!

Build ID   : 20180209162511
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

[bugday-20180228]

Comment 13

[Catalin Sasca, Desktop Test Engineering [:csasca]]

I have reproduced this bug with Firefox Nightly 58.0a1 (2017-09-21) on Windows 10(x64).

The bug is no longer reproducible on Firefox 60.0a1 (2018-03-05), Firefox 59.0b14 and Firefox 60.0b1DevEd(20180302190033).

Tests were performed under Windows 10(x64), Ubuntu 16.04(x64) and macOS 10.12.6.