Closed Bug 1402192 Opened 7 years ago Closed 6 years ago

Top Sites drag and drop

Categories

(Firefox :: New Tab Page, defect, P2)

57 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 59
Iteration:
1.25
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- verified
firefox60 --- verified

People

(Reporter: anleck, Assigned: rrosario)

References

Details

(Keywords: nightly-community)

Attachments

(3 files, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170921100141

Steps to reproduce:

Try to drag a Top Site to desired location
(Firefox 57, 58)


Actual results:

Nothing


Expected results:

Top Site should have repositioned - only pinned Sites should be locked in place
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Component: Untriaged → Activity Streams: Newtab
Ever confirmed: true
Priority: -- → P2
For the benefit of anyone who found themselves here trying to find a way to reorder the tiles on the "new" New Tab page, there's a solution here[0], in the Mozilla support forum.

Basically, toggle about:config?filter=browser.newtabpage.activity-stream.enabled to "false", rearrange the tiles, then toggle back to "true". You might need to force-reload (Shift+Ctrl/⌘+R) the New Tab page to see the results.

[0] https://support.mozilla.org/en-US/questions/1178312#answer-1030416
Assignee: nobody → rrosario
Status: NEW → ASSIGNED
Iteration: --- → 1.25
Summary: Activity stream - Newtab - Unable to Drag and Drop (rearrange) Top Sites → Top Sites drag and drop
See Also: → 1422882
Blocks: 1403947
Attached video video of ce7650f PR3902 (obsolete) —
Aaron, given that we're close to 59 freeze, is the current PR's behavior acceptable to ship as is? In particular:

- the dragged item jumps back to its original spot when the drag position is not directly on top of a site (i.e., in the whitespace between sites)

- on drop, there's a flash of the original sites ordering before it updates

- the original site's position gets its meatball menu shown for the new site (even though the pointer is where the site was dropped)
Flags: needinfo?(abenson)
Attached video video of ce7650f PR3902
Attachment #8937571 - Attachment is obsolete: true
Attached video video of 93b759f PR3902
Looks good!
Flags: needinfo?(abenson)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1426774
Blocks: 1427360
Blocks: 1427361
Blocks: 1427359
Blocks: 1427358
I have reproduced this bug with Firefox nightly 58.0a1 (2017-09-21) on Windows 10, 64 Bit.

The Bug's fix is now verified on latest nightly 59.0a1 (2018-01-04).

Build ID       20180104100157
User Agent     Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [bugday-20180103]
No longer blocks: 1403947
I have successfully reproduced the bug with Nightly 58.0a1 (2017-09-21) on Ubuntu 12.04 LTS!

This bug's fix is Verified with latest Beta!

Build ID   : 20180209162511
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

[bugday-20180228]
I have reproduced this bug with Firefox Nightly 58.0a1 (2017-09-21) on Windows 10(x64).

The bug is no longer reproducible on Firefox 60.0a1 (2018-03-05), Firefox 59.0b14 and Firefox 60.0b1DevEd(20180302190033).

Tests were performed under Windows 10(x64), Ubuntu 16.04(x64) and macOS 10.12.6.
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.