1402200 - Expose nsRect to pixman_box helpers

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: ns-rect-box

I want to use the ArrayView constructor to nsRegion, and these make it easier to get the data into the right format.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8911022 [details] [diff] [review]
ns-rect-box

Review of attachment 8911022 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/src/nsRegion.h
@@ +395,5 @@
>    RectIterator RectIter() const { return RectIterator(*this); }
>  
> +  static inline pixman_box32_t RectToBox(const nsRect &aRect)
> +  {
> +    pixman_box32_t box = { aRect.x, aRect.y, aRect.XMost(), aRect.YMost() };

Can we use aRect.X(), aRect.Y()?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05a550261890
Expose nsRect to pixman_box helpers. r=jrmuizel

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/05a550261890