1402330 - location bar "eyeglass" icon stays in location bar after editing the URL

Status: NEW

(Firefox :: Address Bar, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

[Tracking Requested - why for this release]:

I noticed today that I had a searchfox.org window showing the "eyeglass" search icon in the location bar.  Most windows show the "circle with an i" symbol instead.  It seems like there is some race when typing in location bar and opening the window that breaks the mode switch.

Note, while the search icon is there copying the URL out of the bar excludes the "http://" scheme from the URL.  This is how I noticed the problem.

Unfortunately I have not be able to reproduce the race again.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Oh, its not a race.  Here are STR:

1. Open a searchfox URL with some line information, like:

http://searchfox.org/mozilla-central/source/dom/cache/CacheStorage.cpp#272

2. Edit the line information off the URL, but don't hit enter
3. Click out of the URL bar.

At this point the URL bar is left in search mode.  If you copy the URL it does not include the "http://" part of the URL.

I guess this is partly user error on my part, but I find the behavior a bit surprising.

Comment 2

[Julien Cristau [:jcristau]]

AFAICT this is the same in 56?

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Yea, similar behavior in FF55.  One slight difference is the "circle with i" is greyed out instead of getting the different icon.

Anyway, I don't think this is a regression.

Comment 4

[Marco Bonardo [:mak]]

This is a new UX requested behavior, when the urlbar is in edit mode or empty it shows a magnifier glass.
Evaluating the fact you find it confusing is UX matter.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for now, if there isn't much progress or a fix in ~2 weeks, this will most likely be a wontfix for 57.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a patch for 57 at this point mid-way through the beta cycle. 

mak, is this still something you are planning for 58?  I don't think release management needs to track this unless you want extra help getting work landed in time for a deadline.

Comment 7

[Marco Bonardo [:mak]]

I don't think this is something critical for 57, and I don't think we need tracking. UX may have ideas about how to improve the situation in 58 to make it less confusing for the user when he "forgets" text types in the urlbar.
Eric, could you please evaluate this in UX, and eventually forward to someone for evaluation?

Comment 8

[Eric Pang [:epang] UX]

I'll look into this, when some time opens up.  Leaving NI on myself as a reminder!